From: Jan Beulich <jbeulich@suse.com>
To: Alexandru Stefan ISAILA <aisaila@bitdefender.com>
Cc: "Kevin Tian" <kevin.tian@intel.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"George Dunlap" <George.Dunlap@eu.citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"Jun Nakajima" <jun.nakajima@intel.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH V6] x86/altp2m: Hypercall to set altp2m view visibility
Date: Wed, 4 Mar 2020 15:07:33 +0100 [thread overview]
Message-ID: <623c77c6-d00a-d15e-a1e3-3827d32e1c10@suse.com> (raw)
In-Reply-To: <dc509c91-f809-6dbb-797c-6600b4857a74@bitdefender.com>
On 04.03.2020 14:57, Alexandru Stefan ISAILA wrote:
> Hi George,
>
> This is a kind reminder if you can take a look at this patch when you
> have the time.
Are you perhaps not aware of the recent maintainer change on
xen/arch/x86/mm/? What you need to go hunt is ...
> On 03.03.2020 14:23, Alexandru Stefan ISAILA wrote:
>> At this moment a guest can call vmfunc to change the altp2m view. This
>> should be limited in order to avoid any unwanted view switch.
>>
>> The new xc_altp2m_set_visibility() solves this by making views invisible
>> to vmfunc.
>> This is done by having a separate arch.altp2m_working_eptp that is
>> populated and made invalid in the same places as altp2m_eptp. This is
>> written to EPTP_LIST_ADDR.
>> The views are made in/visible by marking them with INVALID_MFN or
>> copying them back from altp2m_eptp.
>> To have consistency the visibility also applies to
>> p2m_switch_domain_altp2m_by_id().
>>
>> Note: If altp2m mode is set to mixed the guest is able to change the view
>> visibility and then call vmfunc.
>>
>> Signed-off-by: Alexandru Isaila <aisaila@bitdefender.com>
>> ---
>> CC: Ian Jackson <ian.jackson@eu.citrix.com>
>> CC: Wei Liu <wl@xen.org>
>> CC: Andrew Cooper <andrew.cooper3@citrix.com>
>> CC: George Dunlap <George.Dunlap@eu.citrix.com>
>> CC: Jan Beulich <jbeulich@suse.com>
>> CC: Julien Grall <julien@xen.org>
>> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> CC: Stefano Stabellini <sstabellini@kernel.org>
>> CC: "Roger Pau Monné" <roger.pau@citrix.com>
>> CC: Jun Nakajima <jun.nakajima@intel.com>
>> CC: Kevin Tian <kevin.tian@intel.com>
>> ---
>> Changes since V5:
>> - Change idx type from uint16_t to unsigned int
>> - Add rc var and dropped the err return from p2m_get_suppress_ve().
>>
>> Changes since V4:
>> - Move p2m specific things from hvm to p2m.c
>> - Add comment for altp2m_idx bounds check
>> - Add altp2m_list_lock/unlock().
>>
>> Changes since V3:
>> - Change var name form altp2m_idx to idx to shorten line length
>> - Add bounds check for idx
>> - Update commit message
>> - Add comment in xenctrl.h.
>>
>> Changes since V2:
>> - Drop hap_enabled() check
>> - Reduce the indentation depth in hvm.c
>> - Fix assignment indentation
>> - Drop pad2.
>>
>> Changes since V1:
>> - Drop double view from title.
>> ---
>> tools/libxc/include/xenctrl.h | 7 +++++++
>> tools/libxc/xc_altp2m.c | 24 +++++++++++++++++++++++
... a tool stack ack and ...
>> xen/arch/x86/hvm/hvm.c | 14 ++++++++++++++
>> xen/arch/x86/hvm/vmx/vmx.c | 2 +-
... and a VMX one, also for ...
>> xen/arch/x86/mm/hap/hap.c | 15 +++++++++++++++
>> xen/arch/x86/mm/p2m-ept.c | 1 +
... this.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-03-04 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 12:23 [Xen-devel] [PATCH V6] x86/altp2m: Hypercall to set altp2m view visibility Alexandru Stefan ISAILA
2020-03-03 15:29 ` Jan Beulich
2020-03-04 13:57 ` Alexandru Stefan ISAILA
2020-03-04 14:07 ` Jan Beulich [this message]
2020-03-04 14:12 ` Alexandru Stefan ISAILA
2020-03-04 14:28 ` Alexandru Stefan ISAILA
2020-03-10 2:04 ` Tian, Kevin
2020-03-24 10:46 ` Isaila Alexandru
2020-03-27 2:30 ` Tian, Kevin
2020-03-30 6:25 ` Isaila Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=623c77c6-d00a-d15e-a1e3-3827d32e1c10@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien@xen.org \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).