Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: "aisaila@bitdefender.com" <aisaila@bitdefender.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>, WeiLiu <wl@xen.org>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] viridian: unify time sources
Date: Fri, 21 Jun 2019 15:21:49 +0000
Message-ID: <64f9319e30844036891402c0e97dc361@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5D0CF5BE020000780023A3C7@prv1-mh.provo.novell.com>

> -----Original Message-----
> From: Jan Beulich <JBeulich@suse.com>
> Sent: 21 June 2019 16:21
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: aisaila@bitdefender.com; Andrew Cooper <Andrew.Cooper3@citrix.com>; Roger Pau Monne
> <roger.pau@citrix.com>; xen-devel <xen-devel@lists.xenproject.org>; WeiLiu <wl@xen.org>
> Subject: RE: [Xen-devel] [PATCH v2] viridian: unify time sources
> 
> >>> On 21.06.19 at 15:58, <Paul.Durrant@citrix.com> wrote:
> >>  -----Original Message-----
> >> From: Alexandru Stefan ISAILA <aisaila@bitdefender.com>
> >> Sent: 21 June 2019 14:49
> >> To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org
> >> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu <wl@xen.org>; Jan Beulich
> > <jbeulich@suse.com>;
> >> Roger Pau Monne <roger.pau@citrix.com>
> >> Subject: Re: [Xen-devel] [PATCH v2] viridian: unify time sources
> >>
> >> >   /*
> >> > @@ -136,7 +100,7 @@ static int64_t time_ref_count(const struct domain *d)
> >> >    * 128 bit number which is then shifted 64 times to the right to obtain
> >> >    * the high 64 bits."
> >> >    */
> >>
> >> Is there a good reason for using signed offset here? If so then maybe
> >> you should change the return type or check for bounds.
> >
> > The offset is actually negative most of the time but the resulting reference
> > time should be unsigned so the return type of time_ref_count() does need
> > fixing.
> 
> Is switching it from int64_t to uint64_t all that's needed? I could
> do this while committing (which I was about to).

Yes, that's all that's needed and it would be nice to avoid sending a v3.

Thanks,

  Paul

> 
> Jan
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17  8:23 Paul Durrant
2019-06-20  8:44 ` Paul Durrant
2019-06-21 13:49 ` Alexandru Stefan ISAILA
2019-06-21 13:58   ` Paul Durrant
2019-06-21 15:20     ` Jan Beulich
2019-06-21 15:21       ` Paul Durrant [this message]
2019-06-21 15:08 ` Jan Beulich

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64f9319e30844036891402c0e97dc361@AMSPEX02CL03.citrite.net \
    --to=paul.durrant@citrix.com \
    --cc=Andrew.Cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=aisaila@bitdefender.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@archiver.kernel.org
	public-inbox-index xen-devel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox