* [PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating
@ 2021-02-25 15:39 Jan Beulich
2021-03-01 21:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2021-02-25 15:39 UTC (permalink / raw)
To: Wei Liu, Paul Durrant; +Cc: xen-devel, netdev
shinfo already holds the result of skb_shinfo(skb) at this point - no
need to re-invoke the construct even twice.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -557,8 +557,8 @@ check_frags:
}
if (skb_has_frag_list(skb) && !first_shinfo) {
- first_shinfo = skb_shinfo(skb);
- shinfo = skb_shinfo(skb_shinfo(skb)->frag_list);
+ first_shinfo = shinfo;
+ shinfo = skb_shinfo(shinfo->frag_list);
nr_frags = shinfo->nr_frags;
goto check_frags;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating
2021-02-25 15:39 [PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating Jan Beulich
@ 2021-03-01 21:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-01 21:10 UTC (permalink / raw)
To: Jan Beulich; +Cc: wl, paul, xen-devel, netdev
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 25 Feb 2021 16:39:01 +0100 you wrote:
> shinfo already holds the result of skb_shinfo(skb) at this point - no
> need to re-invoke the construct even twice.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Here is the summary with links:
- xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating
https://git.kernel.org/netdev/net/c/826d82170b53
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-01 21:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 15:39 [PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating Jan Beulich
2021-03-01 21:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).