From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E731CC433ED for ; Wed, 19 May 2021 14:03:25 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3BF76108D for ; Wed, 19 May 2021 14:03:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3BF76108D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.130176.243979 (Exim 4.92) (envelope-from ) id 1ljMmx-0006S5-Co; Wed, 19 May 2021 14:03:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 130176.243979; Wed, 19 May 2021 14:03:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ljMmx-0006Ry-9o; Wed, 19 May 2021 14:03:07 +0000 Received: by outflank-mailman (input) for mailman id 130176; Wed, 19 May 2021 14:03:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ljMmv-0006Rs-IG for xen-devel@lists.xenproject.org; Wed, 19 May 2021 14:03:05 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0a8854df-f6d0-4079-8833-320895bd9a7d; Wed, 19 May 2021 14:03:04 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9C452AFB1; Wed, 19 May 2021 14:03:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a8854df-f6d0-4079-8833-320895bd9a7d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1621432983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N3n94Kxto49aIydwtZ1YuEe2MS4KN56hEGTksL0LjdY=; b=YVNlgj45CvUJq9jL3eo0h4JKgNrp1Ww/ztsiWFiEagrBYVFtsNQnqX1ysL7Ku2CltUXo3r Y2oW0XNK8iWHFREu84lsGWoRwRcW5vB/DWgW5MkTUTSgBH2rIu4hVL1eL3PkqfyVkpVa73 M9R68zjm3q5yjR1BVGqcn1rDL1W/Mos= Message-ID: <671922d6fea6fe534de09d552044838df0b484c4.camel@suse.com> Subject: Re: [PATCH v3 5/5] tools/ocaml: Fix redefinition errors From: Dario Faggioli To: Julien Grall , Costin Lupu , xen-devel@lists.xenproject.org Cc: Christian Lindig , David Scott , Ian Jackson , Wei Liu Date: Wed, 19 May 2021 16:03:02 +0200 In-Reply-To: References: <50763a92df0c58ed0d7749717b7ff5e2a039a4dd.1620633386.git.costin.lupu@cs.pub.ro> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-w+dynnTqWcY8kpkCqqOG" User-Agent: Evolution 3.40.1 (by Flathub.org) MIME-Version: 1.0 --=-w+dynnTqWcY8kpkCqqOG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey, So... On Mon, 2021-05-17 at 19:16 +0100, Julien Grall wrote: > On 10/05/2021 09:35, Costin Lupu wrote: > > If PAGE_SIZE is already defined in the system (e.g. in > > /usr/include/limits.h > > header) then gcc will trigger a redefinition error because of - > > Werror. This > > patch replaces usage of PAGE_* macros with XC_PAGE_* macros in > > order to avoid > > confusion between control domain page granularity (PAGE_* > > definitions) and > > guest domain page granularity (which is what we are dealing with > > here). > >=20 > > Same issue applies for redefinitions of Val_none and Some_val > > macros which > > can be already define in the OCaml system headers (e.g. > > /usr/lib/ocaml/caml/mlvalues.h). > >=20 ... At least this part is absolutely necessary for building Xen on openSUSE Tumbleweed, therefore: > > Signed-off-by: Costin Lupu >=20 > Reviewed-by: Julien Grall >=20 Tested-by: Dario Faggioli Thanks and Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-w+dynnTqWcY8kpkCqqOG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmClGpYACgkQFkJ4iaW4 c+7SlhAAuO1vCJRxW044qTtSm4mHQ4mq8qw7LrNlm73PK23e8asr4ocLr+cG2AgY pEEjCcpDtUZ6Hj8oPDpUpEuCOjL7q9rX1Q+fAWV6ifcHyigLb4sD31yAc7m0N8oT Co4/3sioxANylWeFcWNoygwBVAZtzjuePtNqev92ZkXhHaW6sVFNriC1a1EePAm9 /BVWpi+7zvawZBn+ZIKiD1HYE/wM/cEY2LmPJL0gzMGnxv4d0ITEIVzTrEG8GC2T NzDVzw8K3dBz3Ulz7/nJpvMCohY1hqRL5a8ixIJTMjv0N09URC/8HUThlm1L6JIb 5QIf618huy5bnHZ2i/YzjTk4DwRXl3n/Lgsb/8Fw4uTguMmRNsrjRF+KUhiW7bPz A9Kwr72PFaJHNNB02lsH10zgbB/q228gVXoL0Vn0An017o9EPhfpgIvAvCQTA7I9 p0MLbXfQ4uV/0Ow+7RWInofckWyejr38yYfsXcWyH2k9dxudow6UMHZP6VO3KnxN t7JBsO8ZQ0zx/1iWpBNE3GT+UrAN91OXgf9O6PMLfT6WmSyKA9gm26n3SxoiTa+d TiuwWXWkY3iBkmfvPqIgDT6PdzZDpGwoEQY5TmGJFOSBKAn8oO1Dc15dmLIPk4Oi 0OkOHTxkaM0xUOxDZIZvlA2ZWh3pgBrGNpNH2bYoRe72MezRAfA= =F9cj -----END PGP SIGNATURE----- --=-w+dynnTqWcY8kpkCqqOG--