From: Julien Grall <julien.grall@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [Xen-devel] [PATCH] xen/console: Fix build when CONFIG_DEBUG_TRACE=y
Date: Wed, 21 Aug 2019 18:30:55 +0100 [thread overview]
Message-ID: <6807f7e1-b92b-fa40-fb90-73754543b7a6@arm.com> (raw)
In-Reply-To: <720ddd9b-5d7c-fd28-91d9-259c4b5cda36@citrix.com>
Hi,
On 20/08/2019 14:12, Andrew Cooper wrote:
> On 19/08/2019 19:37, Julien Grall wrote:
>> Hi Andrew,
>>
>> On 8/19/19 7:04 PM, Andrew Cooper wrote:
>>> On 19/08/2019 19:01, Julien Grall wrote:
>>>> Commit b5e6e1ee8da "xen/console: Don't treat NUL character as the end
>>>> of the buffer" extended sercon_puts to take the number of character
>>>> to print in argument.
>>>>
>>>> Sadly, a couple of couple of the callers in debugtrace_dump_worker()
>>>> were not converted. This result to a build failure when enabling
>>>> CONFIG_DEBUG_TRACE.
>>>>
>>>> Spotted by Travis using randconfig
>>>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>>>> ---
>>>> xen/drivers/char/console.c | 5 +++--
>>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
>>>> index 2c14c2ca73..924d4971ca 100644
>>>> --- a/xen/drivers/char/console.c
>>>> +++ b/xen/drivers/char/console.c
>>>> @@ -1185,11 +1185,12 @@ static void debugtrace_dump_worker(void)
>>>> /* Print oldest portion of the ring. */
>>>> ASSERT(debugtrace_buf[debugtrace_bytes - 1] == 0);
>>>> - sercon_puts(&debugtrace_buf[debugtrace_prd]);
>>>> + sercon_puts(&debugtrace_buf[debugtrace_prd],
>>>> + strlen(&debugtrace_buf[debugtrace_prd]));
>>>
>>> Isn't this just debugtrace_bytes - debugtrace_prd - 1 ?
>>
>> I tried and it resulted to print a lot of @^ on the console. This is
>> because the ring may not be full.
>>
>> So the portion between debugtrace_prd and debugtrace_bytes will be
>> full of zero.
>>
>> Looking at the code again, I think this portion and either be full of
>> zero character or full of non-zero character. In other word, a mix
>> would not be possible. So how about:
>>
>> if ( debugtrace_buf[debugtrace_prd] != '\0' )
>> sercon_puts(&debugtrace_buf[debugtrace_prd],
>> debugtrace_bytes - debugtrace_prd - 1);
>
> LGTM. Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Thank you! I will update the patch and commit it.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-08-21 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 18:01 [Xen-devel] [PATCH] xen/console: Fix build when CONFIG_DEBUG_TRACE=y Julien Grall
2019-08-19 18:04 ` Andrew Cooper
2019-08-19 18:37 ` Julien Grall
2019-08-20 13:12 ` Andrew Cooper
2019-08-21 17:30 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6807f7e1-b92b-fa40-fb90-73754543b7a6@arm.com \
--to=julien.grall@arm.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).