From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8182C6FA99 for ; Sun, 12 Mar 2023 17:51:40 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.509059.784200 (Exim 4.92) (envelope-from ) id 1pbPqj-0005hf-SN; Sun, 12 Mar 2023 17:51:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 509059.784200; Sun, 12 Mar 2023 17:51:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pbPqj-0005hY-PT; Sun, 12 Mar 2023 17:51:13 +0000 Received: by outflank-mailman (input) for mailman id 509059; Sun, 12 Mar 2023 17:51:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pbPqi-0005hS-GZ for xen-devel@lists.xenproject.org; Sun, 12 Mar 2023 17:51:12 +0000 Received: from madras.collabora.co.uk (madras.collabora.co.uk [2a00:1098:0:82:1000:25:2eeb:e5ab]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 778b78c1-c0fe-11ed-87f5-c1b5be75604c; Sun, 12 Mar 2023 18:51:09 +0100 (CET) Received: from [192.168.2.203] (109-252-120-116.nat.spd-mgts.ru [109.252.120.116]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1C2746602E85; Sun, 12 Mar 2023 17:51:06 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 778b78c1-c0fe-11ed-87f5-c1b5be75604c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678643467; bh=KmjCtilIVAnzFDIKkb0LhxYG2/8Y+tgikUJgYTvlXL0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Dr0o+IBtGS07EV9EJYpAoMYT9hxXlWHM6Ydt2PSMk9NGfv0b5QlurpjgaoYcuIrLs pbLMXs8hQhwCa6Xmz7Lm6yg2XA1WVMW5fnztnDJ0j4ta1GQezPd0pmTDwT73HiCQsz KqnuSlmZcxta79+ciVSgRV9ocBoeCl8KL3GBOgUXOPw6MSHXXkEA6OB2XInhorMDN1 284Pyc4q3RzXiFv3h0/JSnZI1v4r3p9XNWEFNoqVb3c8JwklWzCM/LRT7fjr74BTwl fVhQsk2aSuTc2Hg9wPNjKW5DVACpeh7snyBiYlr+oRz7GnXUb107Oly1CiQTciV0gJ 9KEJqIXopmlQA== Message-ID: <68195782-0309-2f81-7f1f-84a7fe7bb05c@collabora.com> Date: Sun, 12 Mar 2023 20:51:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus To: Huang Rui , Gerd Hoffmann , "Michael S . Tsirkin" , Stefano Stabellini , Anthony PERARD , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich , "Dr . David Alan Gilbert" , Robert Beckett , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Cc: Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , Stewart Hildebrand , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian References: <20230312092244.451465-1-ray.huang@amd.com> <20230312092244.451465-9-ray.huang@amd.com> Content-Language: en-US From: Dmitry Osipenko In-Reply-To: <20230312092244.451465-9-ray.huang@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/12/23 12:22, Huang Rui wrote: > From: Antonio Caggiano > > Request Venus when initializing VirGL. > > Signed-off-by: Antonio Caggiano > --- > hw/display/virtio-gpu-virgl.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c > index fe03dc916f..f5ce206b93 100644 > --- a/hw/display/virtio-gpu-virgl.c > +++ b/hw/display/virtio-gpu-virgl.c > @@ -803,7 +803,11 @@ int virtio_gpu_virgl_init(VirtIOGPU *g) > { > int ret; > > +#ifdef VIRGL_RENDERER_VENUS > + ret = virgl_renderer_init(g, VIRGL_RENDERER_VENUS, &virtio_gpu_3d_cbs); > +#else > ret = virgl_renderer_init(g, 0, &virtio_gpu_3d_cbs); > +#endif Note that Venus now requires VIRGL_RENDERER_RENDER_SERVER flag to be set. Please test the patches with the latest virglrenderer and etc. The #ifdef also doesn't allow adding new flags, it should look like: #ifdef VIRGL_RENDERER_VENUS flags |= VIRGL_RENDERER_RENDER_SERVER; #endif ret = virgl_renderer_init(g, flags, &virtio_gpu_3d_cbs); -- Best regards, Dmitry