From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <amc96@srcf.net>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
Daniel Smith <dpsmith@apertussolutions.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 5/5] xen/xsm: Address hypercall ABI problems
Date: Thu, 18 Nov 2021 14:01:10 +0100 [thread overview]
Message-ID: <6875511f-5b6f-9924-5852-ae51a469ef33@suse.com> (raw)
In-Reply-To: <ab199183-2413-163c-bc28-9d0b3b4627c2@srcf.net>
On 18.11.2021 00:20, Andrew Cooper wrote:
> On 17/11/2021 23:14, Andrew Cooper wrote:
>> On 08/11/2021 09:50, Jan Beulich wrote:
>>> On 05.11.2021 14:55, Andrew Cooper wrote:
>>>> --- a/xen/xsm/flask/flask_op.c
>>>> +++ b/xen/xsm/flask/flask_op.c
>>>> @@ -22,6 +22,8 @@
>>>> #include <objsec.h>
>>>> #include <conditional.h>
>>>> +#include "../private.h"
>>> Kind of odd: I'd expect a file named such to not get included
>>> across directory levels, unless a single component was split in
>>> such a way (to me Flask and XSM core are separate, yet still
>>> related components).
>>
>> Its all a tangled mess because logically separating XSM and Flask was
>> a task done when SILO was introduced.
>>
>> There is not an appropriately located file (under xen/xsm/ ) where the
>> prototypes could reasonably live, and this felt like the lesser of the
>> available evils.
>
> I guess it is worth adding, so we're all on the same page.
>
> The thing I actually need to do is fix the fact that the prototypes for
> {do,compat}_flask_op() are local in xen/xsm/flask/hooks.c and not in a
> header shared with xen/xsm/flask/flask_op.c.
And I fully agree we need to do so. Me saying "kind of odd" also wasn't
meant as an objection, just to express my surprise to see something like
this.
Jan
next prev parent reply other threads:[~2021-11-18 13:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 13:55 [PATCH 0/5] XSM: cleanups Andrew Cooper
2021-11-05 13:55 ` [PATCH 1/5] x86/altcall: allow compound types to be passed Andrew Cooper
2021-11-05 14:09 ` Daniel P. Smith
2021-11-05 13:55 ` [PATCH 2/5] xen/xsm: Complete altcall conversion of xsm interface Andrew Cooper
2021-11-05 14:00 ` Jan Beulich
2021-11-05 14:11 ` Daniel P. Smith
2021-11-08 9:11 ` Jan Beulich
2021-11-17 22:22 ` Andrew Cooper
2021-11-05 13:55 ` [PATCH 3/5] xen/xsm: Drop xsm_hvm_control() hook Andrew Cooper
2021-11-05 14:20 ` Daniel P. Smith
2021-11-05 13:55 ` [PATCH 4/5] xen/xsm: Improve fallback handling in xsm_fixup_ops() Andrew Cooper
2021-11-05 14:22 ` Daniel P. Smith
2021-11-08 9:04 ` Jan Beulich
2021-11-17 22:37 ` Andrew Cooper
2021-11-18 11:59 ` Jan Beulich
2021-11-05 13:55 ` [PATCH 5/5] xen/xsm: Address hypercall ABI problems Andrew Cooper
2021-11-08 9:50 ` Jan Beulich
2021-11-17 23:14 ` Andrew Cooper
2021-11-17 23:20 ` Andrew Cooper
2021-11-18 13:01 ` Jan Beulich [this message]
2021-11-18 12:59 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6875511f-5b6f-9924-5852-ae51a469ef33@suse.com \
--to=jbeulich@suse.com \
--cc=amc96@srcf.net \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=dpsmith@apertussolutions.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).