From: Aaron Cornelius <aaron.cornelius@dornerworks.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>
Subject: Re: Xen 4.7 crash
Date: Tue, 7 Jun 2016 11:13:55 -0400 [thread overview]
Message-ID: <690b3dff-d4cd-2438-c178-24be67bf4c91@dornerworks.com> (raw)
In-Reply-To: <2d247f34-8d30-116a-e4df-4819a7bd7fbc@dornerworks.com>
On 6/7/2016 9:40 AM, Aaron Cornelius wrote:
> On 6/7/2016 5:53 AM, Ian Jackson wrote:
>> Aaron Cornelius writes ("Re: [Xen-devel] Xen 4.7 crash"):
>>> We realized that we had forgotten to remove the domain from the
>>> permissions list when the domain is deleted (which would cause the error
>>> we saw). The application was updated to remove the domain from the
>>> permissions list:
>>> 1. retrieve the permissions with xs_get_permissions()
>>> 2. find the domain ID that is being deleted
>>> 3. memmove() the remaining domains down by 1 to "delete" the old domain
>>> from the permissions list
>>> 4. update the permissions with xs_set_permissions()
>>>
>>> After we made that change, a load test over the weekend confirmed that
>>> the Xen crash no longer happens. We checked this morning first thing
>>> and confirmed that without this change the crash reliably occurs.
>>
>> This is rather odd behaviour. I don't think xenstored should hang
>> onto the domain's xs ring page just because the domain is still
>> mentioned in a permission list.
>>
>> But it may do. I haven't checked the code. Are you using the
>> ocaml xenstored (oxenstored) or the C one ?
>
> I didn't remember specifying anything special when building the xen
> tools, but I did run into troubles where the ocaml tools appeared to
> conflict with the opam installed mirage packages and libraries. Running
> "sudo make dist-install" command installs the ocaml libraries as root
> which made using opam difficult. So I did disable the ocaml tools
> during my build.
>
> I double checked and confirmed that the C version of xenstored was
> built. We will try to test the failure scenario with oxenstored to see
> if it behaves any differently.
I am not that familiar with the xenstored code, but as far as I can tell
the grant mapping will be held by the xenstore until the xs_release()
function is called (which is not called by libxl, and I do not
explicitly call it in my software, although I might now just to be
safe), or until the last reference to a domain is released and the
registered destructor (destroy_domain), set by talloc_set_destructor(),
is called.
I tried to follow the oxenstored code, but I certainly don't consider
myself an expert at OCaml. The oxenstored code does not appear to
allocate grant mappings at all, which makes me think I am probably
misunderstanding the code :)
- Aaron
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-07 15:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 19:54 Xen 4.7 crash Aaron Cornelius
2016-06-01 20:00 ` Andrew Cooper
2016-06-01 20:45 ` Aaron Cornelius
2016-06-01 21:24 ` Andrew Cooper
2016-06-01 22:18 ` Julien Grall
2016-06-01 22:26 ` Andrew Cooper
2016-06-01 21:35 ` Andrew Cooper
2016-06-01 22:24 ` Julien Grall
2016-06-01 22:31 ` Andrew Cooper
2016-06-02 8:47 ` Jan Beulich
2016-06-02 8:53 ` Andrew Cooper
2016-06-02 9:07 ` Jan Beulich
2016-06-01 22:35 ` Julien Grall
2016-06-02 1:32 ` Aaron Cornelius
2016-06-02 8:49 ` Jan Beulich
2016-06-02 9:07 ` Julien Grall
2016-06-06 13:58 ` Aaron Cornelius
2016-06-06 14:05 ` Julien Grall
2016-06-06 14:19 ` Wei Liu
2016-06-06 15:02 ` Aaron Cornelius
2016-06-07 9:53 ` Ian Jackson
2016-06-07 13:40 ` Aaron Cornelius
2016-06-07 15:13 ` Aaron Cornelius [this message]
2016-06-09 11:14 ` Ian Jackson
2016-06-14 13:11 ` Aaron Cornelius
2016-06-14 13:15 ` Wei Liu
2016-06-14 13:26 ` Aaron Cornelius
2016-06-14 13:38 ` Aaron Cornelius
2016-06-14 13:47 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=690b3dff-d4cd-2438-c178-24be67bf4c91@dornerworks.com \
--to=aaron.cornelius@dornerworks.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).