From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/3] x86/hvm: Introduce experimental guest CET support
Date: Fri, 30 Apr 2021 16:08:14 +0100 [thread overview]
Message-ID: <693c7708-b699-51df-1c1b-5d25a43a2dca@citrix.com> (raw)
In-Reply-To: <d0731b8b-7dd7-ed9f-e3fa-6543ed5e5afd@suse.com>
On 29/04/2021 10:07, Jan Beulich wrote:
> On 28.04.2021 19:54, Andrew Cooper wrote:
>> I know we're making up our "how to do complicated experimental features"
>> process as we go here, but nothing *in Xen* will malfunction if a user
>> opts into CET_SS/IBT. Therefore I think they're fine to go in and stay.
> Well, okay then. I hope possibls future additions of mine then will
> get similar treatment.
So having thought on this for a while...
The annotations in the header file don't help me. My dev workflow
already starts with turning them to default, skips messing around with
toolstack level things.
At this point in feature development, there is no use to anyone who
isn't also editing the hypervisor too.
So unless it is going to help you (and I suspect it wont), its probably
not helpful to the wider world.
I'll drop the markings from this patch, and put them back in at the
point that we believe "basic VMs" work.
~Andrew
next prev parent reply other threads:[~2021-04-30 15:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 17:54 [PATCH 0/3] x86: Initial pieces for guest CET support Andrew Cooper
2021-04-26 17:54 ` [PATCH 1/3] x86/hvm: Introduce experimental " Andrew Cooper
2021-04-27 15:47 ` Jan Beulich
2021-04-27 17:39 ` Andrew Cooper
2021-04-28 9:11 ` Jan Beulich
2021-04-28 17:54 ` Andrew Cooper
2021-04-29 9:07 ` Jan Beulich
2021-04-30 15:08 ` Andrew Cooper [this message]
2021-04-26 17:54 ` [PATCH 2/3] x86/svm: Enumeration for CET Andrew Cooper
2021-04-27 15:53 ` Jan Beulich
2021-04-27 17:47 ` Andrew Cooper
2021-04-28 9:14 ` Jan Beulich
2021-04-28 14:17 ` Andrew Cooper
2021-04-26 17:54 ` [PATCH 3/3] x86/VT-x: " Andrew Cooper
2021-04-27 15:56 ` Jan Beulich
2021-04-27 16:27 ` Andrew Cooper
2021-04-28 9:18 ` Jan Beulich
2021-04-27 6:46 ` [PATCH 0/3] x86: Initial pieces for guest CET support Jan Beulich
2021-04-27 10:13 ` Andrew Cooper
2021-04-28 12:25 ` Andrew Cooper
2021-04-28 13:03 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=693c7708-b699-51df-1c1b-5d25a43a2dca@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).