From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B69CEC433E2 for ; Mon, 14 Sep 2020 15:11:08 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7137620829 for ; Mon, 14 Sep 2020 15:11:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7137620829 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kHq83-0000Iz-8a; Mon, 14 Sep 2020 15:10:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kHq82-0000It-3Y for xen-devel@lists.xenproject.org; Mon, 14 Sep 2020 15:10:50 +0000 X-Inumbo-ID: 71b2f012-11ef-40d9-91bc-1b622ac7e741 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 71b2f012-11ef-40d9-91bc-1b622ac7e741; Mon, 14 Sep 2020 15:10:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 285BEAFC1; Mon, 14 Sep 2020 15:11:04 +0000 (UTC) Subject: Re: [PATCH V1 04/16] xen/ioreq: Provide alias for the handle_mmio() To: Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, Oleksandr Tyshchenko , Paul Durrant , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Julien Grall References: <1599769330-17656-1-git-send-email-olekstysh@gmail.com> <1599769330-17656-5-git-send-email-olekstysh@gmail.com> From: Jan Beulich Message-ID: <6b3fc5ef-b13b-26c0-17dc-10e6a51c59a3@suse.com> Date: Mon, 14 Sep 2020 17:10:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1599769330-17656-5-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 10.09.2020 22:21, Oleksandr Tyshchenko wrote: > --- a/xen/common/ioreq.c > +++ b/xen/common/ioreq.c > @@ -189,7 +189,7 @@ bool handle_hvm_io_completion(struct vcpu *v) > break; > > case HVMIO_mmio_completion: > - return handle_mmio(); > + return ioreq_handle_complete_mmio(); Again the question: Any particular reason to have "handle" in here? With the abstraction simply named ioreq_complete_mmio() feel free to add Acked-by: Jan Beulich Jan