From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA65C433B4 for ; Sun, 18 Apr 2021 18:26:31 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0CCF6023E for ; Sun, 18 Apr 2021 18:26:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0CCF6023E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.112544.214718 (Exim 4.92) (envelope-from ) id 1lYC7a-00087k-RE; Sun, 18 Apr 2021 18:26:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 112544.214718; Sun, 18 Apr 2021 18:26:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYC7a-00087d-NW; Sun, 18 Apr 2021 18:26:14 +0000 Received: by outflank-mailman (input) for mailman id 112544; Sun, 18 Apr 2021 18:26:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYC7Z-00087Y-Er for xen-devel@lists.xenproject.org; Sun, 18 Apr 2021 18:26:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYC7Z-0007v5-5C; Sun, 18 Apr 2021 18:26:13 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lYC7Y-00044d-TP; Sun, 18 Apr 2021 18:26:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=xCeqe2qzkmXuPMgLqo0adcs82fb9T2Lp6dKCofvqgZk=; b=IQdE5xzfW0MU404U1LHrpk8Igq +quuWh9AyZodsJzQ2Yth0fJcvT7aqxfzDMnphaKD7yiTvaOlM1xDEZ0Vbvqnefsfp+jZ6K62yJLEr jERwknqS8yXOfsMCYVuhTf4ok4h4z18SIbrGalgGoMWyUjWWY8N04cU24qq7RUiO4Y/E=; Subject: Re: [PATCH v2] xen/arm: kernel: Propagate the error if we fail to decompress the kernel To: Michal Orzel , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall References: <20210406191554.12012-1-julien@xen.org> <591603c5-ebcb-e9d6-74a0-bed921458a69@arm.com> From: Julien Grall Message-ID: <6c8133a5-dc78-083b-0cec-69860e46daf7@xen.org> Date: Sun, 18 Apr 2021 19:26:11 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <591603c5-ebcb-e9d6-74a0-bed921458a69@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Michal, On 12/04/2021 07:45, Michal Orzel wrote: > On 06.04.2021 21:15, Julien Grall wrote: >> From: Julien Grall >> >> Currently, we are ignoring any error from perform_gunzip() and replacing >> the compressed kernel with the "uncompressed" kernel. >> >> If there is a gzip failure, then it means that the output buffer may >> contain garbagge. So it can result to various sort of behavior that may >> be difficult to root cause. >> >> In case of failure, free the output buffer and propagate the error. >> We also need to adjust the return check for kernel_compress() as >> perform_gunzip() may return a positive value. >> >> Take the opportunity to adjust the code style for the check. >> >> Signed-off-by: Julien Grall >> >> --- >> Changes in v2: >> - Fix build >> --- > > Reviewed-by: Michal Orzel Thanks! @Stefano, can I get your acked-by? Cheers, -- Julien Grall