From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Jan Beulich" <jbeulich@suse.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Cc: Ian Jackson <Ian.Jackson@citrix.com>,
Christian Lindig <christian.lindig@citrix.com>,
Wei Liu <wl@xen.org>, Rob Hoes <Rob.Hoes@citrix.com>
Subject: Re: [Xen-devel] [PATCH] fixup sysctl/libxl: choose a sane default for HAP
Date: Tue, 10 Sep 2019 15:44:05 +0100 [thread overview]
Message-ID: <6d74c686-97f4-fc44-d95b-7c1822e86d3e@citrix.com> (raw)
In-Reply-To: <00ee2c15-aaa5-6be5-6862-cd7d582b7e7f@suse.com>
On 10/09/2019 15:43, Jan Beulich wrote:
> On 09.09.2019 15:47, Andrew Cooper wrote:
>> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
>> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
>> @@ -690,7 +690,8 @@ CAMLprim value stub_xc_physinfo(value xch)
>> BUILD_BUG_ON(XEN_SYSCTL_PHYSCAP_hvm != (1u << 0));
>> BUILD_BUG_ON(XEN_SYSCTL_PHYSCAP_pv != (1u << 1));
>> BUILD_BUG_ON(XEN_SYSCTL_PHYSCAP_directio != (1u << 2));
>> - BUILD_BUG_ON(XEN_SYSCTL_PHYSCAP_MAX != XEN_SYSCTL_PHYSCAP_directio);
>> + BUILD_BUG_ON(XEN_SYSCTL_PHYSCAP_hap != (1u << 3));
>> + BUILD_BUG_ON(XEN_SYSCTL_PHYSCAP_MAX != XEN_SYSCTL_PHYSCAP_hap);
>> cap_list = c_bitmap_to_ocaml_list(c_physinfo.capabilities);
>>
>> physinfo = caml_alloc_tuple(10);
> I'm afraid in particular this hunk doesn't apply anymore, and
> I'm not confident that simply dropping it is the right answer.
> I'd therefore like to ask for a proper re-base, or for someone
> else to apply the result of folding these additions into the
> base patch.
Roger is currently working on a rebase. There is also a logical error
which requires the addition of CAP_SHADOW.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-10 14:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 14:30 [Xen-devel] [PATCH v3 0/2] libxl: choose a sane default for HAP Roger Pau Monne
2019-09-06 14:30 ` [Xen-devel] [PATCH v3 1/2] sysctl: report existing physcaps on ARM Roger Pau Monne
2019-09-09 10:07 ` Julien Grall
2019-09-06 14:30 ` [Xen-devel] [PATCH v3 2/2] sysctl/libxl: choose a sane default for HAP Roger Pau Monne
2019-09-06 14:39 ` Andrew Cooper
2019-09-09 10:10 ` Julien Grall
2019-09-09 13:47 ` [Xen-devel] [PATCH] fixup " Andrew Cooper
2019-09-09 14:29 ` Ian Jackson
2019-09-10 14:43 ` Jan Beulich
2019-09-10 14:44 ` Andrew Cooper [this message]
2019-09-09 14:10 ` [Xen-devel] [PATCH v3 2/2] " Ian Jackson
2019-09-09 10:21 ` [Xen-devel] [PATCH v3 0/2] libxl: " Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d74c686-97f4-fc44-d95b-7c1822e86d3e@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=Rob.Hoes@citrix.com \
--cc=christian.lindig@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).