From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2F6C47096 for ; Wed, 2 Jun 2021 15:18:44 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 976FD613B4 for ; Wed, 2 Jun 2021 15:18:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 976FD613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.136101.252518 (Exim 4.92) (envelope-from ) id 1loSda-0004nP-Mn; Wed, 02 Jun 2021 15:18:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 136101.252518; Wed, 02 Jun 2021 15:18:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1loSda-0004m3-Fw; Wed, 02 Jun 2021 15:18:30 +0000 Received: by outflank-mailman (input) for mailman id 136101; Wed, 02 Jun 2021 15:18:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1loSdZ-0004jb-GL for xen-devel@lists.xenproject.org; Wed, 02 Jun 2021 15:18:29 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 87ef2c64-4598-4334-bfc3-f44c95073228; Wed, 02 Jun 2021 15:18:28 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4BFDE22C1A; Wed, 2 Jun 2021 15:18:27 +0000 (UTC) Received: by imap.suse.de (Postfix, from userid 51) id 460F611CF5; Wed, 2 Jun 2021 16:20:03 +0000 (UTC) Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 4015F11DE8; Wed, 2 Jun 2021 11:41:03 +0000 (UTC) Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id d7SUDU9ut2DaewAALh3uQQ (envelope-from ); Wed, 02 Jun 2021 11:41:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87ef2c64-4598-4334-bfc3-f44c95073228 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1622647107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r3zuSfwQN7zBaKL5TqfD/RmuyIeMWyu+WlTPlVT5+LI=; b=gnF4r6twZWNm2+YO0qBVvYstL4BDPKwOlx73GsNcF+REtmJoJlfC08Q1BU/3kE8st6a2Z6 xAxCp0QxGVYTg1YfBEyCJLJyT78jihmVrt2XQsDOS1ktGlLmwj4ZTdzF3hZ/WsYgDrNXWC yWKkyG5z+DnORwAVcKeL1iKYP2qDArk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1622634063; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r3zuSfwQN7zBaKL5TqfD/RmuyIeMWyu+WlTPlVT5+LI=; b=MaY69p2lUfnyP8/qh2nc8Y7yFCzhM1SWOjgyx+sgmjlP4Fy0lx/YdFWHpwPhxSuVxlRZr4 HGVKpF+PU9nnwvZHvewUzRiQaYN5Zq97MGrwrJySZ4M9P2vb2vwNtQtUVCRg2M62jQNcYN W24sN7v6VbgK67LFM4lXGNLvF/nwuJM= Subject: Re: [PATCH v20210601 04/38] tools: add readv_exact to libxenctrl To: Olaf Hering Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu References: <20210601161118.18986-1-olaf@aepfle.de> <20210601161118.18986-5-olaf@aepfle.de> <23783088-dc59-abd1-c66c-5fcd314d1f5c@suse.com> <20210602125710.0607a985.olaf@aepfle.de> From: Juergen Gross Message-ID: <6e1aed4e-8d32-0711-609d-dfabe906c40e@suse.com> Date: Wed, 2 Jun 2021 13:41:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210602125710.0607a985.olaf@aepfle.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jfUCIWCISRqnAjGkfDYj1kuV2A0dM3GoT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jfUCIWCISRqnAjGkfDYj1kuV2A0dM3GoT Content-Type: multipart/mixed; boundary="JYSncPRfdKTqTZiOSRHaHouY2ECVN8EpO"; protected-headers="v1" From: Juergen Gross To: Olaf Hering Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu Message-ID: <6e1aed4e-8d32-0711-609d-dfabe906c40e@suse.com> Subject: Re: [PATCH v20210601 04/38] tools: add readv_exact to libxenctrl References: <20210601161118.18986-1-olaf@aepfle.de> <20210601161118.18986-5-olaf@aepfle.de> <23783088-dc59-abd1-c66c-5fcd314d1f5c@suse.com> <20210602125710.0607a985.olaf@aepfle.de> In-Reply-To: <20210602125710.0607a985.olaf@aepfle.de> --JYSncPRfdKTqTZiOSRHaHouY2ECVN8EpO Content-Type: multipart/mixed; boundary="------------291C54DF7E40402F047AA85B" Content-Language: en-US This is a multi-part message in MIME format. --------------291C54DF7E40402F047AA85B Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 02.06.21 12:57, Olaf Hering wrote: > Am Wed, 2 Jun 2021 08:30:08 +0200 > schrieb Juergen Gross : >=20 >> On 01.06.21 18:10, Olaf Hering wrote: >>> +int readv_exact(int fd, const struct iovec *iov, int iovcnt) >=20 >>> + if ( len <=3D 0 ) >>> + { >>> + rc =3D -1; >> Is EOF really an error? >=20 > I think yes, that's what "exact" implies IMO. Shouldn't you check for zero length iovec elements as in the writev_exact() case then? >> This will stop the loop, even if idx hasn't reached iovcnt. >=20 > Yes, it will trigger yet another readv(). Ah, right. Juergen --------------291C54DF7E40402F047AA85B Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------291C54DF7E40402F047AA85B-- --JYSncPRfdKTqTZiOSRHaHouY2ECVN8EpO-- --jfUCIWCISRqnAjGkfDYj1kuV2A0dM3GoT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmC3bk4FAwAAAAAACgkQsN6d1ii/Ey+J 5ggAlh8D0FwQ31aM3YUUrYpW56c6kcDQUCjbvU3xBZ0Y/jia5E9TkcqsKJ28TRu7SEezSkPMRmIa LpRvAJkExWVzllMz5uPa53N5MItJWsMsiKup9bnhBg0Nberbdu4NPy43KYvjy7Cm1rSL6FIaOZE8 cRkddGLTnApC4xuaSqY3pOnAjtQJW/+EMXOzDodROReiQadzW5326i5nM408eCZaV+0PNQSvJ+rb EBadVRt/5UvKQAiwn0XN0j/lNdjICqXKe2hzeuuQgp9D1SUJd7Ng5eMGz6zw9LfBVVadCIoPLim4 34lGtbE49gRD8OmQT3faMToykVH/aD3TrLZ7jQvozw== =Wgsp -----END PGP SIGNATURE----- --jfUCIWCISRqnAjGkfDYj1kuV2A0dM3GoT--