From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F5C0C433B4 for ; Fri, 16 Apr 2021 14:35:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10FD5610CB for ; Fri, 16 Apr 2021 14:35:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10FD5610CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.111821.213834 (Exim 4.92) (envelope-from ) id 1lXPYs-0008BT-S6; Fri, 16 Apr 2021 14:35:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 111821.213834; Fri, 16 Apr 2021 14:35:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lXPYs-0008BM-P9; Fri, 16 Apr 2021 14:35:10 +0000 Received: by outflank-mailman (input) for mailman id 111821; Fri, 16 Apr 2021 14:35:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lXPYr-0008BG-J5 for xen-devel@lists.xenproject.org; Fri, 16 Apr 2021 14:35:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lXPYq-0008EL-GS; Fri, 16 Apr 2021 14:35:08 +0000 Received: from [54.239.6.188] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lXPYq-0008Hr-1O; Fri, 16 Apr 2021 14:35:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=3KAeZ0PxqUnHyQxAynro00Zq8BtxXDyHD3cVH0TTUS4=; b=sZKN5dwPA4o9KL9rDkcpb3aU5T cQqdKALHJZ1WiF43+eQvFCaOs5tiCn4iLbb45y3p6ZCLYJLN8lOKpdtSqNQi2pfT9rJaRHbbF5sFz isrUvQaYv9XVNsFf171QT3o2eztykjgCWoFBVk9IN1T/DBG3eQY6j5noTF7B5fkSzlkk=; Subject: Re: [PATCH] xen/arm: smmuv1: Revert associating the group pointer with the S2CR To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: From: Julien Grall Message-ID: <6e75d112-6cc1-4b7c-9751-4064b3250dbf@xen.org> Date: Fri, 16 Apr 2021 15:35:05 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi, On 16/04/2021 12:25, Rahul Singh wrote: > Revert the code that associates the group pointer with the S2CR as this > code causing an issue when the SMMU device has more than one master > device. It is not clear to me why this change was first added. Are we missing any feature when reverting it? > This code is merged with the commit "xen/arm: smmuv1: Intelligent > SMR allocation”. > This wants a fixes tag. Can be added on commit if there is nothing else to change. Cheers, -- Julien Grall