From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [RFC PATCH 1/7] build: add debug menu to Kconfig Date: Mon, 2 May 2016 09:35:55 -0500 Message-ID: <6f8cde38-17fa-73c5-3fca-da79ff0a54f7@cardoe.com> References: <1462162246-32413-1-git-send-email-cardoe@cardoe.com> <1462162246-32413-2-git-send-email-cardoe@cardoe.com> <20160502104245.GP26957@citrix.com> <965e7326-25d1-2c1a-af2d-a85b3af9b1c3@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1023729637564201428==" Return-path: In-Reply-To: <965e7326-25d1-2c1a-af2d-a85b3af9b1c3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , Wei Liu Cc: Stefano Stabellini , George Dunlap , Tim Deegan , Ian Jackson , xen-devel@lists.xen.org, Jan Beulich List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1023729637564201428== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c2HHTTtgPxLEcLQikOtEJ7xpU9mL906AJ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --c2HHTTtgPxLEcLQikOtEJ7xpU9mL906AJ Content-Type: multipart/mixed; boundary="tWsNsFtSNBvEf2ASJ1MBd6uwSGJUlRXeK" From: Doug Goldstein To: Andrew Cooper , Wei Liu Cc: xen-devel@lists.xen.org, George Dunlap , Ian Jackson , Jan Beulich , Konrad Rzeszutek Wilk , Stefano Stabellini , Tim Deegan Message-ID: <6f8cde38-17fa-73c5-3fca-da79ff0a54f7@cardoe.com> Subject: Re: [RFC PATCH 1/7] build: add debug menu to Kconfig References: <1462162246-32413-1-git-send-email-cardoe@cardoe.com> <1462162246-32413-2-git-send-email-cardoe@cardoe.com> <20160502104245.GP26957@citrix.com> <965e7326-25d1-2c1a-af2d-a85b3af9b1c3@citrix.com> In-Reply-To: <965e7326-25d1-2c1a-af2d-a85b3af9b1c3@citrix.com> --tWsNsFtSNBvEf2ASJ1MBd6uwSGJUlRXeK Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 5/2/16 6:02 AM, Andrew Cooper wrote: > On 02/05/2016 11:42, Wei Liu wrote: >> On Sun, May 01, 2016 at 11:10:40PM -0500, Doug Goldstein wrote: >>> There are a number of debugging options for Xen so the idea is to hav= e a >>> menu to group them all together. Enabling this menu item will also >>> disable NDEBUG which will result in more debug prints. This was >>> previously wired into the 'debug=3Dy' command line option. >>> >>> Signed-off-by: Doug Goldstein >>> --- >>> CC: Andrew Cooper >>> CC: George Dunlap >>> CC: Ian Jackson >>> CC: Jan Beulich >>> CC: Konrad Rzeszutek Wilk >>> CC: Stefano Stabellini >>> CC: Tim Deegan >>> CC: Wei Liu >>> --- >>> xen/Kconfig | 2 ++ >>> xen/Kconfig.debug | 7 +++++++ >>> xen/include/xen/config.h | 4 ++++ >>> 3 files changed, 13 insertions(+) >>> create mode 100644 xen/Kconfig.debug >>> >>> diff --git a/xen/Kconfig b/xen/Kconfig >>> index fa8b27c..0fe7a1a 100644 >>> --- a/xen/Kconfig >>> +++ b/xen/Kconfig >>> @@ -26,3 +26,5 @@ config DEFCONFIG_LIST >>> config EXPERT >>> string >>> option env=3D"XEN_CONFIG_EXPERT" >>> + >>> +source "Kconfig.debug" >>> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug >>> new file mode 100644 >>> index 0000000..d14d758 >>> --- /dev/null >>> +++ b/xen/Kconfig.debug >>> @@ -0,0 +1,7 @@ >>> + >>> +menuconfig DEBUG >>> + bool "Debugging Options" >>> + ---help--- >>> + If you want to debug Xen say Y and select any additional debuggin= g >>> + support options. This enables additional debugging through Xen >>> + and as a result enabling this option results in no security guara= ntees. >> Maybe that's because I'm not a native speaker, this doesn't sound righ= t >> to me -- it implies debugging option makes xen insecure. >> >> I think you mean "results in no security support"? >=20 > Instead of mentioning security, I would simply say "Enabling this optio= n > is intended for development purposes only, and not for production use".= >=20 > There is already a statement saying that issues which only affect a > debug hypervisor are not considered security relevant. >=20 > ~Andrew >=20 Yeah that's better wording than what I've got. I'll update it. Thanks! --=20 Doug Goldstein --tWsNsFtSNBvEf2ASJ1MBd6uwSGJUlRXeK-- --c2HHTTtgPxLEcLQikOtEJ7xpU9mL906AJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJXJ2XOXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUPUwQAIlFO24zinjGUJ0KbXUV/Eha DRno3d8qCeJlPwEgkrZZjVFE/vXmu/LpSEtffg++JAyZ67J0fHW7gQ/EPHrGyAE/ BuQXnGjvD8htJW1fHAex7I5GcEqVTIcP+0BGxrjFENAYKgnUhnAm8UDEral+CQd3 FybNY2hgMWfU/EJ2OGLCeUFQlu+S5hgBoLplHYrGRkDoluLMJIAgrT6cDFAVHJWq 0Dia3Jgg5xHmiwZn5dY0glVtlql015chycpZh1N0YpD/xl8ubMkVQDqrEboJjOhA qjlAsj+nueZQZl9MnsvliR9RhI4PY3+yf3DhSAVqOCe4ZCtcYrrjBnnP0P6pYIBL DOfrGHNJYiQTQ+R+j8wUNnMGt4nE06XTb6V5aNl0ZN3eZ7TYFbFjZvHaVIuRWTn6 EpD/kKGGRLAAw7RtFAIKUW38knU4YSYciSgA6zQzR/gu5nQCVgB3ge5bjO3Qsf/8 ZsC5Tt+5p0KIPmFQBNjZuhsljuoBGVu73blZZyU1WHzZZd+hx7pG53Ma/SF4gJH+ qVARcRkRP2l+krgsbhI8k4mu6fKJzx6yQJtkW1Z9cJbbwLiQhK8ghD97Ti/0qkG4 EDzwjilj8SlQTAXNwhGrMB4wZu4pIm7OcMOVY31NpowAaG+v6Gcfk9gdM5om0YCA aJLkjqeFRgcvZX8ZwpLJ =+t6t -----END PGP SIGNATURE----- --c2HHTTtgPxLEcLQikOtEJ7xpU9mL906AJ-- --===============1023729637564201428== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============1023729637564201428==--