From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] x86: show remote CPU state upon fatal NMI or unknown MCE
Date: Thu, 16 Jun 2016 12:32:24 +0100 [thread overview]
Message-ID: <720d3e7f-0d52-9a92-7ca5-6e38401a903e@citrix.com> (raw)
In-Reply-To: <5762A91602000078000F5A71@prv-mh.provo.novell.com>
On 16/06/16 12:26, Jan Beulich wrote:
> @@ -570,6 +589,15 @@ void fatal_trap(const struct cpu_user_re
> printk("Faulting linear address: %p\n", _p(cr2));
> show_page_walk(cr2);
> }
> + if ( show_remote )
> + {
> + cpumask_andnot(&show_state_mask, &cpu_online_map,
> + cpumask_of(smp_processor_id()));
> + set_nmi_callback(nmi_show_execution_state);
> + smp_send_nmi_allbutself();
> + while ( !cpumask_empty(&show_state_mask) )
> + cpu_relax();
Sorry about not noticing this before. We need a maximum timeout here,
just like the nmi shootdown, in case one of the other cpus is already
stuck in an NMI handler, so we block the reboot/kexec.
With that fixed, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-16 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 11:26 [PATCH v2] x86: show remote CPU state upon fatal NMI or unknown MCE Jan Beulich
2016-06-16 11:32 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=720d3e7f-0d52-9a92-7ca5-6e38401a903e@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).