From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Juergen Gross" <jgross@suse.com>, "Wei Liu" <wl@xen.org>,
"Paul Durrant" <paul@xen.org>,
"Paul Durrant" <pdurrant@gmail.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] x86/hvm: Fix the use of "hap=0" following c/s c0902a9a143a
Date: Thu, 10 Oct 2019 09:06:24 +0200 [thread overview]
Message-ID: <72a06a9d-53f8-925e-6e2b-4115bb952245@suse.com> (raw)
In-Reply-To: <CACCGGhAhK_fbiJbUn-nPnFEWK6AvFye1r7Di-3j5UEwNW916rg@mail.gmail.com>
On 09.10.2019 20:56, Paul Durrant wrote:
> On Wed, 9 Oct 2019 at 19:21, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>>
>> c/s c0902a9a143a refactored hvm_enable() a little, but dropped the logic which
>> cleared hap_supported in the case that the user had asked for it off.
>>
>> This results in Xen booting up, claiming:
>>
>> (XEN) HVM: Hardware Assisted Paging (HAP) detected but disabled
>>
>> but with HAP advertised via sysctl, and XEN_DOMCTL_CDF_hap being accepted in
>> domain_create().
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> That should have been largely code movement, so I don't know how I
> managed to drop that.
>
> Reviewed-by: Paul Durrant <paul@xen.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-10 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 18:21 [Xen-devel] [PATCH] x86/hvm: Fix the use of "hap=0" following c/s c0902a9a143a Andrew Cooper
2019-10-09 18:56 ` Paul Durrant
2019-10-10 7:06 ` Jan Beulich [this message]
2019-10-09 19:05 ` Wei Liu
2019-10-10 4:19 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72a06a9d-53f8-925e-6e2b-4115bb952245@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=jgross@suse.com \
--cc=paul@xen.org \
--cc=pdurrant@gmail.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).