From: Andrew Cooper <andrew.cooper3@citrix.com>
To: <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation
Date: Thu, 25 Mar 2021 09:37:49 +0000 [thread overview]
Message-ID: <7407cac8-c55d-0372-123b-39c9949e6ca5@citrix.com> (raw)
In-Reply-To: <0A187740-DB6E-486C-8B10-5207CE6A5D72@citrix.com>
On 25/03/2021 09:04, George Dunlap wrote:
>
>> On Mar 25, 2021, at 7:57 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 24.03.2021 17:44, George Dunlap wrote:
>>> --- a/CHANGELOG.md
>>> +++ b/CHANGELOG.md
>>> @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>>> - Named PCI devices for xl/libxl
>>> - Support for zstd-compressed dom0 kernels
>>> - Library improvements from NetBSD ports upstreamed
>>> + - x86_emulate: Support AVX-VNNI instructions
>>> + - x86_emulate: Expanded testing for several instruction classes
>> TBH both seem too minor to me to be mentioned here. If I was to pick
>> just one, I'd keep the former and drop the latter.
> It’s always quite difficult in these releases to help express to people exactly what’s happened. We’ve got over 1000 changesets — what have we been doing? If my star chart is correct, the latter represents nearly 1700 extra lines of codes in tools/tests/x86_emulator/predicates.c. It’s actually a reasonable chunk of code churn, which I think is worth highlighting.
I agree with Jan. New concrete instruction groups are useful for an end
user to read. "We refactored some internal of a test harness" isn't,
especially when it would most likely be repeated every release.
I'd drop the latter line and just keep the former.
~Andrew
next prev parent reply other threads:[~2021-03-25 9:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 16:44 [PATCH 1/6] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries George Dunlap
2021-03-24 16:44 ` [PATCH 2/6] CHANGELOG.md: Add named PCI devices George Dunlap
2021-03-26 7:44 ` Paul Durrant
2021-03-24 16:44 ` [PATCH 3/6] CHANGELOG.md: Add dom0 zstd compression support George Dunlap
2021-03-24 16:56 ` Andrew Cooper
2021-03-24 17:10 ` George Dunlap
2021-03-24 16:44 ` [PATCH 4/6] CHANGELOG.md: NetBSD lib/gnttab support George Dunlap
2021-03-25 9:13 ` Roger Pau Monné
2021-03-25 9:28 ` Manuel Bouyer
2021-03-24 16:44 ` [PATCH 5/6] CHANGELOG.md: Add entries for emulation George Dunlap
2021-03-25 7:57 ` Jan Beulich
2021-03-25 9:04 ` George Dunlap
2021-03-25 9:37 ` Andrew Cooper [this message]
2021-03-25 13:58 ` Jan Beulich
2021-03-29 16:06 ` George Dunlap
2021-03-29 16:24 ` Jan Beulich
2021-03-24 16:44 ` [PATCH 6/6] CHANGELOG.md: Add entries for CI loop George Dunlap
2021-03-24 18:57 ` Stefano Stabellini
2021-03-25 7:53 ` [PATCH 1/6] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries Jan Beulich
2021-03-25 9:05 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7407cac8-c55d-0372-123b-39c9949e6ca5@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).