From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul.durrant@citrix.com>
Subject: Re: [PATCH 4/4] x86/vMSI-X: use generic intercept handler in place of MMIO one
Date: Tue, 21 Jun 2016 18:33:09 +0100 [thread overview]
Message-ID: <75789d4a-3ccf-e6b7-4ad8-de31b7aed337@citrix.com> (raw)
In-Reply-To: <575831B702000078000F30AE@prv-mh.provo.novell.com>
On 08/06/16 13:54, Jan Beulich wrote:
> This allows us to see the full ioreq without having to peek into state
> which is supposedly private to the emulation framework.
>
> Suggested-by: Paul Durrant <Paul.Durrant@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, with two minor
style corrections.
> @@ -333,23 +332,29 @@ out:
> return r;
> }
>
> -static int msixtbl_range(struct vcpu *v, unsigned long addr)
> +static int _msixtbl_write(const struct hvm_io_handler *handler,
> + uint64_t address, uint32_t len, uint64_t val)
Indentation.
> @@ -396,10 +401,10 @@ static int msixtbl_range(struct vcpu *v,
> return 0;
> }
>
> -static const struct hvm_mmio_ops msixtbl_mmio_ops = {
> - .check = msixtbl_range,
> +static const struct hvm_io_ops msixtbl_mmio_ops = {
> + .accept = msixtbl_range,
> .read = msixtbl_read,
> - .write = msixtbl_write
> + .write = _msixtbl_write
Trailing comma.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-21 17:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 12:48 [PATCH 0/4] x86/vMSI-X: misc improvements Jan Beulich
2016-06-08 12:52 ` [PATCH 1/4] x86/vMSI-X: defer intercept handler registration Jan Beulich
2016-06-17 16:13 ` Konrad Rzeszutek Wilk
2016-06-17 16:38 ` Jan Beulich
2016-06-21 17:11 ` Andrew Cooper
2016-06-08 12:53 ` [PATCH 2/4] x86/vMSI-X: drop list lock Jan Beulich
2016-06-21 17:26 ` Andrew Cooper
2016-06-08 12:54 ` [PATCH 3/4] x86/vMSI-X: drop pci_msix_get_table_len() Jan Beulich
2016-06-21 17:27 ` Andrew Cooper
2016-06-08 12:54 ` [PATCH 4/4] x86/vMSI-X: use generic intercept handler in place of MMIO one Jan Beulich
2016-06-13 8:36 ` Paul Durrant
2016-06-21 17:33 ` Andrew Cooper [this message]
2016-06-17 8:20 ` Ping: [PATCH 0/4] x86/vMSI-X: misc improvements Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75789d4a-3ccf-e6b7-4ad8-de31b7aed337@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).