From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2 03/12] x86/IRQ: avoid UB (or worse) in trace_irq_mask() Date: Mon, 13 May 2019 11:42:41 +0100 Message-ID: <765d6542-734a-5255-73a4-74ccce7f4ee8@citrix.com> References: <5CC6DD090200007800229E80@prv1-mh.provo.novell.com> <5CD2D2C8020000780022CCF2@prv1-mh.provo.novell.com> <5CD2D489020000780022CD34@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQ8Px-0005N4-Ga for xen-devel@lists.xenproject.org; Mon, 13 May 2019 10:42:49 +0000 In-Reply-To: <5CD2D489020000780022CD34@prv1-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich , xen-devel Cc: George Dunlap , Andrew Cooper , Wei Liu , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org T24gNS84LzE5IDI6MDcgUE0sIEphbiBCZXVsaWNoIHdyb3RlOgo+IER5bmFtaWNhbGx5IGFsbG9j YXRlZCBDUFUgbWFzayBvYmplY3RzIG1heSBiZSBzbWFsbGVyIHRoYW4gY3B1bWFza190LCBzbwo+ IGNvcHlpbmcgaGFzIHRvIGJlIHJlc3RyaWN0ZWQgdG8gdGhlIGFjdHVhbCBhbGxvY2F0aW9uIHNp emUuIFRoaXMgaXMKPiBwYXJ0aWN1bGFyeSBpbXBvcnRhbnQgc2luY2UgdGhlIGZ1bmN0aW9uIGRv ZXNuJ3QgYmFpbCBlYXJseSB3aGVuIHRyYWNpbmcKPiBpcyBub3QgYWN0aXZlLCBzbyBldmVuIHBy b2R1Y3Rpb24gYnVpbGRzIHdvdWxkIGJlIGFmZmVjdGVkIGJ5IHBvdGVudGlhbAo+IG1pc2JlaGF2 aW9yIGhlcmUuCj4gCj4gVGFrZSB0aGUgb3Bwb3J0dW5pdHkgYW5kIGFsc28KPiAtIHVzZSBpbml0 aWFsaXplcnMgaW5zdGVhZCBvZiBhc3NpZ25tZW50ICsgbWVtc2V0KCksCj4gLSBjb25zdGlmeSB0 aGUgY3B1bWFza190IGlucHV0IHBvaW50ZXIsCj4gLSB1MzIgLT4gdWludDMyX3QuCj4gCj4gU2ln bmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+IC0tLQo+IHYyOiBO ZXcuCj4gLS0tCj4gVEJEOiBJIHdvbmRlciB3aGV0aGVyIHRoZSBmdW5jdGlvbiBzaG91bGRuJ3Qg Z2FpbiBhbiBlYXJseSB0Yl9pbml0X2RvbmUKPiAgICAgIGNoZWNrLCBsaWtlIG1hbnkgb3RoZXIg dHJhY2VfKigpIGhhdmUuCgpZZWFoLCBhdm9pZGluZyB0aGVzZSBtZW1jb3BpZXMgd2hlbiB0cmFj aW5nIGlzIG5vdCBlbmFibGVkIHNlZW1zIGxpa2UgYQpnb29kIHRoaW5nLgoKRWl0aGVyIHdheToK CkFja2VkLWJ5OiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+Cgo+IAo+ IEdlb3JnZSwgZGVzcGl0ZSB5b3VyIGdlbmVyYWwgcmVxdWVzdCB0byBiZSBjb3BpZWQgb24gZW50 aXJlIHNlcmllcwo+IHJhdGhlciB0aGFuIGluZGl2aWR1YWwgcGF0Y2hlcywgSSB0aG91Z2h0IGl0 IHdvdWxkIGJlIGJldHRlciB0byBjb3B5Cj4geW91IG9uIGp1c3QgdGhpcyBvbmUgKGZvciBpdHMg dHJhY2luZyBhc3BlY3QpLCBhcyB0aGUgcGF0Y2ggaGVyZSBpcwo+IGluZGVwZW5kZW50IG9mIHRo ZSByZXN0IG9mIHRoZSBzZXJpZXMsIGJ1dCBhdCBsZWFzdCBvbmUgbGF0ZXIgcGF0Y2gKPiBkZXBl bmRzIG9uIHRoZSBwYXJhbWV0ZXIgY29uc3RpZmljYXRpb24gZG9uZSBoZXJlLgoKWWVzLCBJIHRo aW5rIGluIHRoaXMgY2FzZSB0aGlzIHdhcyB0aGUgZWFzaWVzdCB0aGluZyBmb3IgbWUuICBUaGFu a3MuIDotKQoKIC1HZW9yZ2UKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4t ZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8243AC04AA7 for ; Mon, 13 May 2019 10:43:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D2FF208C2 for ; Mon, 13 May 2019 10:43:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D2FF208C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQ8Py-0005NI-FC; Mon, 13 May 2019 10:42:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQ8Px-0005N4-Ga for xen-devel@lists.xenproject.org; Mon, 13 May 2019 10:42:49 +0000 X-Inumbo-ID: d731aed6-756b-11e9-a003-0b86b8dad863 Received: from SMTP03.CITRIX.COM (unknown [162.221.156.55]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d731aed6-756b-11e9-a003-0b86b8dad863; Mon, 13 May 2019 10:42:44 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.60,465,1549929600"; d="scan'208";a="85379947" To: Jan Beulich , xen-devel References: <5CC6DD090200007800229E80@prv1-mh.provo.novell.com> <5CD2D2C8020000780022CCF2@prv1-mh.provo.novell.com> <5CD2D489020000780022CD34@prv1-mh.provo.novell.com> From: George Dunlap Openpgp: preference=signencrypt Autocrypt: addr=george.dunlap@citrix.com; prefer-encrypt=mutual; keydata= mQINBFPqG+MBEACwPYTQpHepyshcufo0dVmqxDo917iWPslB8lauFxVf4WZtGvQSsKStHJSj 92Qkxp4CH2DwudI8qpVbnWCXsZxodDWac9c3PordLwz5/XL41LevEoM3NWRm5TNgJ3ckPA+J K5OfSK04QtmwSHFP3G/SXDJpGs+oDJgASta2AOl9vPV+t3xG6xyfa2NMGn9wmEvvVMD44Z7R W3RhZPn/NEZ5gaJhIUMgTChGwwWDOX0YPY19vcy5fT4bTIxvoZsLOkLSGoZb/jHIzkAAznug Q7PPeZJ1kXpbW9EHHaUHiCD9C87dMyty0N3TmWfp0VvBCaw32yFtM9jUgB7UVneoZUMUKeHA fgIXhJ7I7JFmw3J0PjGLxCLHf2Q5JOD8jeEXpdxugqF7B/fWYYmyIgwKutiGZeoPhl9c/7RE Bf6f9Qv4AtQoJwtLw6+5pDXsTD5q/GwhPjt7ohF7aQZTMMHhZuS52/izKhDzIufl6uiqUBge 0lqG+/ViLKwCkxHDREuSUTtfjRc9/AoAt2V2HOfgKORSCjFC1eI0+8UMxlfdq2z1AAchinU0 eSkRpX2An3CPEjgGFmu2Je4a/R/Kd6nGU8AFaE8ta0oq5BSFDRYdcKchw4TSxetkG6iUtqOO ZFS7VAdF00eqFJNQpi6IUQryhnrOByw+zSobqlOPUO7XC5fjnwARAQABtCRHZW9yZ2UgVy4g RHVubGFwIDxkdW5sYXBnQHVtaWNoLmVkdT6JAlcEEwEKAEECGwMFCwkIBwMFFQoJCAsFFgID AQACHgECF4ACGQEWIQTXqBy2bTNXPzpOYFimNjwxBZC0bQUCXEowWQUJDCJ7dgAKCRCmNjwx BZC0beKvEACJ75YlJXd7TnNHgFyiCJkm/qPeoQ3sFGSDZuZh7SKcdt9+3V2bFEb0Mii1hQaz 3hRqZb8sYPHJrGP0ljK09k3wf8k3OuNxziLQBJyzvn7WNlE4wBEcy/Ejo9TVBdA4ph5D0YaZ nqdsPmxe/xlTFuSkgu4ep1v9dfVP1TQR0e+JIBa/Ss+cKC5intKm+8JxpOploAHuzaPu0L/X FapzsIXqgT9eIQeBEgO2hge6h9Jov3WeED/vh8kA7f8c6zQ/gs5E7VGALwsiLrhr0LZFcKcw kI3oCCrB/C/wyPZv789Ra8EXbeRSJmTjcnBwHRPjnjwQmetRDD1t+VyrkC6uujT5jmgOBzaj KCqZ8PcMAssOzdzQtKmjUQ2b3ICPs2X13xZ5M5/OVs1W3TG5gkvMh4YoHi4ilFnOk+v3/j7q 65FG6N0JLb94Ndi80HkIOQQ1XVGTyu6bUPaBg3rWK91Csp1682kD/dNVF3FKHrRLmSVtmEQR 5rK0+VGc/FmR6vd4haKGWIRuPxzg+pBR77avIZpU7C7+UXGuZ5CbHwIdY8LojJg2TuUdqaVj yxmEZLOA8rVHipCGrslRNthVbJrGN/pqtKjCClFZHIAYJQ9EGLHXLG9Pj76opfjHij3MpR3o pCGAh6KsCrfrsvjnpDwqSbngGyEVH030irSk4SwIqZ7FwLkBDQRUWmc6AQgAzpc8Ng5Opbrh iZrn69Xr3js28p+b4a+0BOvC48NfrNovZw4eFeKIzmI/t6EkJkSqBIxobWRpBkwGweENsqnd 0qigmsDw4N7J9Xx0h9ARDqiWxX4jr7u9xauI+CRJ1rBNO3VV30QdACwQ4LqhR/WA+IjdhyMH wj3EJGE61NdP/h0zfaLYAbvEg47/TPThFsm4m8Rd6bX7RkrrOgBbL/AOnYOMEivyfZZKX1vv iEemAvLfdk2lZt7Vm6X/fbKbV8tPUuZELzNedJvTTBS3/l1FVz9OUcLDeWhGEdlxqXH0sYWh E9+PXTAfz5JxKH+LMetwEM8DbuOoDIpmIGZKrZ+2fQARAQABiQNbBBgBCgAmAhsCFiEE16gc tm0zVz86TmBYpjY8MQWQtG0FAlxKMJ4FCQnQ/OQBKcBdIAQZAQoABgUCVFpnOgAKCRCyFcen x4Qb7cXrCAC0qQeEWmLa9oEAPa+5U6wvG1t/mi22gZN6uzQXH1faIOoDehr7PPESE6tuR/vI CTTnaSrd4UDPNeqOqVF07YexWD1LDcQG6PnRqC5DIX1RGE3BaSaMl2pFJP8y+chews11yP8G DBbxaIsTcHZI1iVIC9XLhoeegWi84vYc8F4ziADVfowbmbvcVw11gE8tmALCwTeBeZVteXjh 0OELHwrc1/4j4yvENjIXRO+QLIgk43kB57Upr4tP2MEcs0odgPM+Q+oETOJ00xzLgkTnLPim C1FIW2bOZdTj+Uq6ezRS2LKsNmW+PRRvNyA5ojEbA/faxmAjMZtLdSSSeFK8y4SoCRCmNjwx BZC0bevWEACRu+GyQgrdGmorUptniIeO1jQlpTiP5WpVnk9Oe8SiLoXUhXXNj6EtzyLGpYmf kEAbki+S6WAKnzZd3shL58AuMyDxtFNNjNeKJOcl6FL7JPBIIgIp3wR401Ep+/s5pl3Nw8Ii 157f0T7o8CPb54w6S1WsMkU78WzTxIs/1lLblSMcvyz1Jq64g4OqiWI85JfkzPLlloVf1rzy ebIBLrrmjhCE2tL1RONpE/KRVb+Q+PIs5+YcZ+Q1e0vXWA7NhTWFbWx3+N6WW6gaGpbFbopo FkYRpj+2TA5cX5zW148/xU5/ATEb5vdUkFLUFVy5YNUSyeBHuaf6fGmBrDc47rQjAOt1rmyD 56MUBHpLUbvA6NkPezb7T6bQpupyzGRkMUmSwHiLyQNJQhVe+9NiJJvtEE3jol0JVJoQ9WVn FAzPNCgHQyvbsIF3gYkCYKI0w8EhEoH5FHYLoKS6Jg880IY5rXzoAEfPvLXegy6mhYl+mNVN QUBD4h9XtOvcdzR559lZuC0Ksy7Xqw3BMolmKsRO3gWKhXSna3zKl4UuheyZtubVWoNWP/bn vbyiYnLwuiKDfNAinEWERC8nPKlv3PkZw5d3t46F1Dx0TMf16NmP+azsRpnMZyzpY8BL2eur feSGAOB9qjZNyzbo5nEKHldKWCKE7Ye0EPEjECS1gjKDwbkBDQRUWrq9AQgA7aJ0i1pQSmUR 6ZXZD2YEDxia2ByR0uZoTS7N0NYv1OjU8v6p017u0Fco5+Qoju/fZ97ScHhp5xGVAk5kxZBF DT4ovJd0nIeSr3bbWwfNzGx1waztfdzXt6n3MBKr7AhioB1m+vuk31redUdnhbtvN7O40MC+ fgSk5/+jRGxY3IOVPooQKzUO7M51GoOg4wl9ia3H2EzOoGhN2vpTbT8qCcL92ZZZwkBRldoA Wn7c1hEKSTuT3f1VpSmhjnX0J4uvKZ1V2R7rooKJYFBcySC0wa8aTmAtAvLgfcpe+legOtgq DKzLuN45xzEjyjCiI521t8zxNMPJY9FiCPNv0sCkDwARAQABiQI8BBgBCgAmAhsMFiEE16gc tm0zVz86TmBYpjY8MQWQtG0FAlxKNJYFCQnQrVkACgkQpjY8MQWQtG2Xxg//RrRP+PFYuNXt 9C5hec/JoY24TkGPPd2tMC9usWZVImIk7VlHlAeqHeE0lWU0LRGIvOBITbS9izw6fOVQBvCA Fni56S12fKLusWgWhgu03toT9ZGxZ9W22yfw5uThSHQ4y09wRWAIYvhJsKnPGGC2KDxFvtz5 4pYYNe8Icy4bwsxcgbaSFaRh+mYtts6wE9VzyJvyfTqbe8VrvE+3InG5rrlNn51AO6M4Wv20 iFEgYanJXfhicl0WCQrHyTLfdB5p1w+072CL8uryHQVfD0FcDe+J/wl3bmYze+aD1SlPzFoI MaSIXKejC6oh6DAT4rvU8kMAbX90T834Mvbc3jplaWorNJEwjAH/r+v877AI9Vsmptis+rni JwUissjRbcdlkKBisoUZRPmxQeUifxUpqgulZcYwbEC/a49+WvbaYUriaDLHzg9xisijHwD2 yWV8igBeg+cmwnk0mPz8tIVvwi4lICAgXob7HZiaqKnwaDXs4LiS4vdG5s/ElnE3rIc87yru 24n3ypeDZ6f5LkdqL1UNp5/0Aqbr3EiN7/ina4YVyscy9754l944kyHnnMRLVykg0v+kakj0 h0RJ5LbfLAMM8M52KIA3y14g0Fb7kHLcOUMVcgfQ3PrN6chtC+5l6ouDIlSLR3toxH8Aam7E rIFfe2Dk+lD9A9BVd2rfoHA= Message-ID: <765d6542-734a-5255-73a4-74ccce7f4ee8@citrix.com> Date: Mon, 13 May 2019 11:42:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <5CD2D489020000780022CD34@prv1-mh.provo.novell.com> Content-Language: en-US Subject: Re: [Xen-devel] [PATCH v2 03/12] x86/IRQ: avoid UB (or worse) in trace_irq_mask() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap , Andrew Cooper , Wei Liu , Roger Pau Monne Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Message-ID: <20190513104241.6z8aOhmF4elkHphCazmsuRYkFbMK4rn5OS1TI5KZLiU@z> T24gNS84LzE5IDI6MDcgUE0sIEphbiBCZXVsaWNoIHdyb3RlOgo+IER5bmFtaWNhbGx5IGFsbG9j YXRlZCBDUFUgbWFzayBvYmplY3RzIG1heSBiZSBzbWFsbGVyIHRoYW4gY3B1bWFza190LCBzbwo+ IGNvcHlpbmcgaGFzIHRvIGJlIHJlc3RyaWN0ZWQgdG8gdGhlIGFjdHVhbCBhbGxvY2F0aW9uIHNp emUuIFRoaXMgaXMKPiBwYXJ0aWN1bGFyeSBpbXBvcnRhbnQgc2luY2UgdGhlIGZ1bmN0aW9uIGRv ZXNuJ3QgYmFpbCBlYXJseSB3aGVuIHRyYWNpbmcKPiBpcyBub3QgYWN0aXZlLCBzbyBldmVuIHBy b2R1Y3Rpb24gYnVpbGRzIHdvdWxkIGJlIGFmZmVjdGVkIGJ5IHBvdGVudGlhbAo+IG1pc2JlaGF2 aW9yIGhlcmUuCj4gCj4gVGFrZSB0aGUgb3Bwb3J0dW5pdHkgYW5kIGFsc28KPiAtIHVzZSBpbml0 aWFsaXplcnMgaW5zdGVhZCBvZiBhc3NpZ25tZW50ICsgbWVtc2V0KCksCj4gLSBjb25zdGlmeSB0 aGUgY3B1bWFza190IGlucHV0IHBvaW50ZXIsCj4gLSB1MzIgLT4gdWludDMyX3QuCj4gCj4gU2ln bmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+IC0tLQo+IHYyOiBO ZXcuCj4gLS0tCj4gVEJEOiBJIHdvbmRlciB3aGV0aGVyIHRoZSBmdW5jdGlvbiBzaG91bGRuJ3Qg Z2FpbiBhbiBlYXJseSB0Yl9pbml0X2RvbmUKPiAgICAgIGNoZWNrLCBsaWtlIG1hbnkgb3RoZXIg dHJhY2VfKigpIGhhdmUuCgpZZWFoLCBhdm9pZGluZyB0aGVzZSBtZW1jb3BpZXMgd2hlbiB0cmFj aW5nIGlzIG5vdCBlbmFibGVkIHNlZW1zIGxpa2UgYQpnb29kIHRoaW5nLgoKRWl0aGVyIHdheToK CkFja2VkLWJ5OiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+Cgo+IAo+ IEdlb3JnZSwgZGVzcGl0ZSB5b3VyIGdlbmVyYWwgcmVxdWVzdCB0byBiZSBjb3BpZWQgb24gZW50 aXJlIHNlcmllcwo+IHJhdGhlciB0aGFuIGluZGl2aWR1YWwgcGF0Y2hlcywgSSB0aG91Z2h0IGl0 IHdvdWxkIGJlIGJldHRlciB0byBjb3B5Cj4geW91IG9uIGp1c3QgdGhpcyBvbmUgKGZvciBpdHMg dHJhY2luZyBhc3BlY3QpLCBhcyB0aGUgcGF0Y2ggaGVyZSBpcwo+IGluZGVwZW5kZW50IG9mIHRo ZSByZXN0IG9mIHRoZSBzZXJpZXMsIGJ1dCBhdCBsZWFzdCBvbmUgbGF0ZXIgcGF0Y2gKPiBkZXBl bmRzIG9uIHRoZSBwYXJhbWV0ZXIgY29uc3RpZmljYXRpb24gZG9uZSBoZXJlLgoKWWVzLCBJIHRo aW5rIGluIHRoaXMgY2FzZSB0aGlzIHdhcyB0aGUgZWFzaWVzdCB0aGluZyBmb3IgbWUuICBUaGFu a3MuIDotKQoKIC1HZW9yZ2UKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4t ZGV2ZWw=