From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen-blkback: constify instance of "struct attribute_group"
Date: Thu, 7 Jul 2016 10:52:18 +0100 [thread overview]
Message-ID: <7732540a-aa37-9e33-e805-838dc4c43676__6589.3653351397$1467885228$gmane$org@citrix.com> (raw)
In-Reply-To: <20160707094535.wsgrxlnib5ajcsdc@mac>
On 07/07/16 10:45, Roger Pau Monne wrote:
> On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
>> The functions such get passed to have been taking pointers to const
>> since at least 2.6.16.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Although the wording in the commit message looks weird to me, but I'm not a
> native speaker anyway.
As a native speaker, I can't parse it either.
I think s/such/these/ is needed.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-07 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 7:38 [PATCH] xen-blkback: constify instance of "struct attribute_group" Jan Beulich
2016-07-07 9:45 ` Roger Pau Monne
[not found] ` <20160707094535.wsgrxlnib5ajcsdc@mac>
2016-07-07 9:52 ` Andrew Cooper [this message]
[not found] ` <7732540a-aa37-9e33-e805-838dc4c43676@citrix.com>
2016-07-07 15:37 ` Konrad Rzeszutek Wilk
[not found] ` <20160707153750.GB11480@localhost.localdomain>
2016-07-07 15:57 ` Jan Beulich
[not found] ` <577E97F602000078000FC546@prv-mh.provo.novell.com>
2016-07-08 13:55 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='7732540a-aa37-9e33-e805-838dc4c43676__6589.3653351397$1467885228$gmane$org@citrix.com' \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).