From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6016C433E0 for ; Wed, 17 Feb 2021 11:25:41 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 493D764E62 for ; Wed, 17 Feb 2021 11:25:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 493D764E62 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.86216.161678 (Exim 4.92) (envelope-from ) id 1lCKxY-0004Qx-Ke; Wed, 17 Feb 2021 11:25:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 86216.161678; Wed, 17 Feb 2021 11:25:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lCKxY-0004Qq-HV; Wed, 17 Feb 2021 11:25:32 +0000 Received: by outflank-mailman (input) for mailman id 86216; Wed, 17 Feb 2021 11:25:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lCKxW-0004Ql-VX for xen-devel@lists.xenproject.org; Wed, 17 Feb 2021 11:25:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lCKxU-0001cz-DY; Wed, 17 Feb 2021 11:25:28 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lCKxU-0008G6-5t; Wed, 17 Feb 2021 11:25:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=BjARDfv67VUgnEkyeC9djvBnhG9dcZLvDOnPv6Do+vA=; b=2PBiSKPTL9HefLyoDxwwlrbIah sNhgM6KBDxNcgkvH9wqLoHY1BfFGsWNm92/YGRjiDjme4QJraeKbh5eNQ97AR1H63r3Fe7yqY3+7d MFERpOwxr0Hg0sG1wZBt7AnZ1V0kfWXC0yO8KkuX+I4p222HsGPv3md8NdvwbHfTSJls=; Subject: Re: [for-4.15][PATCH v2 2/5] xen/iommu: Check if the IOMMU was initialized before tearing down To: paul@xen.org, xen-devel@lists.xenproject.org Cc: hongyxia@amazon.co.uk, iwj@xenproject.org, 'Julien Grall' , 'Jan Beulich' References: <20210209152816.15792-1-julien@xen.org> <20210209152816.15792-3-julien@xen.org> <04f401d6ff21$3b167720$b1436560$@xen.org> From: Julien Grall Message-ID: <78eb9b66-6676-d7d8-d427-2f345c2673f5@xen.org> Date: Wed, 17 Feb 2021 11:25:26 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <04f401d6ff21$3b167720$b1436560$@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Paul, On 09/02/2021 20:22, Paul Durrant wrote: >> -----Original Message----- >> From: Julien Grall >> Sent: 09 February 2021 15:28 >> To: xen-devel@lists.xenproject.org >> Cc: hongyxia@amazon.co.uk; iwj@xenproject.org; Julien Grall ; Jan Beulich >> ; Paul Durrant >> Subject: [for-4.15][PATCH v2 2/5] xen/iommu: Check if the IOMMU was initialized before tearing down >> >> From: Julien Grall >> >> is_iommu_enabled() will return true even if the IOMMU has not been >> initialized (e.g. the ops are not set). >> >> In the case of an early failure in arch_domain_init(), the function >> iommu_destroy_domain() will be called even if the IOMMU is not >> initialized. >> >> This will result to dereference the ops which will be NULL and an host >> crash. >> >> Fix the issue by checking that ops has been set before accessing it. >> >> Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate...") >> Signed-off-by: Julien Grall > > Reviewed-by: Paul Durrant Thanks! Ian gave his Release-Acked-by so I will commit this patch now. Cheers, -- Julien Grall