From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 758E3C433E7 for ; Mon, 19 Oct 2020 07:30:18 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E031B22243 for ; Mon, 19 Oct 2020 07:30:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="It3YIAh8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E031B22243 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.8609.23072 (Exim 4.92) (envelope-from ) id 1kUPc5-00061j-Jy; Mon, 19 Oct 2020 07:29:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 8609.23072; Mon, 19 Oct 2020 07:29:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUPc5-00061c-Gu; Mon, 19 Oct 2020 07:29:49 +0000 Received: by outflank-mailman (input) for mailman id 8609; Mon, 19 Oct 2020 07:29:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUPc4-00061X-Mj for xen-devel@lists.xenproject.org; Mon, 19 Oct 2020 07:29:48 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2c4f8ad6-12a5-453c-a8a3-3a5415855b8b; Mon, 19 Oct 2020 07:29:47 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ACF70AC8B; Mon, 19 Oct 2020 07:29:46 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUPc4-00061X-Mj for xen-devel@lists.xenproject.org; Mon, 19 Oct 2020 07:29:48 +0000 X-Inumbo-ID: 2c4f8ad6-12a5-453c-a8a3-3a5415855b8b Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2c4f8ad6-12a5-453c-a8a3-3a5415855b8b; Mon, 19 Oct 2020 07:29:47 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603092586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SyjgKY1Si4K6wfxaWj8TKW9wqTWRjKNXPgMcltgR6zs=; b=It3YIAh8Tbtoj4VYIigE17U+Z4WsKeAhVF8eWE5FXAR4A6ZqLuM7zWaNhsTQqTZ/HFIJ7T uPA9lwF1okOdmnMGwqeKjUsipEZcYNrQ8teL8XwT1IQC81o/o7tjzBJUvRmoYa8BWPW+jB jxlE2bwvLExroL33LnNQ+y6fVYjtRRM= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ACF70AC8B; Mon, 19 Oct 2020 07:29:46 +0000 (UTC) Subject: Re: [PATCH 2/5] iommu / domctl: introduce XEN_DOMCTL_iommu_ctl To: paul@xen.org Cc: 'Julien Grall' , xen-devel@lists.xenproject.org, 'Paul Durrant' , 'Daniel De Graaf' , 'Ian Jackson' , 'Wei Liu' , 'Andrew Cooper' , 'George Dunlap' , 'Stefano Stabellini' References: <20201005094905.2929-1-paul@xen.org> <20201005094905.2929-3-paul@xen.org> <97648df3-dcce-cd19-9074-6ca63d94b518@xen.org> <002a01d6a5e8$c36bb5a0$4a4320e0$@xen.org> From: Jan Beulich Message-ID: <7c4a0cda-5fff-c9ae-2fc1-4256aec5f694@suse.com> Date: Mon, 19 Oct 2020 09:29:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <002a01d6a5e8$c36bb5a0$4a4320e0$@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 19.10.2020 09:23, Paul Durrant wrote: >> From: Julien Grall >> Sent: 16 October 2020 16:47 >> >> On 05/10/2020 10:49, Paul Durrant wrote: >>> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h >>> index 791f0a2592..75e855625a 100644 >>> --- a/xen/include/public/domctl.h >>> +++ b/xen/include/public/domctl.h >>> @@ -1130,6 +1130,18 @@ struct xen_domctl_vuart_op { >>> */ >>> }; >>> >>> +/* >>> + * XEN_DOMCTL_iommu_ctl >>> + * >>> + * Control of VM IOMMU settings >>> + */ >>> + >>> +#define XEN_DOMCTL_IOMMU_INVALID 0 >> >> I can't find any user of XEN_DOMCTL_IOMMU_INVALID. What's the purpose >> for it? >> > > It's just a placeholder. I think it's generally safer that a zero opcode value is invalid. But does this then need a #define? Starting valid command from 1 ought to be sufficient? Jan