From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com> To: "Xu, Quan" <quan.xu@intel.com>, xen-devel@lists.xen.org Cc: Kevin Tian <kevin.tian@intel.com>, Stefano Stabellini <sstabellini@kernel.org>, Keir Fraser <keir@xen.org>, Liu Jinsong <jinsong.liu@alibaba-inc.com>, dario.faggioli@citrix.com, Julien Grall <julien.grall@arm.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Feng Wu <feng.wu@intel.com> Subject: Re: [PATCH v7 07/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending (top level ones) Date: Thu, 9 Jun 2016 13:58:54 -0500 [thread overview] Message-ID: <7d165d9a-dc0a-39bd-3e53-d8ad2a5cfb9b@amd.com> (raw) In-Reply-To: <1465376344-28290-8-git-send-email-quan.xu@intel.com> On 6/8/2016 3:59 AM, Xu, Quan wrote: > From: Quan Xu <quan.xu@intel.com> > > Signed-off-by: Quan Xu <quan.xu@intel.com> > > CC: Jan Beulich <jbeulich@suse.com> > CC: Liu Jinsong <jinsong.liu@alibaba-inc.com> > CC: Keir Fraser <keir@xen.org> > CC: Andrew Cooper <andrew.cooper3@citrix.com> > CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> > CC: Stefano Stabellini <sstabellini@kernel.org> > CC: Julien Grall <julien.grall@arm.com> > CC: Kevin Tian <kevin.tian@intel.com> > CC: Feng Wu <feng.wu@intel.com> > > v7: > 1. return SAVED_ALL at the bottom of device_power_down(), instead > of SAVED_NONE. > 2. drop the 'if ( error > 0 )', calling device_power_up(error) > without any if(). > 3. for vtd_suspend(): > - drop pointless initializer. > - return 0 at the bottom to make obvious that no error path > comes there. Shouldn't the changes log for v7 probably go ... > --- ... HERE instead so that we don't get this in the commit log. For AMD part, Acked-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> Thanks, Suravee _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-09 18:58 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-08 8:58 [PATCH v7 00/11] Check VT-d Device-TLB flush error Xu, Quan 2016-06-08 8:58 ` [PATCH v7 01/11] IOMMU: handle IOMMU mapping and unmapping failures Xu, Quan 2016-06-08 8:58 ` [PATCH v7 02/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping Xu, Quan 2016-06-08 14:40 ` Jan Beulich [not found] ` <57584D8602000078000F32D0@prv-mh.provo.novell.com> [not found] ` <421857ad-4f6b-e99c-1e81-034b19effdfb@amd.com> 2016-06-10 6:56 ` Jan Beulich 2016-06-12 6:41 ` Tian, Kevin 2016-06-08 8:58 ` [PATCH v7 03/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU unmapping (top level ones) Xu, Quan 2016-06-08 14:42 ` Jan Beulich 2016-06-08 14:54 ` Jan Beulich 2016-06-09 19:30 ` Suravee Suthikulanit 2016-06-09 10:28 ` Julien Grall 2016-06-08 8:58 ` [PATCH v7 04/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU mapping " Xu, Quan 2016-06-08 14:43 ` Jan Beulich 2016-06-09 18:45 ` Suravee Suthikulanit 2016-06-09 10:30 ` Julien Grall 2016-06-08 8:58 ` [PATCH v7 05/11] IOMMU/MMU: propagate IOMMU Device-TLB flush error up to iommu_iotlb_flush{, _all} " Xu, Quan 2016-06-09 11:12 ` Julien Grall 2016-06-09 11:45 ` Jan Beulich 2016-06-09 12:03 ` Julien Grall 2016-06-09 12:08 ` Julien Grall 2016-06-09 12:15 ` Jan Beulich 2016-06-09 12:24 ` Julien Grall 2016-06-09 12:32 ` Jan Beulich 2016-06-09 12:39 ` Julien Grall 2016-06-12 6:55 ` Tian, Kevin 2016-06-12 7:02 ` Xu, Quan 2016-06-12 15:35 ` Julien Grall 2016-06-09 12:14 ` Jan Beulich 2016-06-12 6:46 ` Tian, Kevin 2016-06-08 8:58 ` [PATCH v7 06/11] propagate IOMMU Device-TLB flush error up to EPT update " Xu, Quan 2016-06-08 8:59 ` [PATCH v7 07/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending " Xu, Quan 2016-06-08 14:51 ` Jan Beulich 2016-06-12 7:42 ` Xu, Quan 2016-06-13 9:25 ` Jan Beulich 2016-06-09 18:58 ` Suravee Suthikulanit [this message] 2016-06-12 6:58 ` Tian, Kevin 2016-06-08 8:59 ` [PATCH v7 08/11] IOMMU: propagate IOMMU Device-TLB flush error (leaf ones) Xu, Quan 2016-06-08 8:59 ` [PATCH v7 09/11] vt-d: fix the IOMMU flush issue Xu, Quan 2016-06-12 7:32 ` Tian, Kevin 2016-06-12 9:27 ` Xu, Quan 2016-06-13 8:50 ` Xu, Quan 2016-06-08 8:59 ` [PATCH v7 10/11] vt-d: propagate the IOMMU Device-TLB flush error up to ME phantom functions Xu, Quan 2016-06-12 7:34 ` Tian, Kevin 2016-06-08 8:59 ` [PATCH v7 11/11] vt-d: add __must_check annotation to IOMMU flush pointers and handlers Xu, Quan 2016-06-12 7:35 ` Tian, Kevin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7d165d9a-dc0a-39bd-3e53-d8ad2a5cfb9b@amd.com \ --to=suravee.suthikulpanit@amd.com \ --cc=andrew.cooper3@citrix.com \ --cc=dario.faggioli@citrix.com \ --cc=feng.wu@intel.com \ --cc=jbeulich@suse.com \ --cc=jinsong.liu@alibaba-inc.com \ --cc=julien.grall@arm.com \ --cc=keir@xen.org \ --cc=kevin.tian@intel.com \ --cc=quan.xu@intel.com \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xen.org \ --subject='Re: [PATCH v7 07/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending (top level ones)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).