From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E24EC433DF for ; Tue, 13 Oct 2020 14:04:24 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3E752479D for ; Tue, 13 Oct 2020 14:04:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="hVkyavPP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3E752479D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.6227.16545 (Exim 4.92) (envelope-from ) id 1kSKuI-0007O8-4Q; Tue, 13 Oct 2020 14:04:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 6227.16545; Tue, 13 Oct 2020 14:04:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kSKuI-0007O1-1a; Tue, 13 Oct 2020 14:04:02 +0000 Received: by outflank-mailman (input) for mailman id 6227; Tue, 13 Oct 2020 14:04:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kSKuH-0007Nw-A3 for xen-devel@lists.xenproject.org; Tue, 13 Oct 2020 14:04:01 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 65cb9423-5efa-4b64-bc24-df7fb6ed62d0; Tue, 13 Oct 2020 14:04:00 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BB98DAC2F; Tue, 13 Oct 2020 14:03:59 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kSKuH-0007Nw-A3 for xen-devel@lists.xenproject.org; Tue, 13 Oct 2020 14:04:01 +0000 X-Inumbo-ID: 65cb9423-5efa-4b64-bc24-df7fb6ed62d0 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 65cb9423-5efa-4b64-bc24-df7fb6ed62d0; Tue, 13 Oct 2020 14:04:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1602597839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xGGF/KIIYFeZDMZNq0z7ds2K46CBuGaxaLzBLu3vtJQ=; b=hVkyavPPQQkIjnvenVxmRsDRObNJciGiTq0PqPoLA330zMJFlpYwMs4lIgZIHecAYKREXi l9mudO1CYfQk2Sa/YcYe9R4NTTJO7P2SBHcD09IgrPVEmdtVRZzI5AEhp62n5fvQT475Yb IaZ8HUdcpC4bJLu7qK5+EFDo5CEWL30= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BB98DAC2F; Tue, 13 Oct 2020 14:03:59 +0000 (UTC) Subject: Re: [PATCH] x86/msr: handle IA32_THERM_STATUS To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Wei Liu References: <20201007102032.98565-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: <7d2b0176-f976-5f39-903b-89c5d001fe3d@suse.com> Date: Tue, 13 Oct 2020 16:03:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201007102032.98565-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 07.10.2020 12:20, Roger Pau Monne wrote: > Windows 8 will attempt to read MSR_IA32_THERM_STATUS and panic if a > #GP fault is injected as a result: > > vmx.c:3035:d8v0 RDMSR 0x0000019c unimplemented > d8v0 VIRIDIAN CRASH: 3b c0000096 fffff8061de31651 fffff4088a613720 0 > > So handle the MSR and return 0 instead. > > Note that this is done on the generic MSR handler, and PV guest will > also get 0 back when trying to read the MSR. There doesn't seem to be > much value in handling the MSR for HVM guests only. > > Fixes: 84e848fd7a1 ('x86/hvm: disallow access to unknown MSRs') > Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich