From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00648C433B4 for ; Thu, 15 Apr 2021 14:47:51 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0E3561029 for ; Thu, 15 Apr 2021 14:47:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0E3561029 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.111324.212916 (Exim 4.92) (envelope-from ) id 1lX3HR-0002uj-4x; Thu, 15 Apr 2021 14:47:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 111324.212916; Thu, 15 Apr 2021 14:47:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lX3HQ-0002uc-Vj; Thu, 15 Apr 2021 14:47:40 +0000 Received: by outflank-mailman (input) for mailman id 111324; Thu, 15 Apr 2021 14:47:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lX3HP-0002uX-N0 for xen-devel@lists.xenproject.org; Thu, 15 Apr 2021 14:47:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lX3HO-0001sj-SF; Thu, 15 Apr 2021 14:47:38 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lX3HO-0008E7-LR; Thu, 15 Apr 2021 14:47:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=5TlB75kf/qDr9Khh2QJL8G/y3DImPl9rSzt9GOnvfhs=; b=lXjzpVoLzZBOn5wqDDu+6vMEzs vXy1BE57DwlV9NY/19qPtbX1AmdwtXVDhPBySiqlP4m9MWXUiOof2DDxrrRIo6s2TRJuT4/vszOyx TNRaRMxxRcYRd+EAhwhsmuPBTMarg7Vt5t1Pdqhybw+CrfMicDTTTzCOdnT/SUdOBWe8=; Subject: Re: [PATCH v3 13/15] unzstd: replace INIT{,DATA} and STATIC To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <2db91183-a7de-0c43-2fef-feb3523ed19b@suse.com> <19f12930-df0e-5a00-9e5e-53edffcf51d7@suse.com> <467ed62e-e5c3-0a08-b9a7-5b4e913b3c90@xen.org> <950e7ec1-3d4a-594d-ce8f-62d9d5930265@suse.com> <75195be2-ca13-28c2-b871-992c0168e1e7@xen.org> <71658edb-2cb5-09c2-708f-06c6fca9253d@suse.com> From: Julien Grall Message-ID: <7d33d499-19a6-dbea-7e37-59eeb5b47263@xen.org> Date: Thu, 15 Apr 2021 15:47:36 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <71658edb-2cb5-09c2-708f-06c6fca9253d@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 15/04/2021 15:34, Jan Beulich wrote: > On 15.04.2021 16:30, Julien Grall wrote: >> On 15/04/2021 15:25, Jan Beulich wrote: >>> On 15.04.2021 16:22, Julien Grall wrote: >>>> On 15/04/2021 15:21, Jan Beulich wrote: >>>>> On 15.04.2021 13:59, Julien Grall wrote: >>>>>> On 26/01/2021 09:52, Jan Beulich wrote: >>>>>>> With xen/common/decompress.h now agreeing in both build modes about >>>>>>> what STATIC expands to, there's no need for this abstraction anymore. >>>>>> >>>>>> Shouldn't you also mention "INIT" and "INITDATA" here? >>>>> >>>>> Two parts: INITDATA was mistakenly mentioned in the title. I've >>>>> dropped that. >>>> >>>> Ok. >>>> >>>> And what I'm saying about STATIC does not apply to >>>>> INIT - for it, we replace the extra level of abstraction by >>>>> directly using __init, just like was done in the earlier patches. >>>> >>>> This should be mention in the commit message. >>> >>> It already is by what is being said after the comma. May I direct >>> you back to the commit messages of earlier patches in this series >>> (when talk was of just INIT)? >> From the way the commit message is written it sounds like more you are >> referring to STATIC only. This is a clearer on the other commit messages >> because there is no other way to interpret "this". > > If the commit message is taken together with the title, I think > all is clear. I have to admit, I view the commit title as a one line summary. So I often read them separately. > >> So I would suggest to clarify it. > > And I would like to avoid doing so. As a compromise, I'll change > "this abstraction" to "these abstractions". Sounds good to me. Cheers, -- Julien Grall