From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH v6 1/5] xen: fix debugtrace clearing
Date: Mon, 9 Sep 2019 10:19:58 +0200 [thread overview]
Message-ID: <7ebc3132-2c7e-f804-1b59-75bac1544d12@suse.com> (raw)
In-Reply-To: <eca805d7-34e3-ad25-d444-3c2746a4cf12@suse.com>
On 09.09.19 09:53, Jan Beulich wrote:
> On 09.09.2019 09:35, Juergen Gross wrote:
>> --- a/xen/drivers/char/console.c
>> +++ b/xen/drivers/char/console.c
>> @@ -1173,6 +1173,7 @@ static char *debugtrace_buf; /* Debug-trace buffer */
>> static unsigned int debugtrace_prd; /* Producer index */
>> static unsigned int debugtrace_kilobytes = 128, debugtrace_bytes;
>> static unsigned int debugtrace_used;
>> +static bool debugtrace_buf_empty;
>
> Wouldn't it be more logical for this to start out as "true"?
In the end it doesn't matter, as last_buf[] will be empty initially.
But I can change it to let its semantics match the reality.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-09 8:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 7:35 [Xen-devel] [PATCH v6 0/5] xen: debugtrace cleanup and per-cpu buffer support Juergen Gross
2019-09-09 7:35 ` [Xen-devel] [PATCH v6 1/5] xen: fix debugtrace clearing Juergen Gross
2019-09-09 7:53 ` Jan Beulich
2019-09-09 8:11 ` Jan Beulich
2019-09-09 8:19 ` Juergen Gross [this message]
2019-09-09 7:35 ` [Xen-devel] [PATCH v6 2/5] xen: move debugtrace coding to common/debugtrace.c Juergen Gross
2019-09-09 7:35 ` [Xen-devel] [PATCH v6 3/5] xen: refactor debugtrace data Juergen Gross
2019-09-09 7:35 ` [Xen-devel] [PATCH v6 4/5] xen: add per-cpu buffer option to debugtrace Juergen Gross
2019-09-09 7:59 ` Jan Beulich
2019-09-09 8:04 ` Jan Beulich
2019-09-09 8:15 ` Juergen Gross
2019-09-09 7:35 ` [Xen-devel] [PATCH v6 5/5] xen: add debugtrace entry when entry count is wrapping Juergen Gross
2019-09-09 8:19 ` Jan Beulich
2019-09-09 8:22 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ebc3132-2c7e-f804-1b59-75bac1544d12@suse.com \
--to=jgross@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).