xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tools/xenstored: Remove unused prototype
@ 2021-04-20 13:49 Julien Grall
  2021-04-20 15:27 ` Bertrand Marquis
  2021-04-21  7:39 ` Juergen Gross
  0 siblings, 2 replies; 4+ messages in thread
From: Julien Grall @ 2021-04-20 13:49 UTC (permalink / raw)
  To: xen-devel; +Cc: julien, Julien Grall, Ian Jackson, Wei Liu, Juergen Gross

From: Julien Grall <jgrall@amazon.com>

A prototype for dump_conn() has been present for quite a long time
but there are no implementation. Even, AFAICT in the patch that
introduced it. So drop it.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 tools/xenstore/xenstored_core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index d54a6042a9f7..591b28e4552f 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -2085,7 +2085,6 @@ static struct option options[] = {
 #endif
 	{ NULL, 0, NULL, 0 } };
 
-extern void dump_conn(struct connection *conn); 
 int dom0_domid = 0;
 int dom0_event = 0;
 int priv_domid = 0;
-- 
2.17.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tools/xenstored: Remove unused prototype
  2021-04-20 13:49 [PATCH] tools/xenstored: Remove unused prototype Julien Grall
@ 2021-04-20 15:27 ` Bertrand Marquis
  2021-04-21  7:39 ` Juergen Gross
  1 sibling, 0 replies; 4+ messages in thread
From: Bertrand Marquis @ 2021-04-20 15:27 UTC (permalink / raw)
  To: Julien Grall; +Cc: Xen-devel, Julien Grall, Ian Jackson, Wei Liu, Juergen Gross

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

Hi Julien,

On 20 Apr 2021, at 14:49, Julien Grall <julien@xen.org<mailto:julien@xen.org>> wrote:

From: Julien Grall <jgrall@amazon.com<mailto:jgrall@amazon.com>>

A prototype for dump_conn() has been present for quite a long time
but there are no implementation. Even, AFAICT in the patch that
introduced it. So drop it.

Signed-off-by: Julien Grall <jgrall@amazon.com<mailto:jgrall@amazon.com>>

Agree, no implementation of this exists so:
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com<mailto:bertrand.marquis@arm.com>>

Cheers
Bertrand

---
tools/xenstore/xenstored_core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index d54a6042a9f7..591b28e4552f 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -2085,7 +2085,6 @@ static struct option options[] = {
#endif
{ NULL, 0, NULL, 0 } };

-extern void dump_conn(struct connection *conn);
int dom0_domid = 0;
int dom0_event = 0;
int priv_domid = 0;
--
2.17.1




[-- Attachment #2: Type: text/html, Size: 2225 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tools/xenstored: Remove unused prototype
  2021-04-20 13:49 [PATCH] tools/xenstored: Remove unused prototype Julien Grall
  2021-04-20 15:27 ` Bertrand Marquis
@ 2021-04-21  7:39 ` Juergen Gross
  2021-04-25 12:50   ` Julien Grall
  1 sibling, 1 reply; 4+ messages in thread
From: Juergen Gross @ 2021-04-21  7:39 UTC (permalink / raw)
  To: Julien Grall, xen-devel; +Cc: Julien Grall, Ian Jackson, Wei Liu


[-- Attachment #1.1.1: Type: text/plain, Size: 369 bytes --]

On 20.04.21 15:49, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> A prototype for dump_conn() has been present for quite a long time
> but there are no implementation. Even, AFAICT in the patch that
> introduced it. So drop it.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tools/xenstored: Remove unused prototype
  2021-04-21  7:39 ` Juergen Gross
@ 2021-04-25 12:50   ` Julien Grall
  0 siblings, 0 replies; 4+ messages in thread
From: Julien Grall @ 2021-04-25 12:50 UTC (permalink / raw)
  To: Juergen Gross, xen-devel; +Cc: Julien Grall, Ian Jackson, Wei Liu

Hi Juergen,

On 21/04/2021 08:39, Juergen Gross wrote:
> On 20.04.21 15:49, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> A prototype for dump_conn() has been present for quite a long time
>> but there are no implementation. Even, AFAICT in the patch that
>> introduced it. So drop it.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>

Thanks! I have committed it.

Cheers,

-- 
Julien Grall


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-25 12:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 13:49 [PATCH] tools/xenstored: Remove unused prototype Julien Grall
2021-04-20 15:27 ` Bertrand Marquis
2021-04-21  7:39 ` Juergen Gross
2021-04-25 12:50   ` Julien Grall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).