From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC9AC07E96 for ; Thu, 8 Jul 2021 06:41:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75D6F61CD1 for ; Thu, 8 Jul 2021 06:41:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75D6F61CD1 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.152884.282433 (Exim 4.92) (envelope-from ) id 1m1Nia-0008MA-4c; Thu, 08 Jul 2021 06:41:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 152884.282433; Thu, 08 Jul 2021 06:41:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m1Nia-0008M3-1V; Thu, 08 Jul 2021 06:41:04 +0000 Received: by outflank-mailman (input) for mailman id 152884; Thu, 08 Jul 2021 06:41:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m1NiY-0008Lh-Uf for xen-devel@lists.xenproject.org; Thu, 08 Jul 2021 06:41:02 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 75713a96-dfb7-11eb-855b-12813bfff9fa; Thu, 08 Jul 2021 06:41:01 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 719A220150; Thu, 8 Jul 2021 06:41:00 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 2E43D13743; Thu, 8 Jul 2021 06:41:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id Iq5rCfyd5mD3DAAAGKfGzw (envelope-from ); Thu, 08 Jul 2021 06:41:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75713a96-dfb7-11eb-855b-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1625726460; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UX3Jn7QKJIgWoq9YIAaClEJrTpNP4qdIchyEuqqTUVw=; b=IxZo4LROO0bvAYuZYqErxE8mW17nhu8a9S8rQVAeR/JxlVuwb4jq74GxQs4yFIULQiy4ba Q4/rlwk4saWNsDiYanB7p1TC3LvrWG0B8xJI31qJ2ZhDMobUvwbuvavbFrUYdxSeQUntRx a+0rw8CSwO27rht8sJH/Wsn8cy7dOkQ= Subject: Re: [PATCH 4/8] xen/blkfront: don't trust the backend response data blindly To: Jan Beulich Cc: Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Boris Ostrovsky , Stefano Stabellini , Jens Axboe , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210513100302.22027-1-jgross@suse.com> <20210513100302.22027-5-jgross@suse.com> <315ad8b9-8a98-8d3e-f66c-ab32af2731a8@suse.com> <6095c4b9-a9bb-8a38-fb6c-a5483105b802@suse.com> <030ef85e-b5af-f46e-c8dc-88b8d195c4e1@suse.com> <477f01cd-8793-705c-10f9-cf0c0cd6ed84@suse.com> <5a9dcc69-385a-eda5-6974-cb962ae62601@suse.com> From: Juergen Gross Message-ID: <7f606c27-173a-542d-406d-196dae784edd@suse.com> Date: Thu, 8 Jul 2021 08:40:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <5a9dcc69-385a-eda5-6974-cb962ae62601@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ja2XZNSE8nO4IrLKl6sE4EnuPN7605kJy" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ja2XZNSE8nO4IrLKl6sE4EnuPN7605kJy Content-Type: multipart/mixed; boundary="LM4uTaxxPZvHMHYeVdJJN6jdt4QkBjnKN"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Boris Ostrovsky , Stefano Stabellini , Jens Axboe , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <7f606c27-173a-542d-406d-196dae784edd@suse.com> Subject: Re: [PATCH 4/8] xen/blkfront: don't trust the backend response data blindly References: <20210513100302.22027-1-jgross@suse.com> <20210513100302.22027-5-jgross@suse.com> <315ad8b9-8a98-8d3e-f66c-ab32af2731a8@suse.com> <6095c4b9-a9bb-8a38-fb6c-a5483105b802@suse.com> <030ef85e-b5af-f46e-c8dc-88b8d195c4e1@suse.com> <477f01cd-8793-705c-10f9-cf0c0cd6ed84@suse.com> <5a9dcc69-385a-eda5-6974-cb962ae62601@suse.com> In-Reply-To: <5a9dcc69-385a-eda5-6974-cb962ae62601@suse.com> --LM4uTaxxPZvHMHYeVdJJN6jdt4QkBjnKN Content-Type: multipart/mixed; boundary="------------2D62ABF81D642597E69B3D65" Content-Language: en-US This is a multi-part message in MIME format. --------------2D62ABF81D642597E69B3D65 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 08.07.21 08:37, Jan Beulich wrote: > On 08.07.2021 07:47, Juergen Gross wrote: >> On 17.05.21 17:33, Jan Beulich wrote: >>> On 17.05.2021 17:22, Juergen Gross wrote: >>>> On 17.05.21 17:12, Jan Beulich wrote: >>>>> On 17.05.2021 16:23, Juergen Gross wrote: >>>>>> On 17.05.21 16:11, Jan Beulich wrote: >>>>>>> On 13.05.2021 12:02, Juergen Gross wrote: >>>>>>>> @@ -1574,10 +1580,16 @@ static irqreturn_t blkif_interrupt(int i= rq, void *dev_id) >>>>>>>> spin_lock_irqsave(&rinfo->ring_lock, flags); >>>>>>>> again: >>>>>>>> rp =3D rinfo->ring.sring->rsp_prod; >>>>>>>> + if (RING_RESPONSE_PROD_OVERFLOW(&rinfo->ring, rp)) { >>>>>>>> + pr_alert("%s: illegal number of responses %u\n", >>>>>>>> + info->gd->disk_name, rp - rinfo->ring.rsp_cons); >>>>>>>> + goto err; >>>>>>>> + } >>>>>>>> rmb(); /* Ensure we see queued responses up to 'rp'. */ >>>>>>> >>>>>>> I think you want to insert after the barrier. >>>>>> >>>>>> Why? The relevant variable which is checked is "rp". The result of= the >>>>>> check is in no way depending on the responses themselves. And any = change >>>>>> of rsp_cons is protected by ring_lock, so there is no possibility = of >>>>>> reading an old value here. >>>>> >>>>> But this is a standard double read situation: You might check a val= ue >>>>> and then (via a separate read) use a different one past the barrier= =2E >>>> >>>> Yes and no. >>>> >>>> rsp_cons should never be written by the other side, and additionally= >>>> it would be read multiple times anyway. >>> >>> But I'm talking about rsp_prod, as that's what rp gets loaded from. >> >> Oh, now I get your problem. >> >> But shouldn't that better be solved by using READ_ONCE() for reading r= p >> instead? >=20 > Not sure - the rmb() is needed anyway aiui, and hence you could as well= > move your code addition. Sure. My question was rather: does the rmb() really eliminate the possibility of a double read introduced by the compiler? If yes, moving the code is the correct solution. Juergen --------------2D62ABF81D642597E69B3D65 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------2D62ABF81D642597E69B3D65-- --LM4uTaxxPZvHMHYeVdJJN6jdt4QkBjnKN-- --Ja2XZNSE8nO4IrLKl6sE4EnuPN7605kJy Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmDmnfsFAwAAAAAACgkQsN6d1ii/Ey8Z kQgAltUawxsUDWM34Hqa6p4r+kkm5+acFIcnRVNM+yie2Kl0XDI1MWK4aEhMQy25z5qtby23kJ9a d2J4cqsindWkTWDQTZJgOGzbyWYnGAIBxT9nMXgLsrqt9RBLkNFKa2uBbhJoYf0bB5uhRXSfKAQO J2MbH27Tg+qLggSSfXpwLNOuhIPYzu1sYoDz9M5tTJvB0bZff80bCHK0hp/5CQqUTYAyieHikwgD qBPyBHOXJMMZ7QGLYF3yZ+dtwJLYq1npbVaCzZ312lxTst2BnO+q6OOPAT7pPZv0Cze2vjeg9fs4 y4l9cnffXUc5Fqtj1bxfO3prXtxMPUZz3M41Dff52Q== =TPit -----END PGP SIGNATURE----- --Ja2XZNSE8nO4IrLKl6sE4EnuPN7605kJy--