xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1
Date: Wed, 31 Mar 2021 18:55:09 +0200	[thread overview]
Message-ID: <800b163affc6334837006a6ef6f8e21415d874e9.camel@suse.com> (raw)
In-Reply-To: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com>

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

On Wed, 2021-03-31 at 16:52 +0200, Jan Beulich wrote:
> Unfortunately aa50f45332f1 ("xen: fix for_each_cpu when NR_CPUS=1")
> has
> caused quite a bit of fallout with gcc10, e.g. (there are at least
> two
> more similar ones, and I didn't bother trying to find them all):
> 
Oh, wow... Sorry about that. I was sure I had checked (and with gcc10),
but clearly I'm wrong.

> [...]
> 
> Re-instate a special form of for_each_cpu(), experimentally "proven"
> to
> avoid the diagnostics.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>

Thanks and Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-03-31 16:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31 14:52 [PATCH] fix for_each_cpu() again for NR_CPUS=1 Jan Beulich
2021-03-31 16:55 ` Dario Faggioli [this message]
2021-04-01  6:13   ` Jan Beulich
2021-04-01  9:00 ` Revert NR_CPUS=1 fix from 4.15 (was: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1) Roger Pau Monné
2021-04-01  9:26   ` Jan Beulich
2021-04-01  9:50     ` Roger Pau Monné
2021-04-06  9:52       ` Ian Jackson
2021-04-06  9:50   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=800b163affc6334837006a6ef6f8e21415d874e9.camel@suse.com \
    --to=dfaggioli@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).