From: Julien Grall <julien@xen.org>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: "Kevin Tian" <kevin.tian@intel.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Jun Nakajima" <jun.nakajima@intel.com>, "Wei Liu" <wl@xen.org>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Ross Lagerwall" <ross.lagerwall@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] xen: do live patching only from main idle loop
Date: Mon, 24 Feb 2020 22:25:35 +0000 [thread overview]
Message-ID: <818b1594-87b3-477d-db37-4ee598793ab7@xen.org> (raw)
In-Reply-To: <20200211093122.5644-1-jgross@suse.com>
Hi Juergen,
On 11/02/2020 09:31, Juergen Gross wrote:
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 6f9bec22d3..30c4c1830b 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -23,7 +23,6 @@
> #include <xen/iocap.h>
> #include <xen/irq.h>
> #include <xen/lib.h>
> -#include <xen/livepatch.h>
> #include <xen/mem_access.h>
> #include <xen/mm.h>
> #include <xen/param.h>
> @@ -2239,11 +2238,6 @@ static void check_for_pcpu_work(void)
> {
> local_irq_enable();
> do_softirq();
> - /*
> - * Must be the last one - as the IPI will trigger us to come here
> - * and we want to patch the hypervisor with almost no stack.
> - */
> - check_for_livepatch_work();
The check here was meant to match the x86 counterpart in
reset_stack_and_jump(). I suspect you also need to remove it.
> local_irq_disable();
> }
> }
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-24 22:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 9:31 [Xen-devel] [PATCH] xen: do live patching only from main idle loop Juergen Gross
2020-02-12 9:46 ` Jan Beulich
2020-02-18 5:41 ` Tian, Kevin
2020-02-24 22:25 ` Julien Grall [this message]
2020-02-26 14:17 ` Jürgen Groß
2020-02-27 21:51 ` Julien Grall
2020-03-02 14:28 ` Jan Beulich
2020-03-02 14:41 ` Ross Lagerwall
2020-03-02 18:34 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=818b1594-87b3-477d-db37-4ee598793ab7@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).