From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v4 2/3] x86/time: yield to hyperthreads after updating TSC during rendezvous
Date: Thu, 1 Apr 2021 11:54:27 +0200 [thread overview]
Message-ID: <81da85eb-2e8e-9b76-2fb3-2beddc33e9af@suse.com> (raw)
In-Reply-To: <d929903c-0e7a-adb9-3317-b66782f13b36@suse.com>
Since we'd like the updates to be done as synchronously as possible,
make an attempt at yielding immediately after the TSC write.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v4: New.
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1708,7 +1708,14 @@ static void time_calibration_tsc_rendezv
atomic_inc(&r->semaphore);
if ( i == 0 )
+ {
write_tsc(master_tsc);
+ /*
+ * Try to give our hyperthread(s), if any, a chance to do
+ * the same as instantly as possible.
+ */
+ cpu_relax();
+ }
while ( atomic_read(&r->semaphore) != (2*total_cpus - 1) )
cpu_relax();
@@ -1730,7 +1737,14 @@ static void time_calibration_tsc_rendezv
}
if ( i == 0 )
+ {
write_tsc(master_tsc);
+ /*
+ * Try to give our hyperthread(s), if any, a chance to do
+ * the same as instantly as possible.
+ */
+ cpu_relax();
+ }
atomic_inc(&r->semaphore);
while ( atomic_read(&r->semaphore) > total_cpus )
next prev parent reply other threads:[~2021-04-01 9:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 9:53 [PATCH v4 0/3] x86/time: calibration rendezvous adjustments Jan Beulich
2021-04-01 9:54 ` [PATCH v4 1/3] x86/time: latch to-be-written TSC value early in rendezvous loop Jan Beulich
2021-04-20 15:44 ` Roger Pau Monné
2021-04-01 9:54 ` Jan Beulich [this message]
2021-04-20 15:59 ` [PATCH v4 2/3] x86/time: yield to hyperthreads after updating TSC during rendezvous Roger Pau Monné
2021-04-21 9:57 ` Jan Beulich
2021-04-01 9:55 ` [PATCH v4 3/3] x86/time: avoid reading the platform timer in rendezvous functions Jan Beulich
2021-04-20 16:12 ` Roger Pau Monné
2021-04-21 10:06 ` Jan Beulich
2021-04-29 9:32 ` Jan Beulich
2021-04-29 12:48 ` Roger Pau Monné
2021-04-29 12:53 ` Roger Pau Monné
2021-04-29 13:51 ` Jan Beulich
2021-04-15 9:54 ` Ping: [PATCH v4 0/3] x86/time: calibration rendezvous adjustments Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81da85eb-2e8e-9b76-2fb3-2beddc33e9af@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).