From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
Ian Jackson <iwj@xenproject.org>, Juergen Gross <jgross@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"julien@xen.org" <julien@xen.org>,
Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Artem Mygaiev <Artem_Mygaiev@epam.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Rahul Singh <rahul.singh@arm.com>,
Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 08/11] libxl: Only map legacy PCI IRQs if they are supported
Date: Mon, 27 Sep 2021 13:02:02 +0000 [thread overview]
Message-ID: <85922b59-2bd4-0f16-9109-7c1ca24f52d8@epam.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2109241704050.17979@sstabellini-ThinkPad-T480s>
On 25.09.21 03:06, Stefano Stabellini wrote:
> On Thu, 23 Sep 2021, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>
>> Arm's PCI passthrough implementation doesn't support legacy interrupts,
>> but MSI/MSI-X. This can be the case for other platforms too.
>> For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add
>> it to the CFLAGS and compile the relevant code in the toolstack only if
>> applicable.
>>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>> Cc: Ian Jackson <iwj@xenproject.org>
>> Cc: Juergen Gross <jgross@suse.com>
>>
>> ---
>> Since v1:
>> - Minimized #idefery by introducing pci_supp_legacy_irq function
>> for relevant checks
>> ---
>> tools/libs/light/Makefile | 4 ++++
>> tools/libs/light/libxl_pci.c | 13 +++++++++++++
>> 2 files changed, 17 insertions(+)
>>
>> diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
>> index 7d8c51d49242..bd3f6be2a183 100644
>> --- a/tools/libs/light/Makefile
>> +++ b/tools/libs/light/Makefile
>> @@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
>> -Wno-declaration-after-statement -Wformat-nonliteral
>> CFLAGS += -I.
>>
>> +ifeq ($(CONFIG_X86),y)
>> +CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ
>> +endif
> This patch is a lot better than the previous version, thanks!
>
> I think the usage of pci_supp_legacy_irq below is good and we can't do
> better than that.
>
> I wonder if there is a better way than the above to export
> CONFIG_PCI_SUPP_LEGACY_IRQ. Suggestions?
I see nothing bad doing it this way, maybe Ian or Juergen can tell
if this is acceptable?
>
>
>> SRCS-$(CONFIG_X86) += libxl_cpuid.c
>> SRCS-$(CONFIG_X86) += libxl_x86.c
>> SRCS-$(CONFIG_X86) += libxl_psr.c
>> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
>> index 59f3686fc85e..4c2d7aeefbb2 100644
>> --- a/tools/libs/light/libxl_pci.c
>> +++ b/tools/libs/light/libxl_pci.c
>> @@ -1364,6 +1364,15 @@ static void pci_add_timeout(libxl__egc *egc, libxl__ev_time *ev,
>> pci_add_dm_done(egc, pas, rc);
>> }
>>
>> +static bool pci_supp_legacy_irq(void)
>> +{
>> +#ifdef CONFIG_PCI_SUPP_LEGACY_IRQ
>> + return true;
>> +#else
>> + return false;
>> +#endif
>> +}
>> +
>> static void pci_add_dm_done(libxl__egc *egc,
>> pci_add_state *pas,
>> int rc)
>> @@ -1434,6 +1443,8 @@ static void pci_add_dm_done(libxl__egc *egc,
>> }
>> }
>> fclose(f);
>> + if (!pci_supp_legacy_irq())
>> + goto out_no_irq;
>> sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain,
>> pci->bus, pci->dev, pci->func);
>> f = fopen(sysfs_path, "r");
>> @@ -1983,6 +1994,8 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs)
>> }
>> fclose(f);
>> skip1:
>> + if (!pci_supp_legacy_irq())
>> + goto skip_irq;
>> sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain,
>> pci->bus, pci->dev, pci->func);
>> f = fopen(sysfs_path, "r");
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2021-09-27 13:02 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 12:54 [PATCH v2 00/11] PCI devices passthrough on Arm, part 2 Oleksandr Andrushchenko
2021-09-23 12:54 ` [PATCH v2 01/11] xen/arm: Fix dev_is_dt macro definition Oleksandr Andrushchenko
2021-09-24 23:39 ` Stefano Stabellini
2021-09-28 7:31 ` Michal Orzel
2021-09-23 12:54 ` [PATCH v2 02/11] xen/arm: Add new device type for PCI Oleksandr Andrushchenko
2021-09-24 23:45 ` Stefano Stabellini
2021-09-27 7:41 ` Jan Beulich
2021-09-27 8:18 ` Oleksandr Andrushchenko
2021-09-23 12:54 ` [PATCH v2 03/11] xen/arm: Introduce pci_find_host_bridge_node helper Oleksandr Andrushchenko
2021-09-24 23:48 ` Stefano Stabellini
2021-09-23 12:54 ` [PATCH v2 04/11] xen/device-tree: Make dt_find_node_by_phandle global Oleksandr Andrushchenko
2021-09-24 23:51 ` Stefano Stabellini
2021-09-23 12:54 ` [PATCH v2 05/11] xen/arm: Mark device as PCI while creating one Oleksandr Andrushchenko
2021-09-24 23:54 ` Stefano Stabellini
2021-09-27 7:13 ` Oleksandr Andrushchenko
2021-09-27 7:45 ` Jan Beulich
2021-09-27 8:45 ` Oleksandr Andrushchenko
2021-09-27 9:19 ` Jan Beulich
2021-09-27 9:35 ` Oleksandr Andrushchenko
2021-09-27 10:00 ` Jan Beulich
2021-09-27 10:04 ` Oleksandr Andrushchenko
2021-09-27 10:26 ` Jan Beulich
2021-09-28 8:09 ` Oleksandr Andrushchenko
2021-09-28 8:26 ` Jan Beulich
2021-09-28 8:29 ` Oleksandr Andrushchenko
2021-09-28 8:39 ` Jan Beulich
2021-09-28 8:54 ` Oleksandr Andrushchenko
2021-09-23 12:54 ` [PATCH v2 06/11] xen/domain: Call pci_release_devices() when releasing domain resources Oleksandr Andrushchenko
2021-09-24 23:57 ` Stefano Stabellini
2021-09-23 12:54 ` [PATCH v2 07/11] libxl: Allow removing PCI devices for all types of domains Oleksandr Andrushchenko
2021-09-25 0:00 ` Stefano Stabellini
2021-09-27 7:17 ` Oleksandr Andrushchenko
2021-09-23 12:54 ` [PATCH v2 08/11] libxl: Only map legacy PCI IRQs if they are supported Oleksandr Andrushchenko
2021-09-25 0:06 ` Stefano Stabellini
2021-09-27 13:02 ` Oleksandr Andrushchenko [this message]
2021-09-23 12:54 ` [PATCH v2 09/11] xen/arm: Setup MMIO range trap handlers for hardware domain Oleksandr Andrushchenko
2021-09-25 0:18 ` Stefano Stabellini
2021-09-27 8:47 ` Oleksandr Andrushchenko
2021-09-23 12:54 ` [PATCH v2 10/11] xen/arm: Do not map PCI ECAM and MMIO space to Domain-0's p2m Oleksandr Andrushchenko
2021-09-25 0:44 ` Stefano Stabellini
2021-09-27 12:44 ` Oleksandr Andrushchenko
2021-09-28 4:00 ` Stefano Stabellini
2021-09-28 4:51 ` Oleksandr Andrushchenko
2021-09-28 14:39 ` Oleksandr Andrushchenko
2021-09-28 16:11 ` Stefano Stabellini
2021-09-23 12:54 ` [PATCH v2 11/11] xen/arm: Process pending vPCI map/unmap operations Oleksandr Andrushchenko
2021-09-25 1:20 ` Stefano Stabellini
2021-09-27 8:06 ` Jan Beulich
2021-09-27 8:39 ` Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85922b59-2bd4-0f16-9109-7c1ca24f52d8@epam.com \
--to=oleksandr_andrushchenko@epam.com \
--cc=Artem_Mygaiev@epam.com \
--cc=Oleksandr_Tyshchenko@epam.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=rahul.singh@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).