From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D2FAC433B4 for ; Mon, 17 May 2021 23:43:30 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3979760FD7 for ; Mon, 17 May 2021 23:43:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3979760FD7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.128532.241288 (Exim 4.92) (envelope-from ) id 1limtG-0007tC-D3; Mon, 17 May 2021 23:43:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 128532.241288; Mon, 17 May 2021 23:43:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1limtG-0007t5-9w; Mon, 17 May 2021 23:43:14 +0000 Received: by outflank-mailman (input) for mailman id 128532; Mon, 17 May 2021 23:43:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1limtF-0007sz-1z for xen-devel@lists.xenproject.org; Mon, 17 May 2021 23:43:13 +0000 Received: from mail-ot1-x331.google.com (unknown [2607:f8b0:4864:20::331]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ac17041e-42ae-4a64-a6b3-5bc24904251d; Mon, 17 May 2021 23:43:12 +0000 (UTC) Received: by mail-ot1-x331.google.com with SMTP id n32-20020a9d1ea30000b02902a53d6ad4bdso7102957otn.3 for ; Mon, 17 May 2021 16:43:12 -0700 (PDT) Received: from [192.168.99.80] (142-79-211-230.starry-inc.net. [142.79.211.230]) by smtp.gmail.com with ESMTPSA id 9sm3045457oie.51.2021.05.17.16.43.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 May 2021 16:43:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac17041e-42ae-4a64-a6b3-5bc24904251d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=MyBYGXe0dG09ETtSlfZDNaPmp0kxxQmpe+PbWLlzy4c=; b=mgLv5OfD2ycIN0KxRISg4k0gn5vjkyhkWmFeh/j7OJeMZ9usQe/l6+95iajvHV9Pz9 YIB/ScvDeIS81UZRt5yTYPIYN2yG04qRIZAVZ1ym7xVjZLBGxyk9jOAOPlzN0L86qFok KEUYFQZnYjZ/35LzGpJ3I1iqI+cqX7LLPqGlG7hZMCmXTWxEwZTyoT2wtb+KtQeztzRG 1X48GuK0RRXyWqumE2mUnxRd1z5cWYAJ4NCVHYkT2sRhpnRst0XDwJkQTlHpoPWB5XXQ zF8BUB9uOvKOzd4a43vQHF8kSOsPVN7fmIBUrMl6UDOtUlnDqqZC+kBvZ2Ry62C69sgZ ZXNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=MyBYGXe0dG09ETtSlfZDNaPmp0kxxQmpe+PbWLlzy4c=; b=JcppIzHKRtZzo/7p97eTILCgtb+6Lg6Ne0TSCIowvbhNDaRWooN8R9rDi7pisSjU29 a0Y9TLetOU/hdcX/+A1LOM/4L8ZH1/UBKpchn9Q7o40ICHRTG2EzXcb1WcPpKFZ8gD6X URUenGrIP2mfYAUn6AtDfqCBJMSLU3TZGrmMKwEEZAAqsFEksGOKpTtSCC8B/681+NNJ 2Lx9Ip2ohCLDM2ndKVO+0cm97kGXhJQKn9N5yEQdRBAKxLFTWATn122PgwhVa/3/JRYf +JTE5Dwrr2t4KKMek4aRSnmqyfa45DGV0zPkw63VPmPLewQ8w9ox4Z9MbMp9lhOVFyHK fQPA== X-Gm-Message-State: AOAM530gvi7EEs6FbVnEeTMpX1SprznQk1OH3cyNL4c0Pp7JK6RYIer/ m3P8V8YyuiaLJqfwPgqdJ24nGSCbzoOA8A== X-Google-Smtp-Source: ABdhPJzdUt0Fo0OgFQ6Iu/Lf7MWF3l4+O2bTmQvkryQ3aEUA80Uk5NsYhsRGQL/rANUfdqrARjezPg== X-Received: by 2002:a05:6830:410d:: with SMTP id w13mr1734902ott.173.1621294991812; Mon, 17 May 2021 16:43:11 -0700 (PDT) Subject: Re: [PATCH v3 1/5] xen/char: Default HAS_NS16550 to y only for X86 and ARM To: Jan Beulich Cc: Bobby Eshleman , Alistair Francis , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <3960a676376e0163d97ac02f968966cdfaccbf75.1621017334.git.connojdavis@gmail.com> <76b5e429-a0b0-b8a2-cd31-85cbb4da8680@suse.com> From: Connor Davis Message-ID: <86738c5c-28b2-b82f-0ff4-ac84cb03a64b@gmail.com> Date: Mon, 17 May 2021 17:43:31 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <76b5e429-a0b0-b8a2-cd31-85cbb4da8680@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 5/17/21 5:56 AM, Jan Beulich wrote: >> --- a/xen/drivers/char/Kconfig >> +++ b/xen/drivers/char/Kconfig >> @@ -1,6 +1,6 @@ >> config HAS_NS16550 >> bool "NS16550 UART driver" if ARM >> - default y >> + default y if (ARM || X86) > ... this approach doesn't scale very well. You would likely have > been hesitant to add a, say, 12-way || here if we had this many > architectures already. I think you instead want > > config HAS_NS16550 > bool "NS16550 UART driver" if ARM > + default n if RISCV > default y > > which then can be adjusted back by another one line change once > the driver code actually builds. > > Jan Agreed, I will update this in the next version. Thanks, Connor