From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1FBAC433E0 for ; Wed, 1 Jul 2020 05:57:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A29D2074D for ; Wed, 1 Jul 2020 05:57:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I0SpaZEE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A29D2074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jqVjW-0003Hz-2y; Wed, 01 Jul 2020 05:56:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jqVjV-0003Hu-5J for xen-devel@lists.xenproject.org; Wed, 01 Jul 2020 05:56:33 +0000 X-Inumbo-ID: 9d3d8bc4-bb5f-11ea-86cd-12813bfff9fa Received: from us-smtp-1.mimecast.com (unknown [207.211.31.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 9d3d8bc4-bb5f-11ea-86cd-12813bfff9fa; Wed, 01 Jul 2020 05:56:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593582992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P9e6pxRlhLqdi/Qte6Z9/WWcMved/5ud2vMwKx50UFk=; b=I0SpaZEE2YBLOd6ZL3U0e1vaoWDAsCYEqgXkPCmfsP4hnAzbYduAdJs2kvorodYlh3BaYQ h8+0LGIk5nnt4BiaTxfjOyzlC98mx7sGhpSyAZ1FmFbpKB6V08QRp7+OBdHSC9SQTnn6SO uCnBMk6J/vqxcMpcQBRDDX/ZMX+cRjM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-45-zcMumqTuPlySm6ML7C6EDw-1; Wed, 01 Jul 2020 01:56:30 -0400 X-MC-Unique: zcMumqTuPlySm6ML7C6EDw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1B91919067E0; Wed, 1 Jul 2020 05:56:29 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D68E612A5; Wed, 1 Jul 2020 05:56:26 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 8BD5311384A6; Wed, 1 Jul 2020 07:56:24 +0200 (CEST) From: Markus Armbruster To: Anthony PERARD Subject: Re: [PATCH 2/2] xen: cleanup unrealized flash devices References: <20200624121841.17971-1-paul@xen.org> <20200624121841.17971-3-paul@xen.org> <20200630150849.GA2110@perard.uk.xensource.com> Date: Wed, 01 Jul 2020 07:56:24 +0200 In-Reply-To: <20200630150849.GA2110@perard.uk.xensource.com> (Anthony PERARD's message of "Tue, 30 Jun 2020 16:08:49 +0100") Message-ID: <87eepvdbhz.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "Michael S. Tsirkin" , Paul Durrant , Jason Andryuk , qemu-devel@nongnu.org, Paul Durrant , xen-devel@lists.xenproject.org, Paolo Bonzini , Richard Henderson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Anthony PERARD writes: > On Wed, Jun 24, 2020 at 01:18:41PM +0100, Paul Durrant wrote: >> From: Paul Durrant >> >> The generic pc_machine_initfn() calls pc_system_flash_create() which creates >> 'system.flash0' and 'system.flash1' devices. These devices are then realized >> by pc_system_flash_map() which is called from pc_system_firmware_init() which >> itself is called via pc_memory_init(). The latter however is not called when >> xen_enable() is true and hence the following assertion fails: >> >> qemu-system-i386: hw/core/qdev.c:439: qdev_assert_realized_properly: >> Assertion `dev->realized' failed >> >> These flash devices are unneeded when using Xen so this patch avoids the >> assertion by simply removing them using pc_system_flash_cleanup_unused(). >> >> Reported-by: Jason Andryuk >> Fixes: ebc29e1beab0 ("pc: Support firmware configuration with -blockdev") >> Signed-off-by: Paul Durrant >> Tested-by: Jason Andryuk > > Reviewed-by: Anthony PERARD > > I think I would add: > > Fixes: dfe8c79c4468 ("qdev: Assert onboard devices all get realized properly") > > as this is the first commit where the unrealized flash devices are an > issue. They were an issue before, but commit dfe8c79c4468 turned the minor issue into a crash bug. No objections.