From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH v9 11/11] (lib)xl: soft reset support
Date: Fri, 17 Jul 2015 14:33:58 +0200
Message-ID: <87io9jnetl.fsf@vitty.brq.redhat.com>
References: <1437064046-12174-1-git-send-email-vkuznets@redhat.com>
	<1437064046-12174-12-git-send-email-vkuznets@redhat.com>
	<20150716185101.GJ14309@x230.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <vkuznets@redhat.com>) id 1ZG4q7-0001SD-J1
	for xen-devel@lists.xenproject.org; Fri, 17 Jul 2015 12:34:07 +0000
In-Reply-To: <20150716185101.GJ14309@x230.dumpdata.com> (Konrad Rzeszutek
	Wilk's message of "Thu, 16 Jul 2015 14:51:01 -0400")
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Andrew Jones <drjones@redhat.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Julien Grall <julien.grall@linaro.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Olaf Hering <olaf@aepfle.de>, Tim Deegan <tim@xen.org>, David Vrabel <david.vrabel@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> writes:

...

>> +        return AO_CREATE_FAIL(ERROR_FAIL);
>> +    }
>> +
>> +    /*
>> +     * On the domain creation path it will be introduced to xenstore
>
> What is 'it'?
>

The domain :-)

>> +     * with (probably) different store/console channels so we need to
>> +     * release it here.
>
> I think what you mean is that:
> On the domain creation path the store/console channels will be
> introduced which will probably different so we need to release
> the old ones here.
> ?

I meant to say is we introduce the newly created domain to xenstored
(and all appropriate records are being created). But your desctiption is
better.

...

-- 
  Vitaly