From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E09A3C433E0 for ; Wed, 20 Jan 2021 08:56:51 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 817E122C9E for ; Wed, 20 Jan 2021 08:56:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 817E122C9E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.71261.127466 (Exim 4.92) (envelope-from ) id 1l29I5-0004C0-Ls; Wed, 20 Jan 2021 08:56:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 71261.127466; Wed, 20 Jan 2021 08:56:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l29I5-0004Bs-Ij; Wed, 20 Jan 2021 08:56:37 +0000 Received: by outflank-mailman (input) for mailman id 71261; Wed, 20 Jan 2021 08:56:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l29I4-0004Bn-JX for xen-devel@lists.xenproject.org; Wed, 20 Jan 2021 08:56:36 +0000 Received: from mail-ed1-x533.google.com (unknown [2a00:1450:4864:20::533]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id faa9334b-11c6-4931-8373-d3179579781f; Wed, 20 Jan 2021 08:56:35 +0000 (UTC) Received: by mail-ed1-x533.google.com with SMTP id j13so520337edp.2 for ; Wed, 20 Jan 2021 00:56:35 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id z22sm706765edb.88.2021.01.20.00.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jan 2021 00:56:33 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id AA3201FF7E; Wed, 20 Jan 2021 08:56:32 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: faa9334b-11c6-4931-8373-d3179579781f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=O7LZ1CyhGv9nOKRtBKA1vePKRSppKmv7791UCVLHNG8=; b=ASK/Eo1SRlZN3h/6VrvtyZWxarariM2Q7jkcPYLjOFbsVdXcvrlqLroGLxuYXMrukK sxsi8REZxDqEMj3Wwm9qi7N6jHaj+9vCFx0fjlnm6K0+EoxI5Br9b5MvFfAd9p3rSRmC 4+bYIffeaFldubq15q3tho7EuA0YSxlhjO4CWYobL6jJgeH+4bNpa+n0kUtpTlZJiXaB hVqTmafsCSGOsSqMAe+qV3hpEA4Azf+130Xa423umYl1gRMh4T2LTBdC/tKo9bR1MyOr iMH7vVzOvasSZtu9eyzvFGf23tOyktrK7iV0BtyWphEVX4Lp5PZgUgTRRjQ/TrU0fJpX 2mdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=O7LZ1CyhGv9nOKRtBKA1vePKRSppKmv7791UCVLHNG8=; b=I6+dqkC7cWi7K43a0pm4ZebxHylNbphc3fV107hXD/Ed0hX/MKOiw/9qwsyI1lweBa MOAxEEm9wdenx7cYNzmF0/2qawGRyq75kXuWKsa8Weq2no5soY2LUU39t+epa1En/IhF ir5Lc3Wrn0KzzidlGBoNSLQ+PcfePIO2eivbrUGG7jOeCR/6UfXo72arMwsaQjEl3KTt FMZ6FA2zQ8j2xhRErcRNIEzKGSoEiYzfgMxIRR2lqSF487lX8ebUkIiHClc3xvos4fBS LX++ONP2dR2ObCrJk0+gQiDvXcOYkY75h3JyFJ2tHDhhd0YgS+iJIHpqaLtSMZ0BZlY+ tMjg== X-Gm-Message-State: AOAM5300g63FUG4Nex3IuGAm82jgqC9Ng428gfE3rZ7vQ1nxRpLGgtkf B4kcyhjBF5wFdtB6zJFBcHjHPw== X-Google-Smtp-Source: ABdhPJw4TY/ElD16elVTE7kyetDCaV0UYrAU2WK3Vfnja9er6+ksTgX9KgYwTR2n7dMfQA/oAIPVJg== X-Received: by 2002:a05:6402:306a:: with SMTP id bs10mr6557963edb.209.1611132994640; Wed, 20 Jan 2021 00:56:34 -0800 (PST) References: <1610488352-18494-1-git-send-email-olekstysh@gmail.com> <1610488352-18494-6-git-send-email-olekstysh@gmail.com> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Oleksandr Tyshchenko Cc: Oleksandr Tyshchenko , Paul Durrant , Jan Beulich , Andrew Cooper , Roger Pau =?utf-8?Q?Monn=C3=A9?= , Wei Liu , Julien Grall , Stefano Stabellini , Julien Grall , xen-devel@lists.xenproject.org Subject: Re: [PATCH V4 05/24] xen/ioreq: Make x86's hvm_ioreq_needs_completion() common Date: Wed, 20 Jan 2021 08:48:09 +0000 In-reply-to: <1610488352-18494-6-git-send-email-olekstysh@gmail.com> Message-ID: <87v9bst29r.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Oleksandr Tyshchenko writes: > From: Oleksandr Tyshchenko > > The IOREQ is a common feature now and this helper will be used > on Arm as is. Move it to xen/ioreq.h and remove "hvm" prefix. > > Although PIO handling on Arm is not introduced with the current series > (it will be implemented when we add support for vPCI), technically > the PIOs exist on Arm (however they are accessed the same way as MMIO) > and it would be better not to diverge now. I find this description a little confusing. When you say PIO do you mean using instructions like in/out on the x86? If so then AFAIK it's a legacy feature of x86 as everything I've come across since just does MMIO, including PCI. The code changes look fine to me though: Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e