From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70B17ECAAD8 for ; Wed, 21 Sep 2022 14:32:47 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.409453.652796 (Exim 4.92) (envelope-from ) id 1ob0m3-0004a5-5g; Wed, 21 Sep 2022 14:32:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409453.652796; Wed, 21 Sep 2022 14:32:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ob0m3-0004Zy-14; Wed, 21 Sep 2022 14:32:27 +0000 Received: by outflank-mailman (input) for mailman id 409453; Tue, 20 Sep 2022 14:01:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oadoI-0007yu-Bj for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 14:01:14 +0000 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [2607:f8b0:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af7323fd-38ec-11ed-9647-05401a9f4f97; Tue, 20 Sep 2022 16:01:13 +0200 (CEST) Received: by mail-ot1-x336.google.com with SMTP id br15-20020a056830390f00b0061c9d73b8bdso1770278otb.6 for ; Tue, 20 Sep 2022 07:01:13 -0700 (PDT) Received: from [192.168.10.102] ([191.193.2.69]) by smtp.gmail.com with ESMTPSA id y22-20020a056830071600b0065892f42157sm821295ots.75.2022.09.20.07.00.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 07:01:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af7323fd-38ec-11ed-9647-05401a9f4f97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=obx72+8lj9qm2WhrMMX0CKsbEGig5oqUktdJe59wJ8c=; b=EYGsqsWfnaYLIUhNnwR+W3+HQV7e1PVwf2K+QWqXr8T8ik7uhUchYwfaPRXzwOSNdj Y/VehUxaTawGdfoqwV5K3tSuvfrPWqckFhn+PXkxZYghBOhI2+TO0xbTzdFFrdhpyh2x veDoWSvsPDca3I578Fy9amlMqEZxQtbHz3JbXHWjMiu5OfyH5uyFImUWMMUvuKamIuTS YG8Kte9lSMN+Y8mrfYFVvuA43odoGtzEhiO8+jo4NP0P6X2/MTgvqMcLEzX/vDtgsO9b Gwc7jwC79qXCaM1/HPNBUkVZGrFZS5xRrwr2Ne3iu0RW7Y6naElU5JeR1p5TlLLhSvzD 4tyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=obx72+8lj9qm2WhrMMX0CKsbEGig5oqUktdJe59wJ8c=; b=7R6JVd++CElh7aQ1JX7wioSxtbqvw6KzxH9fLUwd43RF6htwSHxGTpM0AelXimEGAp Pc8cbBgapJc7MUMMTHdihnL8VryzKFDUm6vy8/78U4hz0qMYeldCETqdjmOHptZGB3GI 6lHPCgoP5OBRPEFKxQ1leH0uc9UJQ4SHOD6BqffA94V/MOsWxHdqfdMUW/ZBQ3dYjIb2 n7APv3h49lBQDtEkD9E++YoyOr4rgnVdgzcygAGTYN8G9kkwzNoUh42aamrupXX6gqGN KwwFaWXYMnZm4W6YtwGdHiepvnMH0NEJEg1bE/QtTuqJA2NA84u0qH2v+BSTSWbvhj8i 1/dQ== X-Gm-Message-State: ACrzQf1OgjF2dM+gdxbgI56ysAyk3be4kI6ctUuT1pGTjowAH2YLelvW u7vX1zezCjh78XS763lXWUY= X-Google-Smtp-Source: AMsMyM7SJwY7Rzq8kp0hCW9RSDbUha/Eoq34TgM/6q2jfQ2yIYDABRMiwIOljIt9IFN/T/DE/u7ntw== X-Received: by 2002:a05:6830:18d8:b0:655:1f50:715f with SMTP id v24-20020a05683018d800b006551f50715fmr10392167ote.97.1663682472036; Tue, 20 Sep 2022 07:01:12 -0700 (PDT) Message-ID: <8906f236-dbfc-7d51-a87d-2c02e8c506b2@gmail.com> Date: Tue, 20 Sep 2022 11:00:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 4/9] hw/ppc/spapr: Fix code style problems reported by checkpatch To: Bernhard Beschow , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-5-shentey@gmail.com> Content-Language: en-US From: Daniel Henrique Barboza In-Reply-To: <20220919231720.163121-5-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/19/22 20:17, Bernhard Beschow wrote: > Signed-off-by: Bernhard Beschow > --- Reviewed-by: Daniel Henrique Barboza And I've queued it in gitlab.com/danielhb/qemu/tree/ppc-next since it's not tied with the rest of the series. Thanks, Daniel > include/hw/ppc/spapr.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > index 530d739b1d..04a95669ab 100644 > --- a/include/hw/ppc/spapr.h > +++ b/include/hw/ppc/spapr.h > @@ -848,7 +848,8 @@ static inline uint64_t ppc64_phys_to_real(uint64_t addr) > > static inline uint32_t rtas_ld(target_ulong phys, int n) > { > - return ldl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4*n)); > + return ldl_be_phys(&address_space_memory, > + ppc64_phys_to_real(phys + 4 * n)); > } > > static inline uint64_t rtas_ldq(target_ulong phys, int n) > @@ -858,7 +859,7 @@ static inline uint64_t rtas_ldq(target_ulong phys, int n) > > static inline void rtas_st(target_ulong phys, int n, uint32_t val) > { > - stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4*n), val); > + stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4 * n), val); > } > > typedef void (*spapr_rtas_fn)(PowerPCCPU *cpu, SpaprMachineState *sm,