how to disable build of pv-shim?

how to disable build of pv-shim?

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 230 bytes --]

What is the recommended way to disable CONFIG_PV_SHIM, which is set in
tools/firmware/Makefile? From my understanding there is no way to influence
its value from outside, which means the build always enters xen-dir/.


Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] how to disable build of pv-shim?

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 230 bytes --]

What is the recommended way to disable CONFIG_PV_SHIM, which is set in
tools/firmware/Makefile? From my understanding there is no way to influence
its value from outside, which means the build always enters xen-dir/.


Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Wei Liu]

On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> tools/firmware/Makefile? From my understanding there is no way to influence
> its value from outside, which means the build always enters xen-dir/.
> 

There isn't a way to disable it yet.

I would suggest you add a --disable-pv-shim or something to tools'
configure script.

Wei.

> 
> Olaf



> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Wei Liu]

On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> tools/firmware/Makefile? From my understanding there is no way to influence
> its value from outside, which means the build always enters xen-dir/.
> 

There isn't a way to disable it yet.

I would suggest you add a --disable-pv-shim or something to tools'
configure script.

Wei.

> 
> Olaf



> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Roger Pau Monné]

On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> tools/firmware/Makefile? From my understanding there is no way to influence
> its value from outside, which means the build always enters xen-dir/.

I think the following should do the trick.

Let me know if that works for you and I will submit it formally.

Thanks!

---8<---
diff --git a/config/Tools.mk.in b/config/Tools.mk.in
index 98245f63c9..84ddb1a542 100644
--- a/config/Tools.mk.in
+++ b/config/Tools.mk.in
@@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
 ARGP_LDFLAGS        := @argp_ldflags@
 
 FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
+
+CONFIG_PV_SHIM      := @pvshim@
diff --git a/tools/configure.ac b/tools/configure.ac
index c9fd69ddfa..8df2fd604b 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
 
 AC_SUBST(ninepfs)
 
+AC_ARG_ENABLE([pvshim],
+    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
+    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
+    case "$host_cpu" in
+        i[[3456]]86|x86_64)
+           pvshim="y";;
+        *) pvshim="n";;
+    esac
+     ])
+AC_SUBST(pvshim)
+
 AC_OUTPUT()
diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
index cf304fc578..809a5fd025 100644
--- a/tools/firmware/Makefile
+++ b/tools/firmware/Makefile
@@ -1,10 +1,6 @@
 XEN_ROOT = $(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-ifneq ($(XEN_TARGET_ARCH),x86_32)
-CONFIG_PV_SHIM := y
-endif
-
 # hvmloader is a 32-bit protected mode binary.
 TARGET      := hvmloader/hvmloader
 INST_DIR := $(DESTDIR)$(XENFIRMWAREDIR)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Roger Pau Monné]

On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> tools/firmware/Makefile? From my understanding there is no way to influence
> its value from outside, which means the build always enters xen-dir/.

I think the following should do the trick.

Let me know if that works for you and I will submit it formally.

Thanks!

---8<---
diff --git a/config/Tools.mk.in b/config/Tools.mk.in
index 98245f63c9..84ddb1a542 100644
--- a/config/Tools.mk.in
+++ b/config/Tools.mk.in
@@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
 ARGP_LDFLAGS        := @argp_ldflags@
 
 FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
+
+CONFIG_PV_SHIM      := @pvshim@
diff --git a/tools/configure.ac b/tools/configure.ac
index c9fd69ddfa..8df2fd604b 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
 
 AC_SUBST(ninepfs)
 
+AC_ARG_ENABLE([pvshim],
+    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
+    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
+    case "$host_cpu" in
+        i[[3456]]86|x86_64)
+           pvshim="y";;
+        *) pvshim="n";;
+    esac
+     ])
+AC_SUBST(pvshim)
+
 AC_OUTPUT()
diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
index cf304fc578..809a5fd025 100644
--- a/tools/firmware/Makefile
+++ b/tools/firmware/Makefile
@@ -1,10 +1,6 @@
 XEN_ROOT = $(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-ifneq ($(XEN_TARGET_ARCH),x86_32)
-CONFIG_PV_SHIM := y
-endif
-
 # hvmloader is a 32-bit protected mode binary.
 TARGET      := hvmloader/hvmloader
 INST_DIR := $(DESTDIR)$(XENFIRMWAREDIR)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Wei Liu]

On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> > tools/firmware/Makefile? From my understanding there is no way to influence
> > its value from outside, which means the build always enters xen-dir/.
> 
> I think the following should do the trick.
> 
> Let me know if that works for you and I will submit it formally.
> 
> Thanks!
> 
> ---8<---
> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> index 98245f63c9..84ddb1a542 100644
> --- a/config/Tools.mk.in
> +++ b/config/Tools.mk.in
> @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
>  ARGP_LDFLAGS        := @argp_ldflags@
>  
>  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
> +
> +CONFIG_PV_SHIM      := @pvshim@
> diff --git a/tools/configure.ac b/tools/configure.ac
> index c9fd69ddfa..8df2fd604b 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>  
>  AC_SUBST(ninepfs)
>  
> +AC_ARG_ENABLE([pvshim],
> +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
> +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> +    case "$host_cpu" in
> +        i[[3456]]86|x86_64)
> +           pvshim="y";;

Since xen doesn't build on 32bit anymore you may want to exclude
i[3456]86 here?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Wei Liu]

On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> > tools/firmware/Makefile? From my understanding there is no way to influence
> > its value from outside, which means the build always enters xen-dir/.
> 
> I think the following should do the trick.
> 
> Let me know if that works for you and I will submit it formally.
> 
> Thanks!
> 
> ---8<---
> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> index 98245f63c9..84ddb1a542 100644
> --- a/config/Tools.mk.in
> +++ b/config/Tools.mk.in
> @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
>  ARGP_LDFLAGS        := @argp_ldflags@
>  
>  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
> +
> +CONFIG_PV_SHIM      := @pvshim@
> diff --git a/tools/configure.ac b/tools/configure.ac
> index c9fd69ddfa..8df2fd604b 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>  
>  AC_SUBST(ninepfs)
>  
> +AC_ARG_ENABLE([pvshim],
> +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
> +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> +    case "$host_cpu" in
> +        i[[3456]]86|x86_64)
> +           pvshim="y";;

Since xen doesn't build on 32bit anymore you may want to exclude
i[3456]86 here?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Roger Pau Monné]

On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
> On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> > > tools/firmware/Makefile? From my understanding there is no way to influence
> > > its value from outside, which means the build always enters xen-dir/.
> > 
> > I think the following should do the trick.
> > 
> > Let me know if that works for you and I will submit it formally.
> > 
> > Thanks!
> > 
> > ---8<---
> > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> > index 98245f63c9..84ddb1a542 100644
> > --- a/config/Tools.mk.in
> > +++ b/config/Tools.mk.in
> > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
> >  ARGP_LDFLAGS        := @argp_ldflags@
> >  
> >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
> > +
> > +CONFIG_PV_SHIM      := @pvshim@
> > diff --git a/tools/configure.ac b/tools/configure.ac
> > index c9fd69ddfa..8df2fd604b 100644
> > --- a/tools/configure.ac
> > +++ b/tools/configure.ac
> > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
> >  
> >  AC_SUBST(ninepfs)
> >  
> > +AC_ARG_ENABLE([pvshim],
> > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
> > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> > +    case "$host_cpu" in
> > +        i[[3456]]86|x86_64)
> > +           pvshim="y";;
> 
> Since xen doesn't build on 32bit anymore you may want to exclude
> i[3456]86 here?

Oh, I didn't realize this. Is it true for all distros?

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Roger Pau Monné]

On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
> On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> > > tools/firmware/Makefile? From my understanding there is no way to influence
> > > its value from outside, which means the build always enters xen-dir/.
> > 
> > I think the following should do the trick.
> > 
> > Let me know if that works for you and I will submit it formally.
> > 
> > Thanks!
> > 
> > ---8<---
> > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> > index 98245f63c9..84ddb1a542 100644
> > --- a/config/Tools.mk.in
> > +++ b/config/Tools.mk.in
> > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
> >  ARGP_LDFLAGS        := @argp_ldflags@
> >  
> >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
> > +
> > +CONFIG_PV_SHIM      := @pvshim@
> > diff --git a/tools/configure.ac b/tools/configure.ac
> > index c9fd69ddfa..8df2fd604b 100644
> > --- a/tools/configure.ac
> > +++ b/tools/configure.ac
> > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
> >  
> >  AC_SUBST(ninepfs)
> >  
> > +AC_ARG_ENABLE([pvshim],
> > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
> > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> > +    case "$host_cpu" in
> > +        i[[3456]]86|x86_64)
> > +           pvshim="y";;
> 
> Since xen doesn't build on 32bit anymore you may want to exclude
> i[3456]86 here?

Oh, I didn't realize this. Is it true for all distros?

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Wei Liu]

On Tue, May 14, 2019 at 10:55:18AM +0200, Roger Pau Monné wrote:
> On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
> > On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> > > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> > > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> > > > tools/firmware/Makefile? From my understanding there is no way to influence
> > > > its value from outside, which means the build always enters xen-dir/.
> > > 
> > > I think the following should do the trick.
> > > 
> > > Let me know if that works for you and I will submit it formally.
> > > 
> > > Thanks!
> > > 
> > > ---8<---
> > > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> > > index 98245f63c9..84ddb1a542 100644
> > > --- a/config/Tools.mk.in
> > > +++ b/config/Tools.mk.in
> > > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
> > >  ARGP_LDFLAGS        := @argp_ldflags@
> > >  
> > >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
> > > +
> > > +CONFIG_PV_SHIM      := @pvshim@
> > > diff --git a/tools/configure.ac b/tools/configure.ac
> > > index c9fd69ddfa..8df2fd604b 100644
> > > --- a/tools/configure.ac
> > > +++ b/tools/configure.ac
> > > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
> > >  
> > >  AC_SUBST(ninepfs)
> > >  
> > > +AC_ARG_ENABLE([pvshim],
> > > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
> > > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> > > +    case "$host_cpu" in
> > > +        i[[3456]]86|x86_64)
> > > +           pvshim="y";;
> > 
> > Since xen doesn't build on 32bit anymore you may want to exclude
> > i[3456]86 here?
> 
> Oh, I didn't realize this. Is it true for all distros?

FAOD I was thinking about 32bit xen support. But I just realise since
you tested host_cpu here, maybe you intended to do a cross-build?

I have never tested cross-building 64bit xen on a 32bit platform...

Wei.

> 
> Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Wei Liu]

On Tue, May 14, 2019 at 10:55:18AM +0200, Roger Pau Monné wrote:
> On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
> > On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> > > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> > > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> > > > tools/firmware/Makefile? From my understanding there is no way to influence
> > > > its value from outside, which means the build always enters xen-dir/.
> > > 
> > > I think the following should do the trick.
> > > 
> > > Let me know if that works for you and I will submit it formally.
> > > 
> > > Thanks!
> > > 
> > > ---8<---
> > > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> > > index 98245f63c9..84ddb1a542 100644
> > > --- a/config/Tools.mk.in
> > > +++ b/config/Tools.mk.in
> > > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
> > >  ARGP_LDFLAGS        := @argp_ldflags@
> > >  
> > >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
> > > +
> > > +CONFIG_PV_SHIM      := @pvshim@
> > > diff --git a/tools/configure.ac b/tools/configure.ac
> > > index c9fd69ddfa..8df2fd604b 100644
> > > --- a/tools/configure.ac
> > > +++ b/tools/configure.ac
> > > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
> > >  
> > >  AC_SUBST(ninepfs)
> > >  
> > > +AC_ARG_ENABLE([pvshim],
> > > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
> > > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> > > +    case "$host_cpu" in
> > > +        i[[3456]]86|x86_64)
> > > +           pvshim="y";;
> > 
> > Since xen doesn't build on 32bit anymore you may want to exclude
> > i[3456]86 here?
> 
> Oh, I didn't realize this. Is it true for all distros?

FAOD I was thinking about 32bit xen support. But I just realise since
you tested host_cpu here, maybe you intended to do a cross-build?

I have never tested cross-building 64bit xen on a 32bit platform...

Wei.

> 
> Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Jan Beulich]

>>> On 14.05.19 at 10:55, <roger.pau@citrix.com> wrote:
> On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
>> On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
>> > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
>> > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
>> > > tools/firmware/Makefile? From my understanding there is no way to 
> influence
>> > > its value from outside, which means the build always enters xen-dir/.
>> > 
>> > I think the following should do the trick.
>> > 
>> > Let me know if that works for you and I will submit it formally.
>> > 
>> > Thanks!
>> > 
>> > ---8<---
>> > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
>> > index 98245f63c9..84ddb1a542 100644
>> > --- a/config/Tools.mk.in
>> > +++ b/config/Tools.mk.in
>> > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
>> >  ARGP_LDFLAGS        := @argp_ldflags@
>> >  
>> >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
>> > +
>> > +CONFIG_PV_SHIM      := @pvshim@
>> > diff --git a/tools/configure.ac b/tools/configure.ac
>> > index c9fd69ddfa..8df2fd604b 100644
>> > --- a/tools/configure.ac
>> > +++ b/tools/configure.ac
>> > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>> >  
>> >  AC_SUBST(ninepfs)
>> >  
>> > +AC_ARG_ENABLE([pvshim],
>> > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, 
> enabled by default)]),
>> > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
>> > +    case "$host_cpu" in
>> > +        i[[3456]]86|x86_64)
>> > +           pvshim="y";;
>> 
>> Since xen doesn't build on 32bit anymore you may want to exclude
>> i[3456]86 here?
> 
> Oh, I didn't realize this. Is it true for all distros?

It's a property of the hypervisor (note: not the tool stack), as of 4.3.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Jan Beulich]

>>> On 14.05.19 at 10:55, <roger.pau@citrix.com> wrote:
> On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
>> On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
>> > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
>> > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
>> > > tools/firmware/Makefile? From my understanding there is no way to 
> influence
>> > > its value from outside, which means the build always enters xen-dir/.
>> > 
>> > I think the following should do the trick.
>> > 
>> > Let me know if that works for you and I will submit it formally.
>> > 
>> > Thanks!
>> > 
>> > ---8<---
>> > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
>> > index 98245f63c9..84ddb1a542 100644
>> > --- a/config/Tools.mk.in
>> > +++ b/config/Tools.mk.in
>> > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
>> >  ARGP_LDFLAGS        := @argp_ldflags@
>> >  
>> >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
>> > +
>> > +CONFIG_PV_SHIM      := @pvshim@
>> > diff --git a/tools/configure.ac b/tools/configure.ac
>> > index c9fd69ddfa..8df2fd604b 100644
>> > --- a/tools/configure.ac
>> > +++ b/tools/configure.ac
>> > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>> >  
>> >  AC_SUBST(ninepfs)
>> >  
>> > +AC_ARG_ENABLE([pvshim],
>> > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, 
> enabled by default)]),
>> > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
>> > +    case "$host_cpu" in
>> > +        i[[3456]]86|x86_64)
>> > +           pvshim="y";;
>> 
>> Since xen doesn't build on 32bit anymore you may want to exclude
>> i[3456]86 here?
> 
> Oh, I didn't realize this. Is it true for all distros?

It's a property of the hypervisor (note: not the tool stack), as of 4.3.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Andrew Cooper]

On 14/05/2019 10:23, Wei Liu wrote:
> On Tue, May 14, 2019 at 10:55:18AM +0200, Roger Pau Monné wrote:
>> On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
>>> On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
>>>> On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
>>>>> What is the recommended way to disable CONFIG_PV_SHIM, which is set in
>>>>> tools/firmware/Makefile? From my understanding there is no way to influence
>>>>> its value from outside, which means the build always enters xen-dir/.
>>>> I think the following should do the trick.
>>>>
>>>> Let me know if that works for you and I will submit it formally.
>>>>
>>>> Thanks!
>>>>
>>>> ---8<---
>>>> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
>>>> index 98245f63c9..84ddb1a542 100644
>>>> --- a/config/Tools.mk.in
>>>> +++ b/config/Tools.mk.in
>>>> @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
>>>>  ARGP_LDFLAGS        := @argp_ldflags@
>>>>  
>>>>  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
>>>> +
>>>> +CONFIG_PV_SHIM      := @pvshim@
>>>> diff --git a/tools/configure.ac b/tools/configure.ac
>>>> index c9fd69ddfa..8df2fd604b 100644
>>>> --- a/tools/configure.ac
>>>> +++ b/tools/configure.ac
>>>> @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>>>>  
>>>>  AC_SUBST(ninepfs)
>>>>  
>>>> +AC_ARG_ENABLE([pvshim],
>>>> +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
>>>> +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
>>>> +    case "$host_cpu" in
>>>> +        i[[3456]]86|x86_64)
>>>> +           pvshim="y";;
>>> Since xen doesn't build on 32bit anymore you may want to exclude
>>> i[3456]86 here?
>> Oh, I didn't realize this. Is it true for all distros?
> FAOD I was thinking about 32bit xen support. But I just realise since
> you tested host_cpu here, maybe you intended to do a cross-build?
>
> I have never tested cross-building 64bit xen on a 32bit platform...

XenServer used this for many years when we had a 64bit Xen and 32bit
dom0.  It works fine (or did last time I checked, and I have no reason
to expect that we've broken it).

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Andrew Cooper]

On 14/05/2019 10:23, Wei Liu wrote:
> On Tue, May 14, 2019 at 10:55:18AM +0200, Roger Pau Monné wrote:
>> On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
>>> On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
>>>> On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
>>>>> What is the recommended way to disable CONFIG_PV_SHIM, which is set in
>>>>> tools/firmware/Makefile? From my understanding there is no way to influence
>>>>> its value from outside, which means the build always enters xen-dir/.
>>>> I think the following should do the trick.
>>>>
>>>> Let me know if that works for you and I will submit it formally.
>>>>
>>>> Thanks!
>>>>
>>>> ---8<---
>>>> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
>>>> index 98245f63c9..84ddb1a542 100644
>>>> --- a/config/Tools.mk.in
>>>> +++ b/config/Tools.mk.in
>>>> @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
>>>>  ARGP_LDFLAGS        := @argp_ldflags@
>>>>  
>>>>  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
>>>> +
>>>> +CONFIG_PV_SHIM      := @pvshim@
>>>> diff --git a/tools/configure.ac b/tools/configure.ac
>>>> index c9fd69ddfa..8df2fd604b 100644
>>>> --- a/tools/configure.ac
>>>> +++ b/tools/configure.ac
>>>> @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>>>>  
>>>>  AC_SUBST(ninepfs)
>>>>  
>>>> +AC_ARG_ENABLE([pvshim],
>>>> +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
>>>> +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
>>>> +    case "$host_cpu" in
>>>> +        i[[3456]]86|x86_64)
>>>> +           pvshim="y";;
>>> Since xen doesn't build on 32bit anymore you may want to exclude
>>> i[3456]86 here?
>> Oh, I didn't realize this. Is it true for all distros?
> FAOD I was thinking about 32bit xen support. But I just realise since
> you tested host_cpu here, maybe you intended to do a cross-build?
>
> I have never tested cross-building 64bit xen on a 32bit platform...

XenServer used this for many years when we had a 64bit Xen and 32bit
dom0.  It works fine (or did last time I checked, and I have no reason
to expect that we've broken it).

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Jan Beulich]

>>> On 14.05.19 at 11:23, <wei.liu2@citrix.com> wrote:
> On Tue, May 14, 2019 at 10:55:18AM +0200, Roger Pau Monné wrote:
>> On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
>> > On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
>> > > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
>> > > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
>> > > > tools/firmware/Makefile? From my understanding there is no way to 
> influence
>> > > > its value from outside, which means the build always enters xen-dir/.
>> > > 
>> > > I think the following should do the trick.
>> > > 
>> > > Let me know if that works for you and I will submit it formally.
>> > > 
>> > > Thanks!
>> > > 
>> > > ---8<---
>> > > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
>> > > index 98245f63c9..84ddb1a542 100644
>> > > --- a/config/Tools.mk.in
>> > > +++ b/config/Tools.mk.in
>> > > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
>> > >  ARGP_LDFLAGS        := @argp_ldflags@
>> > >  
>> > >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
>> > > +
>> > > +CONFIG_PV_SHIM      := @pvshim@
>> > > diff --git a/tools/configure.ac b/tools/configure.ac
>> > > index c9fd69ddfa..8df2fd604b 100644
>> > > --- a/tools/configure.ac
>> > > +++ b/tools/configure.ac
>> > > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>> > >  
>> > >  AC_SUBST(ninepfs)
>> > >  
>> > > +AC_ARG_ENABLE([pvshim],
>> > > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
>> > > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
>> > > +    case "$host_cpu" in
>> > > +        i[[3456]]86|x86_64)
>> > > +           pvshim="y";;
>> > 
>> > Since xen doesn't build on 32bit anymore you may want to exclude
>> > i[3456]86 here?
>> 
>> Oh, I didn't realize this. Is it true for all distros?
> 
> FAOD I was thinking about 32bit xen support. But I just realise since
> you tested host_cpu here, maybe you intended to do a cross-build?

If the intention is a cross build, then host CPU shouldn't matter at
all, i.e. building e.g. on Arm should work as well.

When considering the target CPU, implying a 64-bit hypervisor from
a 32-bit general (i.e. tool stack) target would of course be an option.
Question just is how you would determine whether a suitable cross
tool chain is available.

> I have never tested cross-building 64bit xen on a 32bit platform...

As Andrew says - this works perfectly fine.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Jan Beulich]

>>> On 14.05.19 at 11:23, <wei.liu2@citrix.com> wrote:
> On Tue, May 14, 2019 at 10:55:18AM +0200, Roger Pau Monné wrote:
>> On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
>> > On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
>> > > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
>> > > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
>> > > > tools/firmware/Makefile? From my understanding there is no way to 
> influence
>> > > > its value from outside, which means the build always enters xen-dir/.
>> > > 
>> > > I think the following should do the trick.
>> > > 
>> > > Let me know if that works for you and I will submit it formally.
>> > > 
>> > > Thanks!
>> > > 
>> > > ---8<---
>> > > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
>> > > index 98245f63c9..84ddb1a542 100644
>> > > --- a/config/Tools.mk.in
>> > > +++ b/config/Tools.mk.in
>> > > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
>> > >  ARGP_LDFLAGS        := @argp_ldflags@
>> > >  
>> > >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
>> > > +
>> > > +CONFIG_PV_SHIM      := @pvshim@
>> > > diff --git a/tools/configure.ac b/tools/configure.ac
>> > > index c9fd69ddfa..8df2fd604b 100644
>> > > --- a/tools/configure.ac
>> > > +++ b/tools/configure.ac
>> > > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>> > >  
>> > >  AC_SUBST(ninepfs)
>> > >  
>> > > +AC_ARG_ENABLE([pvshim],
>> > > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
>> > > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
>> > > +    case "$host_cpu" in
>> > > +        i[[3456]]86|x86_64)
>> > > +           pvshim="y";;
>> > 
>> > Since xen doesn't build on 32bit anymore you may want to exclude
>> > i[3456]86 here?
>> 
>> Oh, I didn't realize this. Is it true for all distros?
> 
> FAOD I was thinking about 32bit xen support. But I just realise since
> you tested host_cpu here, maybe you intended to do a cross-build?

If the intention is a cross build, then host CPU shouldn't matter at
all, i.e. building e.g. on Arm should work as well.

When considering the target CPU, implying a 64-bit hypervisor from
a 32-bit general (i.e. tool stack) target would of course be an option.
Question just is how you would determine whether a suitable cross
tool chain is available.

> I have never tested cross-building 64bit xen on a 32bit platform...

As Andrew says - this works perfectly fine.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 251 bytes --]

Am Mon, 13 May 2019 17:20:05 +0200
schrieb Roger Pau Monné <roger.pau@citrix.com>:

> enabled by default

Does anyone actually require it at all?
Those who do pass --enable-pvshim to configure. No need for (incorrect) host_cpu checks.

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 251 bytes --]

Am Mon, 13 May 2019 17:20:05 +0200
schrieb Roger Pau Monné <roger.pau@citrix.com>:

> enabled by default

Does anyone actually require it at all?
Those who do pass --enable-pvshim to configure. No need for (incorrect) host_cpu checks.

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Roger Pau Monné]

On Tue, May 14, 2019 at 03:52:39AM -0600, Jan Beulich wrote:
> >>> On 14.05.19 at 11:23, <wei.liu2@citrix.com> wrote:
> > On Tue, May 14, 2019 at 10:55:18AM +0200, Roger Pau Monné wrote:
> >> On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
> >> > On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> >> > > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> >> > > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> >> > > > tools/firmware/Makefile? From my understanding there is no way to 
> > influence
> >> > > > its value from outside, which means the build always enters xen-dir/.
> >> > > 
> >> > > I think the following should do the trick.
> >> > > 
> >> > > Let me know if that works for you and I will submit it formally.
> >> > > 
> >> > > Thanks!
> >> > > 
> >> > > ---8<---
> >> > > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> >> > > index 98245f63c9..84ddb1a542 100644
> >> > > --- a/config/Tools.mk.in
> >> > > +++ b/config/Tools.mk.in
> >> > > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
> >> > >  ARGP_LDFLAGS        := @argp_ldflags@
> >> > >  
> >> > >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
> >> > > +
> >> > > +CONFIG_PV_SHIM      := @pvshim@
> >> > > diff --git a/tools/configure.ac b/tools/configure.ac
> >> > > index c9fd69ddfa..8df2fd604b 100644
> >> > > --- a/tools/configure.ac
> >> > > +++ b/tools/configure.ac
> >> > > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
> >> > >  
> >> > >  AC_SUBST(ninepfs)
> >> > >  
> >> > > +AC_ARG_ENABLE([pvshim],
> >> > > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
> >> > > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> >> > > +    case "$host_cpu" in
> >> > > +        i[[3456]]86|x86_64)
> >> > > +           pvshim="y";;
> >> > 
> >> > Since xen doesn't build on 32bit anymore you may want to exclude
> >> > i[3456]86 here?
> >> 
> >> Oh, I didn't realize this. Is it true for all distros?
> > 
> > FAOD I was thinking about 32bit xen support. But I just realise since
> > you tested host_cpu here, maybe you intended to do a cross-build?
> 
> If the intention is a cross build, then host CPU shouldn't matter at
> all, i.e. building e.g. on Arm should work as well.
> 
> When considering the target CPU, implying a 64-bit hypervisor from
> a 32-bit general (i.e. tool stack) target would of course be an option.
> Question just is how you would determine whether a suitable cross
> tool chain is available.

I think it would better to use target_cpu here, but limiting to x86_64
only seems wrong, since a user could build a 32bit toolstack and have
a 64bit pvshim. I'm not sure however if there are other issues that
would prevent this from working out of the box.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Roger Pau Monné]

On Tue, May 14, 2019 at 03:52:39AM -0600, Jan Beulich wrote:
> >>> On 14.05.19 at 11:23, <wei.liu2@citrix.com> wrote:
> > On Tue, May 14, 2019 at 10:55:18AM +0200, Roger Pau Monné wrote:
> >> On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
> >> > On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> >> > > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> >> > > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> >> > > > tools/firmware/Makefile? From my understanding there is no way to 
> > influence
> >> > > > its value from outside, which means the build always enters xen-dir/.
> >> > > 
> >> > > I think the following should do the trick.
> >> > > 
> >> > > Let me know if that works for you and I will submit it formally.
> >> > > 
> >> > > Thanks!
> >> > > 
> >> > > ---8<---
> >> > > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> >> > > index 98245f63c9..84ddb1a542 100644
> >> > > --- a/config/Tools.mk.in
> >> > > +++ b/config/Tools.mk.in
> >> > > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
> >> > >  ARGP_LDFLAGS        := @argp_ldflags@
> >> > >  
> >> > >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
> >> > > +
> >> > > +CONFIG_PV_SHIM      := @pvshim@
> >> > > diff --git a/tools/configure.ac b/tools/configure.ac
> >> > > index c9fd69ddfa..8df2fd604b 100644
> >> > > --- a/tools/configure.ac
> >> > > +++ b/tools/configure.ac
> >> > > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
> >> > >  
> >> > >  AC_SUBST(ninepfs)
> >> > >  
> >> > > +AC_ARG_ENABLE([pvshim],
> >> > > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, enabled by default)]),
> >> > > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> >> > > +    case "$host_cpu" in
> >> > > +        i[[3456]]86|x86_64)
> >> > > +           pvshim="y";;
> >> > 
> >> > Since xen doesn't build on 32bit anymore you may want to exclude
> >> > i[3456]86 here?
> >> 
> >> Oh, I didn't realize this. Is it true for all distros?
> > 
> > FAOD I was thinking about 32bit xen support. But I just realise since
> > you tested host_cpu here, maybe you intended to do a cross-build?
> 
> If the intention is a cross build, then host CPU shouldn't matter at
> all, i.e. building e.g. on Arm should work as well.
> 
> When considering the target CPU, implying a 64-bit hypervisor from
> a 32-bit general (i.e. tool stack) target would of course be an option.
> Question just is how you would determine whether a suitable cross
> tool chain is available.

I think it would better to use target_cpu here, but limiting to x86_64
only seems wrong, since a user could build a 32bit toolstack and have
a 64bit pvshim. I'm not sure however if there are other issues that
would prevent this from working out of the box.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Roger Pau Monné]

On Tue, May 14, 2019 at 12:34:06PM +0200, Olaf Hering wrote:
> Am Mon, 13 May 2019 17:20:05 +0200
> schrieb Roger Pau Monné <roger.pau@citrix.com>:
> 
> > enabled by default
> 
> Does anyone actually require it at all?

Hm, that's the default behavior so far (enabled on x86), so I would
like to keep it as-is.

> Those who do pass --enable-pvshim to configure. No need for (incorrect) host_cpu checks.

Using target_cpu should be fine I think.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Roger Pau Monné]

On Tue, May 14, 2019 at 12:34:06PM +0200, Olaf Hering wrote:
> Am Mon, 13 May 2019 17:20:05 +0200
> schrieb Roger Pau Monné <roger.pau@citrix.com>:
> 
> > enabled by default
> 
> Does anyone actually require it at all?

Hm, that's the default behavior so far (enabled on x86), so I would
like to keep it as-is.

> Those who do pass --enable-pvshim to configure. No need for (incorrect) host_cpu checks.

Using target_cpu should be fine I think.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Roger Pau Monné]

On Tue, May 14, 2019 at 03:26:53AM -0600, Jan Beulich wrote:
> >>> On 14.05.19 at 10:55, <roger.pau@citrix.com> wrote:
> > On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
> >> On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> >> > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> >> > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> >> > > tools/firmware/Makefile? From my understanding there is no way to 
> > influence
> >> > > its value from outside, which means the build always enters xen-dir/.
> >> > 
> >> > I think the following should do the trick.
> >> > 
> >> > Let me know if that works for you and I will submit it formally.
> >> > 
> >> > Thanks!
> >> > 
> >> > ---8<---
> >> > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> >> > index 98245f63c9..84ddb1a542 100644
> >> > --- a/config/Tools.mk.in
> >> > +++ b/config/Tools.mk.in
> >> > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
> >> >  ARGP_LDFLAGS        := @argp_ldflags@
> >> >  
> >> >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
> >> > +
> >> > +CONFIG_PV_SHIM      := @pvshim@
> >> > diff --git a/tools/configure.ac b/tools/configure.ac
> >> > index c9fd69ddfa..8df2fd604b 100644
> >> > --- a/tools/configure.ac
> >> > +++ b/tools/configure.ac
> >> > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
> >> >  
> >> >  AC_SUBST(ninepfs)
> >> >  
> >> > +AC_ARG_ENABLE([pvshim],
> >> > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, 
> > enabled by default)]),
> >> > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> >> > +    case "$host_cpu" in
> >> > +        i[[3456]]86|x86_64)
> >> > +           pvshim="y";;
> >> 
> >> Since xen doesn't build on 32bit anymore you may want to exclude
> >> i[3456]86 here?
> > 
> > Oh, I didn't realize this. Is it true for all distros?
> 
> It's a property of the hypervisor (note: not the tool stack), as of 4.3.

But the property is that the hypervisor requires an amd64 compatible
CPU to run, but it should build fine on 32bit.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Roger Pau Monné]

On Tue, May 14, 2019 at 03:26:53AM -0600, Jan Beulich wrote:
> >>> On 14.05.19 at 10:55, <roger.pau@citrix.com> wrote:
> > On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
> >> On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
> >> > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
> >> > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
> >> > > tools/firmware/Makefile? From my understanding there is no way to 
> > influence
> >> > > its value from outside, which means the build always enters xen-dir/.
> >> > 
> >> > I think the following should do the trick.
> >> > 
> >> > Let me know if that works for you and I will submit it formally.
> >> > 
> >> > Thanks!
> >> > 
> >> > ---8<---
> >> > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> >> > index 98245f63c9..84ddb1a542 100644
> >> > --- a/config/Tools.mk.in
> >> > +++ b/config/Tools.mk.in
> >> > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
> >> >  ARGP_LDFLAGS        := @argp_ldflags@
> >> >  
> >> >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
> >> > +
> >> > +CONFIG_PV_SHIM      := @pvshim@
> >> > diff --git a/tools/configure.ac b/tools/configure.ac
> >> > index c9fd69ddfa..8df2fd604b 100644
> >> > --- a/tools/configure.ac
> >> > +++ b/tools/configure.ac
> >> > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
> >> >  
> >> >  AC_SUBST(ninepfs)
> >> >  
> >> > +AC_ARG_ENABLE([pvshim],
> >> > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, 
> > enabled by default)]),
> >> > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> >> > +    case "$host_cpu" in
> >> > +        i[[3456]]86|x86_64)
> >> > +           pvshim="y";;
> >> 
> >> Since xen doesn't build on 32bit anymore you may want to exclude
> >> i[3456]86 here?
> > 
> > Oh, I didn't realize this. Is it true for all distros?
> 
> It's a property of the hypervisor (note: not the tool stack), as of 4.3.

But the property is that the hypervisor requires an amd64 compatible
CPU to run, but it should build fine on 32bit.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Jan Beulich]

>>> On 14.05.19 at 13:11, <roger.pau@citrix.com> wrote:
> On Tue, May 14, 2019 at 03:26:53AM -0600, Jan Beulich wrote:
>> >>> On 14.05.19 at 10:55, <roger.pau@citrix.com> wrote:
>> > On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
>> >> On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
>> >> > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
>> >> > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
>> >> > > tools/firmware/Makefile? From my understanding there is no way to 
>> > influence
>> >> > > its value from outside, which means the build always enters xen-dir/.
>> >> > 
>> >> > I think the following should do the trick.
>> >> > 
>> >> > Let me know if that works for you and I will submit it formally.
>> >> > 
>> >> > Thanks!
>> >> > 
>> >> > ---8<---
>> >> > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
>> >> > index 98245f63c9..84ddb1a542 100644
>> >> > --- a/config/Tools.mk.in
>> >> > +++ b/config/Tools.mk.in
>> >> > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
>> >> >  ARGP_LDFLAGS        := @argp_ldflags@
>> >> >  
>> >> >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
>> >> > +
>> >> > +CONFIG_PV_SHIM      := @pvshim@
>> >> > diff --git a/tools/configure.ac b/tools/configure.ac
>> >> > index c9fd69ddfa..8df2fd604b 100644
>> >> > --- a/tools/configure.ac
>> >> > +++ b/tools/configure.ac
>> >> > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>> >> >  
>> >> >  AC_SUBST(ninepfs)
>> >> >  
>> >> > +AC_ARG_ENABLE([pvshim],
>> >> > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, 
>> > enabled by default)]),
>> >> > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
>> >> > +    case "$host_cpu" in
>> >> > +        i[[3456]]86|x86_64)
>> >> > +           pvshim="y";;
>> >> 
>> >> Since xen doesn't build on 32bit anymore you may want to exclude
>> >> i[3456]86 here?
>> > 
>> > Oh, I didn't realize this. Is it true for all distros?
>> 
>> It's a property of the hypervisor (note: not the tool stack), as of 4.3.
> 
> But the property is that the hypervisor requires an amd64 compatible
> CPU to run, but it should build fine on 32bit.

Except that a typical gcc on 32-bit won't be able to build (64-bit)
Xen, nor would there be any place to enforce the necessary
XEN_TARGET_ARCH:=x86_64.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Jan Beulich]

>>> On 14.05.19 at 13:11, <roger.pau@citrix.com> wrote:
> On Tue, May 14, 2019 at 03:26:53AM -0600, Jan Beulich wrote:
>> >>> On 14.05.19 at 10:55, <roger.pau@citrix.com> wrote:
>> > On Mon, May 13, 2019 at 04:28:12PM +0100, Wei Liu wrote:
>> >> On Mon, May 13, 2019 at 05:20:05PM +0200, Roger Pau Monné wrote:
>> >> > On Mon, May 13, 2019 at 04:53:21PM +0200, Olaf Hering wrote:
>> >> > > What is the recommended way to disable CONFIG_PV_SHIM, which is set in
>> >> > > tools/firmware/Makefile? From my understanding there is no way to 
>> > influence
>> >> > > its value from outside, which means the build always enters xen-dir/.
>> >> > 
>> >> > I think the following should do the trick.
>> >> > 
>> >> > Let me know if that works for you and I will submit it formally.
>> >> > 
>> >> > Thanks!
>> >> > 
>> >> > ---8<---
>> >> > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
>> >> > index 98245f63c9..84ddb1a542 100644
>> >> > --- a/config/Tools.mk.in
>> >> > +++ b/config/Tools.mk.in
>> >> > @@ -75,3 +75,5 @@ TINFO_LIBS          := @TINFO_LIBS@
>> >> >  ARGP_LDFLAGS        := @argp_ldflags@
>> >> >  
>> >> >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
>> >> > +
>> >> > +CONFIG_PV_SHIM      := @pvshim@
>> >> > diff --git a/tools/configure.ac b/tools/configure.ac
>> >> > index c9fd69ddfa..8df2fd604b 100644
>> >> > --- a/tools/configure.ac
>> >> > +++ b/tools/configure.ac
>> >> > @@ -492,4 +492,15 @@ AC_ARG_ENABLE([9pfs],
>> >> >  
>> >> >  AC_SUBST(ninepfs)
>> >> >  
>> >> > +AC_ARG_ENABLE([pvshim],
>> >> > +    AS_HELP_STRING([--disable-pvshim], [Disable pvshim build (x86 only, 
>> > enabled by default)]),
>> >> > +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
>> >> > +    case "$host_cpu" in
>> >> > +        i[[3456]]86|x86_64)
>> >> > +           pvshim="y";;
>> >> 
>> >> Since xen doesn't build on 32bit anymore you may want to exclude
>> >> i[3456]86 here?
>> > 
>> > Oh, I didn't realize this. Is it true for all distros?
>> 
>> It's a property of the hypervisor (note: not the tool stack), as of 4.3.
> 
> But the property is that the hypervisor requires an amd64 compatible
> CPU to run, but it should build fine on 32bit.

Except that a typical gcc on 32-bit won't be able to build (64-bit)
Xen, nor would there be any place to enforce the necessary
XEN_TARGET_ARCH:=x86_64.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: how to disable build of pv-shim?

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 197 bytes --]

Am Mon, 13 May 2019 17:20:05 +0200
schrieb Roger Pau Monné <roger.pau@citrix.com>:

> Let me know if that works for you and I will submit it formally.

Yes, it works for me. Thanks.

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 197 bytes --]

Am Mon, 13 May 2019 17:20:05 +0200
schrieb Roger Pau Monné <roger.pau@citrix.com>:

> Let me know if that works for you and I will submit it formally.

Yes, it works for me. Thanks.

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 318 bytes --]

On Wed, May 15, Olaf Hering wrote:

> Am Mon, 13 May 2019 17:20:05 +0200
> schrieb Roger Pau Monné <roger.pau@citrix.com>:
> 
> > Let me know if that works for you and I will submit it formally.
> Yes, it works for me. Thanks.

Did you have a chance to submit a fix to support '--disable-pv-shim'?


Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] how to disable build of pv-shim?

[Roger Pau Monné]

On Wed, Aug 14, 2019 at 09:51:45AM +0200, Olaf Hering wrote:
> On Wed, May 15, Olaf Hering wrote:
> 
> > Am Mon, 13 May 2019 17:20:05 +0200
> > schrieb Roger Pau Monné <roger.pau@citrix.com>:
> > 
> > > Let me know if that works for you and I will submit it formally.
> > Yes, it works for me. Thanks.
> 
> Did you have a chance to submit a fix to support '--disable-pv-shim'?

Yes, it was committed quite some time ago, check 8845155c831c59:

http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=8845155c831c59e867ee3dd31ee63e0cc6c7dcf2

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel