From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>
Subject: Re: [Xen-devel] [PATCH v2 1/2] efi: remove old SetVirtualAddressMap() arrangement
Date: Sat, 12 Oct 2019 17:33:08 +0100 [thread overview]
Message-ID: <8ad5703e-2a34-16d3-5011-7be8b2997113@citrix.com> (raw)
In-Reply-To: <fdffd0a015106ef3f79c46a46a48ee1b1e3b7aa4.1570890895.git-series.marmarek@invisiblethingslab.com>
On 12/10/2019 15:36, Marek Marczykowski-Górecki wrote:
> Remove unused (#ifdef-ed out) code. Reviving it in its current shape
> won't fly because:
> - SetVirtualAddressMap() needs to be mapped with 1:1 mapping, which
> isn't the case at this time
> - it uses directmap, which is going away soon
> - it uses directmap, which is mapped with NX, breaking EfiRuntimeServicesCode
I think the second point is far more important than the first. After
all, there is no guarantee at this point that the directmap is going to
disappear unilaterally - that is simply one option at the moment.
>
> No functional change.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-12 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 14:36 [Xen-devel] [PATCH v2 0/2] Optionally call EFI SetVirtualAddressMap() Marek Marczykowski-Górecki
2019-10-12 14:36 ` [Xen-devel] [PATCH v2 1/2] efi: remove old SetVirtualAddressMap() arrangement Marek Marczykowski-Górecki
2019-10-12 16:33 ` Andrew Cooper [this message]
2019-10-12 14:36 ` [Xen-devel] [PATCH v2 2/2] xen/efi: optionally call SetVirtualAddressMap() Marek Marczykowski-Górecki
2019-10-12 16:29 ` Andrew Cooper
2019-10-12 17:00 ` Marek Marczykowski-Górecki
2019-10-12 17:09 ` Marek Marczykowski-Górecki
2019-10-12 17:13 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ad5703e-2a34-16d3-5011-7be8b2997113@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).