Re: [PATCH] xen: grant-table: Check truncation when giving access to a frame

From: Paul Durrant <Paul.Durrant@citrix.com>
To: Julien Grall <julien.grall@arm.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	David Vrabel <david.vrabel@citrix.com>,
	"jgross@suse.com" <jgross@suse.com>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"steve.capper@arm.com" <steve.capper@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"JBeulich@suse.com" <JBeulich@suse.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen: grant-table: Check truncation when giving access to a frame
Date: Mon, 13 Jun 2016 13:14:22 +0000	[thread overview]
Message-ID: <8b79fb2308344242a799f68df0f9eb54__44200.082604266$1465823771$gmane$org@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <575EAFA7.4020603@arm.com>

> -----Original Message-----
[snip]
> >
> > No, I meant the guest receive-side copy didn't scale, not grant table v2
> itself. Ok the table is bigger with v2, but to do guest receive-side copy
> required a huge table in dom0 if it was going to scale to 100s of VMs and the
> perf. benefits were never that great (if they were there at all).
> 
> Sorry I misunderstood your previous mail. So the only downside is the
> size of the table.
> 
> Looking at the structure in the header (public/grant_table.h), this is
> effectively much bigger. A commit in Linux [1] suggests that grant v2
> only supports 256 grants per page rather than 512 for v1.
> 

That's correct.

> How would that impact a guest?
> 

Well, for the same table size you'd get half as many refs.

If you don't have many vifs and vbds in your guest then you'll probably be fine. If you do then you might see pressure for free entries and some drivers may actually crash if they can't get what they want. I don't believe the size of the guest's grant table can be tuned by the toolstack... probably about time to add that capability.

  Paul

> Regards,
> 
> [1] commit 11c7ff17c9b6dbf3a4e4f36be30ad531a6cf0ec9
> Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Date:   Mon Jan 6 10:44:39 2014 -0500
>      xen/grant-table: Force to use v1 of grants.
> 
>      We have the framework to use v2, but there are no backends that
>      actually use it. The end result is that on PV we use v2 grants
>      and on PVHVM v1. The v1 has a capacity of 512 grants per page while
>      the v2 has 256 grants per page. This means we lose about 50%
>      capacity - and if we want more than 16 VIFs (each VIF takes
>      512 grants), then we are hitting the max per guest of 32.
> 
> So from my understanding the table is much more bigger.
> 
> --
> Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel