From: Eslam Elnikety <elnikety@amazon.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>,
"Eslam Elnikety" <elnikety@amazon.com>
Cc: xen-devel@lists.xenproject.org,
Paul Durrant <pdurrant@amazon.co.uk>,
Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/vhpet: Fix type size in timer_int_route_valid
Date: Tue, 28 Jul 2020 11:14:38 +0200 [thread overview]
Message-ID: <8c2a7d95-c830-485c-05c2-980994806425@amazon.com> (raw)
In-Reply-To: <20200728085815.GY7191@Air-de-Roger>
Hi Roger,
On 28.07.20 10:58, Roger Pau Monné wrote:
> On Tue, Jul 28, 2020 at 08:33:57AM +0000, Eslam Elnikety wrote:
>> The macro timer_int_route_cap evalutes to a 64 bit value. Extend the
>> size of left side of timer_int_route_valid to match.
>
> I'm very dull with this things, so forgive me.
>
> Isn't the left side just promoted to an unsigned 64bit value?
>
> Also timer_int_route will strictly be <= 31, which makes the shift
> safe?
This is all true. The size mismatch is indeed benign. The patch is only
for code sanity.
>
> I'm not opposed to switching to use unsigned long, but I think I'm not
> understanding the issue.
>
> Thanks, Roger.
>
Regards,
Eslam
next prev parent reply other threads:[~2020-07-28 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 8:33 [PATCH] x86/vhpet: Fix type size in timer_int_route_valid Eslam Elnikety
2020-07-28 8:58 ` Roger Pau Monné
2020-07-28 9:14 ` Eslam Elnikety [this message]
2020-07-28 9:26 ` Andrew Cooper
2020-07-28 11:09 ` Eslam Elnikety
2020-07-28 13:46 ` Andrew Cooper
2020-07-28 13:55 ` Eslam Elnikety
2020-07-28 17:51 ` Jan Beulich
2020-07-31 8:38 ` Eslam Elnikety
2020-07-31 9:53 ` Jan Beulich
2020-07-31 12:35 ` Julien Grall
2020-07-31 12:38 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c2a7d95-c830-485c-05c2-980994806425@amazon.com \
--to=elnikety@amazon.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=pdurrant@amazon.co.uk \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).