From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD8D1C2D0E4 for ; Fri, 27 Nov 2020 13:34:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 538E32224E for ; Fri, 27 Nov 2020 13:34:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="XYTi4ito" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 538E32224E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.39347.72216 (Exim 4.92) (envelope-from ) id 1kidt8-0000wm-6A; Fri, 27 Nov 2020 13:34:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 39347.72216; Fri, 27 Nov 2020 13:34:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kidt8-0000wf-2b; Fri, 27 Nov 2020 13:34:14 +0000 Received: by outflank-mailman (input) for mailman id 39347; Fri, 27 Nov 2020 13:34:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kidt7-0000wZ-6G for xen-devel@lists.xenproject.org; Fri, 27 Nov 2020 13:34:13 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 57d78dd0-a197-40d1-a976-7e92f73930b3; Fri, 27 Nov 2020 13:34:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 081C6AC23; Fri, 27 Nov 2020 13:34:11 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kidt7-0000wZ-6G for xen-devel@lists.xenproject.org; Fri, 27 Nov 2020 13:34:13 +0000 X-Inumbo-ID: 57d78dd0-a197-40d1-a976-7e92f73930b3 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 57d78dd0-a197-40d1-a976-7e92f73930b3; Fri, 27 Nov 2020 13:34:11 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1606484051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+GnPMFkpmvYnH9SSx8g39Wy3zLm8uM9xXY/9+JAMpA=; b=XYTi4itoSDeaJs25MP6jc9C6HWEv9TV1owHWcMi56kTge+JInmBYU0RFhFe2Fq0gmf8kvx CUcQmT2bNomV1CAsIcS4qDdn/wjUGhK30V7mmYSRC3VEACiKmP1jXamdASTq+W0cvzSwP2 UgUlX3oqqnQ6B23v6GU6gJgF4qpoW6o= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 081C6AC23; Fri, 27 Nov 2020 13:34:11 +0000 (UTC) Subject: Re: [PATCH v4 1/3] xen/pci: Move x86 specific code to x86 directory. To: Rahul Singh Cc: bertrand.marquis@arm.com, Paul Durrant , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <3500f44e3b6f8f05f9d05fa170817d5bc6f39f22.1606326929.git.rahul.singh@arm.com> From: Jan Beulich Message-ID: <8da65cee-2229-bb11-89f3-0a7db80e999b@suse.com> Date: Fri, 27 Nov 2020 14:34:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <3500f44e3b6f8f05f9d05fa170817d5bc6f39f22.1606326929.git.rahul.singh@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 25.11.2020 19:16, Rahul Singh wrote: > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -14,9 +14,6 @@ > * this program; If not, see . > */ > > -#include > -#include > -#include > #include > #include > #include At least the latter two of the lines you remove are clearly still needed here, and in such a case are better to specify explicitly than to depend on other headers including them. Since xen/sched.h very likely also gets included indirectly anyway, I'm inclined to suggest to drop this entire hunk (which ought to be doable while committing). With this Acked-by: Jan Beulich Jan