From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH v3 2/6] build: convert crash_debug to Kconfig Date: Wed, 11 May 2016 12:35:56 -0500 Message-ID: <8f1adc1b-0639-46ff-caec-2db9b0578f4a@cardoe.com> References: <1462914329-8797-1-git-send-email-cardoe@cardoe.com> <1462914329-8797-3-git-send-email-cardoe@cardoe.com> <57331BB702000078000EA7E6@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5809272813212790200==" Return-path: In-Reply-To: <57331BB702000078000EA7E6@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Tim Deegan , Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============5809272813212790200== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PJ8jWe8cdu3PRheTVswEiNp5LmnhXVNCD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PJ8jWe8cdu3PRheTVswEiNp5LmnhXVNCD Content-Type: multipart/mixed; boundary="7qDLLvnTWIirKFbr9V3psHIWJX3nLiO66" From: Doug Goldstein To: Jan Beulich Cc: Andrew Cooper , Wei Liu , George Dunlap , Ian Jackson , Stefano Stabellini , xen-devel@lists.xen.org, Konrad Rzeszutek Wilk , Tim Deegan Message-ID: <8f1adc1b-0639-46ff-caec-2db9b0578f4a@cardoe.com> Subject: Re: [PATCH v3 2/6] build: convert crash_debug to Kconfig References: <1462914329-8797-1-git-send-email-cardoe@cardoe.com> <1462914329-8797-3-git-send-email-cardoe@cardoe.com> <57331BB702000078000EA7E6@prv-mh.provo.novell.com> In-Reply-To: <57331BB702000078000EA7E6@prv-mh.provo.novell.com> --7qDLLvnTWIirKFbr9V3psHIWJX3nLiO66 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 5/11/16 4:47 AM, Jan Beulich wrote: >>>> On 10.05.16 at 23:05, wrote: >> --- a/xen/Kconfig.debug >> +++ b/xen/Kconfig.debug >> @@ -1,6 +1,13 @@ >> =20 >> menu "Debugging Options" >> =20 >> +config CRASH_DEBUG >> + bool "Crash Debugging Support" >> + depends on X86 >> + ---help--- >> + If you want to be able to attach gdb to Xen to be able to debug >> + Xen if it crashes then say Y. >> + >> config DEBUG >> bool "Developer Checks" >> ---help--- >=20 > Is this really meant to be independent of DEBUG (or EXPERT), as it's > being placed ahead of DEBUG? >=20 > Jan >=20 That's what we talked about with v2. You wanted it to be independent if EXPERT was set but when you have something defined as "menuconfig XXXX" you cannot then have a rule "if XXXX || EXPERT" as you asked for in v2. So I needed to make them independent always which is what I did. Let me restate more generically, if things are dependent on a menu for the sub-menu items to be displayed (as in v2) then the menu must be enabled and cannot be conditionally displayed on another option. Roughly think of it this way: menuconfig SOME_STATE if SOME_STATE || EXPERT config OTHER endif is the following code: if (SOME_STATE) { if (SOME_STATE or EXPERT) { printf("got here\n"); } } --=20 Doug Goldstein --7qDLLvnTWIirKFbr9V3psHIWJX3nLiO66-- --PJ8jWe8cdu3PRheTVswEiNp5LmnhXVNCD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJXM21/XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUHCgP/RE+5azZ8RtVo1vkJOZNl1PX 70kwdYI6vo7XOAWJ0dPUGImMHKL77447D4JEvLN/Z3TQEmCPqNXuTKIrTKCrjH7t 1shADdLY+brfpsIKYEOljqdqysqaWrJw786nH2qCKYOpsd5Dg8optWnnsuwSyamQ 8k+b6h9Aqh1G5Nm79pTL9XkzVmkx+MDkGoPsTzf6OqIUcif0fRqRSfeQvKYFGIE5 Oq0AD7PgQUNmKtA+pPb90WOPnbLwRj/QxhIHOJDvMr9Fiqxvny+MRtY6aieirDIS SC4OnQlB1y9tkvDeeXffL63fS+pQ12EphaF2d08ZD475gZtG6aAoS+EtLcicBiJk 62TzU/bNAS+SrK1BacbjSPCL+jtA49SRsmTOxUU8VJZPFYZhSGW68Nut0l4WDi6A lb8Dwzew1ozYx9ZIuNnChcOngBwYrnGPZ9acsgoUygTDpifxe47svfekD2xrty3P LBzkENSa9C9iKPEtTRGYwUEz4zO4Ke9Q05rZvn4xMeCmCeumrYy5NbmtkNDKtJKV VMFC/xFZiOrlLtTvZl7KxT30sxDQ+aBwOts1v8OWW5wiKAgD9LecWlSz9xbxfSEF AlXo5MZyl2xKdCPIdwNHR1wJGg3I1aX9IcAQmNNd9G/6gn8W3i3E7nYVJoBngacd PsHnnfjNgzoxQ27JG3sa =lAO3 -----END PGP SIGNATURE----- --PJ8jWe8cdu3PRheTVswEiNp5LmnhXVNCD-- --===============5809272813212790200== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============5809272813212790200==--