From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AEC9C433DB for ; Tue, 30 Mar 2021 16:03:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D08F619C0 for ; Tue, 30 Mar 2021 16:03:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D08F619C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.103630.197658 (Exim 4.92) (envelope-from ) id 1lRGpP-0000d4-53; Tue, 30 Mar 2021 16:02:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103630.197658; Tue, 30 Mar 2021 16:02:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGpP-0000cx-1o; Tue, 30 Mar 2021 16:02:51 +0000 Received: by outflank-mailman (input) for mailman id 103630; Tue, 30 Mar 2021 16:02:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGpN-0000co-8N for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 16:02:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6f893969-d87f-428a-9b57-08252bfe948c; Tue, 30 Mar 2021 16:02:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B9725AE58; Tue, 30 Mar 2021 16:02:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f893969-d87f-428a-9b57-08252bfe948c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617120165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=biXeeW4QG/QmGWSileBXMFFHvXOGPsruR/cTGFy1Le4=; b=t6qP1Ayetncyn4h7av2yhnl4xkyHR0DqoWKhdF8Nc+Wnamv3BIokDsZyg/nzP1S5M1mUrL ayrEs5aWT8Tk5YK4eZEzuQ65P/rxN0v0Vf9vd3Vlc4RS28u6H0rsPE7v4c9LykNH1+A6Vl 0lZZUuwJTYYxeIp86YemlUUHerp4hbI= Subject: Re: [PATCH 14/21] libs/guest: introduce helper to check cpu policy compatibility To: Roger Pau Monne Cc: Andrew Cooper , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-15-roger.pau@citrix.com> From: Jan Beulich Message-ID: <8f7a2f44-c006-0f94-8f44-b6b3ee3e9d1f@suse.com> Date: Tue, 30 Mar 2021 18:02:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210323095849.37858-15-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.03.2021 10:58, Roger Pau Monne wrote: > --- a/tools/libs/guest/xg_cpuid_x86.c > +++ b/tools/libs/guest/xg_cpuid_x86.c > @@ -1098,3 +1098,20 @@ int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t policy, > return rc; > > } > + > +bool xc_cpu_policy_is_compatible(xc_interface *xch, const xc_cpu_policy_t p1, > + const xc_cpu_policy_t p2) > +{ > + struct cpu_policy_errors err; Don't you need an initializer here for ... > + int rc = x86_cpu_policies_are_compatible(p1, p2, &err); > + > + if ( !rc ) > + return true; > + > + if ( err.leaf != -1 ) > + ERROR("Leaf %#x subleaf %#x is not compatible", err.leaf, err.subleaf); > + if ( err.msr != -1 ) > + ERROR("MSR index %#x is not compatible", err.msr); ... these checks to have a chance of actually triggering? (I'm also not certain -1 is a good indicator, but I guess we have been using it elsewhere as well.) Jan