From: Artur Puzio <artur@puzio.waw.pl>
To: paul@xen.org, 'Grzegorz Uriasz' <gorbak25@gmail.com>,
qemu-devel@nongnu.org
Cc: 'Stefano Stabellini' <sstabellini@kernel.org>,
jakub@bartmin.ski, marmarek@invisiblethingslab.com,
'Anthony Perard' <anthony.perard@citrix.com>,
j.nowak26@student.uw.edu.pl, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/2] Fix undefined behaviour
Date: Tue, 28 Apr 2020 11:40:46 +0200 [thread overview]
Message-ID: <90a8b709-c506-92e2-800c-e1558f18df94@puzio.waw.pl> (raw)
In-Reply-To: <000001d61d34$6c0218f0$44064ad0$@xen.org>
On 28.04.2020 10:10, Paul Durrant wrote:
>> -----Original Message-----
>> From: Grzegorz Uriasz <gorbak25@gmail.com>
>> Sent: 28 April 2020 07:29
>> To: qemu-devel@nongnu.org
>> Cc: Grzegorz Uriasz <gorbak25@gmail.com>; marmarek@invisiblethingslab.com; artur@puzio.waw.pl;
>> jakub@bartmin.ski; j.nowak26@student.uw.edu.pl; Stefano Stabellini <sstabellini@kernel.org>; Anthony
>> Perard <anthony.perard@citrix.com>; Paul Durrant <paul@xen.org>; xen-devel@lists.xenproject.org
>> Subject: [PATCH 1/2] Fix undefined behaviour
>>
>> Signed-off-by: Grzegorz Uriasz <gorbak25@gmail.com>
> I think we need more of a commit comment for both this and patch #2 to explain why you are making the changes.
>
> Paul
I agree Grzegorz should improve the commit messages. In the mean time
see email with subject "[PATCH 0/2] Fix QEMU crashes when passing IGD to
a guest VM under XEN", it contains quite detailed explanation for both
"Fix undefined behaviour" and "Improve legacy vbios handling" patches.
Artur Puzio
next prev parent reply other threads:[~2020-04-28 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 6:28 [PATCH 0/2] Fix QEMU crashes when passing IGD to a guest VM under XEN Grzegorz Uriasz
2020-04-28 6:28 ` [PATCH 1/2] Fix undefined behaviour Grzegorz Uriasz
2020-04-28 8:10 ` Paul Durrant
2020-04-28 9:40 ` Artur Puzio [this message]
2020-04-28 12:32 ` Paul Durrant
2020-04-28 12:33 ` Paul Durrant
2020-04-28 8:58 ` Peter Maydell
2020-04-28 6:28 ` [PATCH 2/2] Improve legacy vbios handling Grzegorz Uriasz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90a8b709-c506-92e2-800c-e1558f18df94@puzio.waw.pl \
--to=artur@puzio.waw.pl \
--cc=anthony.perard@citrix.com \
--cc=gorbak25@gmail.com \
--cc=j.nowak26@student.uw.edu.pl \
--cc=jakub@bartmin.ski \
--cc=marmarek@invisiblethingslab.com \
--cc=paul@xen.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).