From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84FFFC2BA1A for ; Fri, 24 Apr 2020 09:20:43 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3386D20724 for ; Fri, 24 Apr 2020 09:20:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="LSqW0fXF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3386D20724 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRuVV-0001ga-PB; Fri, 24 Apr 2020 09:20:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRuVU-0001gV-Kc for xen-devel@lists.xenproject.org; Fri, 24 Apr 2020 09:20:24 +0000 X-Inumbo-ID: d3f68e64-860c-11ea-9476-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d3f68e64-860c-11ea-9476-12813bfff9fa; Fri, 24 Apr 2020 09:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e+Vx3UfGuzVec4LjAQrU71RjeWzo1J/YLdYmSfGODJg=; b=LSqW0fXFixFv+IbFcJpr6ogOUs +Im/zgO0ofvAbOcC5SOL3WBCQ5oykQyAGB+DdHOPY/b/cuiej27gEkb+mN3KM4rlF2l88sw3ZKzAW RFSnN9ii8KlOGmvJ2hCUnhY2LMqOHKja0bnGzp6v6xGKpzv2V3XMX4eznFdlRxpeVXZ0=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRuVQ-0003s0-EX; Fri, 24 Apr 2020 09:20:20 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1jRuVQ-0005Oi-4p; Fri, 24 Apr 2020 09:20:20 +0000 Subject: Re: [XEN PATCH v5 03/16] xen/build: use new $(c_flags) and $(a_flags) instead of $(CFLAGS) To: Anthony PERARD , xen-devel@lists.xenproject.org References: <20200421161208.2429539-1-anthony.perard@citrix.com> <20200421161208.2429539-4-anthony.perard@citrix.com> From: Julien Grall Message-ID: <91b44d25-a10e-fdd2-2fbc-84f5ae3e5a36@xen.org> Date: Fri, 24 Apr 2020 10:20:17 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200421161208.2429539-4-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Tim Deegan , Jan Beulich , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, On 21/04/2020 17:11, Anthony PERARD wrote: > In a later patch ("xen/build: have the root Makefile generates the > CFLAGS), we want to generate the CFLAGS in xen/Makefile, then export > it and have Rules.mk use a CFLAGS from the environment variables. That > changes the flavor of the CFLAGS and flags intended for one target > (like -D__OBJECT_FILE__ and -M%) gets propagated and duplicated. So we > start by moving such flags out of $(CFLAGS) and into $(c_flags) which > is to be modified by only Rules.mk. > > __OBJECT_FILE__ is only used by arch/x86/mm/*.c files, so having it in > $(c_flags) is enough, we don't need it in $(a_flags). > > For include/Makefile and as-insn we can keep using CFLAGS, but since > it doesn't have -M* flags anymore there is no need to filter them out. > > The XEN_BUILD_EFI tests in arch/x86/Makefile was filtering out > CFLAGS-y, but according to dd40177c1bc8 ("x86-64/EFI: add CFLAGS to > check compile"), it was done to filter out -MF. CFLAGS doesn't > have those flags anymore, so no filtering is needed. > > This is inspired by the way Kbuild generates CFLAGS for each targets. > > Signed-off-by: Anthony PERARD > Reviewed-by: Roger Pau Monné > Reviewed-by: Jan Beulich For the Arm bits: Acked-by: Julien Grall Cheers, -- Julien Grall