From: Paul Durrant <Paul.Durrant@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Wei Liu <wl@xen.org>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Brian Woods <brian.woods@amd.com>
Subject: Re: [Xen-devel] [PATCH v2 1/4] iommu / x86: move call to scan_pci_devices() out of vendor code
Date: Tue, 16 Jul 2019 09:40:52 +0000 [thread overview]
Message-ID: <9451b88fe12c4193817d807dfa45c857@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <20190715143916.njsdhhugibaquwhg@Air-de-Roger.citrite.net>
> -----Original Message-----
> From: Roger Pau Monne <roger.pau@citrix.com>
> Sent: 15 July 2019 15:39
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>; Brian Woods
> <brian.woods@amd.com>; Kevin Tian <kevin.tian@intel.com>; Jan Beulich <jbeulich@suse.com>; Andrew
> Cooper <Andrew.Cooper3@citrix.com>; Wei Liu <wl@xen.org>
> Subject: Re: [PATCH v2 1/4] iommu / x86: move call to scan_pci_devices() out of vendor code
>
> On Mon, Jul 15, 2019 at 01:37:07PM +0100, Paul Durrant wrote:
> > It's not vendor specific so it doesn't really belong there.
> >
> > Scanning the PCI topology also really doesn't have much to do with IOMMU
> > initialization. It doesn't depend on there even being an IOMMU. This patch
> > moves to the call to the beginning of iommu_hardware_setup() but only
> > places it there because the topology information would be otherwise unused.
> >
> > Subsequent patches will actually make use of the PCI topology during
> > (x86) IOMMU initialization.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
>
Thanks.
> I would even consider moving the call to scan_pci_devices into
> pci_segments_init instead of doing it in the IOMMU code, as you
> suggest above.
Possibly, although without an IOMMU in the system I don't think there is currently a lot of point in populating the pdev list.
Paul
>
> Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-16 9:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 12:37 [Xen-devel] [PATCH v2 0/4] iommu groups + cleanup Paul Durrant
2019-07-15 12:37 ` [Xen-devel] [PATCH v2 1/4] iommu / x86: move call to scan_pci_devices() out of vendor code Paul Durrant
2019-07-15 14:39 ` Roger Pau Monné
2019-07-16 9:40 ` Paul Durrant [this message]
2019-07-16 14:07 ` Woods, Brian
2019-07-15 12:37 ` [Xen-devel] [PATCH v2 2/4] pci: add all-device iterator function Paul Durrant
2019-07-15 15:21 ` Roger Pau Monné
2019-07-16 9:48 ` Paul Durrant
2019-07-15 12:37 ` [Xen-devel] [PATCH v2 3/4] iommu: introduce iommu_groups Paul Durrant
2019-07-15 15:34 ` Roger Pau Monné
2019-07-15 15:41 ` Paul Durrant
2019-07-16 8:56 ` Roger Pau Monné
2019-07-16 9:17 ` Paul Durrant
2019-07-15 12:37 ` [Xen-devel] [PATCH v2 4/4] iommu / pci: re-implement XEN_DOMCTL_get_device_group Paul Durrant
2019-07-15 15:46 ` Roger Pau Monné
2019-07-15 15:48 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9451b88fe12c4193817d807dfa45c857@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=brian.woods@amd.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).