From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Xu, Quan" Subject: Re: [PATCH v8 2/7] Qemu-Xen-vTPM: Create a new file xen_pvdev.c Date: Tue, 23 Jun 2015 06:43:43 +0000 Message-ID: <945CA011AD5F084CBEA3E851C0AB28890E930C91__2468.37338568202$1435041956$gmane$org@SHSMSX101.ccr.corp.intel.com> References: <1431840030-2797-1-git-send-email-quan.xu@intel.com> <1431840030-2797-4-git-send-email-quan.xu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: "wei.liu2@citrix.com" , "stefanb@linux.vnet.ibm.com" , "qemu-devel@nongnu.org" , "xen-devel@lists.xen.org" , "dgdegra@tycho.nsa.gov" , "eblake@redhat.com" List-Id: xen-devel@lists.xenproject.org > -----Original Message----- > From: Stefano Stabellini [mailto:stefano.stabellini@eu.citrix.com] > Sent: Tuesday, June 23, 2015 12:37 AM > To: Xu, Quan > Cc: stefano.stabellini@eu.citrix.com; qemu-devel@nongnu.org; > stefanb@linux.vnet.ibm.com; eblake@redhat.com; wei.liu2@citrix.com; > dgdegra@tycho.nsa.gov; xen-devel@lists.xen.org > Subject: Re: [PATCH v8 2/7] Qemu-Xen-vTPM: Create a new file xen_pvdev.c > > On Sun, 17 May 2015, Quan Xu wrote: > > for some common part of xen frontend and backend, such as xendevs > > queue and xenstore update functions. > > > > Signed-off-by: Quan Xu > > Hi Quan, > > could you please separate out the code movement from any other changes? > This patch would become two patches: the first would only move code from > xen_backend.c to xen_pvdev.c, no other changes except for the ones actually > required to build the code (Makefile.objs). The second patch would rename > xen_be_find_xendev to xen_find_xendev and any other changes to the code > that you making here. That way I can very easily go and look only at the things > you actually modify. > > Thanks, > > Stefano > > Stefano, thanks for your comment. Now I am focusing on ' VT-d async invalidation for Device-TLB' feature as high priority. I will fix all of your comments when I send out v1 of ' VT-d async invalidation for Device-TLB' feature. Quan