From: Jan Beulich <jbeulich@suse.com>
To: "Kevin Tian" <kevin.tian@intel.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Jun Nakajima" <jun.nakajima@intel.com>
Cc: Wei Liu <wl@xen.org>, Ian Jackson <iwj@xenproject.org>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 1/2][4.15] VMX: delay p2m insertion of APIC access page
Date: Thu, 25 Feb 2021 09:44:25 +0100 [thread overview]
Message-ID: <94ac725c-ae3a-5380-aaa0-c8523074b581@suse.com> (raw)
In-Reply-To: <90271e69-c07e-a32c-5531-a79b10ef03dd@suse.com>
On 22.02.2021 11:56, Jan Beulich wrote:
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -428,6 +428,14 @@ static void vmx_domain_relinquish_resour
> vmx_free_vlapic_mapping(d);
> }
>
> +static void domain_creation_finished(struct domain *d)
> +{
> + if ( has_vlapic(d) && !mfn_eq(d->arch.hvm.vmx.apic_access_mfn, _mfn(0)) &&
> + set_mmio_p2m_entry(d, gaddr_to_gfn(APIC_DEFAULT_PHYS_BASE),
> + d->arch.hvm.vmx.apic_access_mfn, PAGE_ORDER_4K) )
> + domain_crash(d);
> +}
Having noticed that in patch 2 I also need to arrange for
ept_get_entry_emt() to continue to return WB for this page, I'm
inclined to add a respective assertion here. Would anyone object
to me doing so?
Kevin, Jun - I'd like this to also serve as a ping for an ack
(with or without the suggested ASSERT() addition).
Jan
next prev parent reply other threads:[~2021-02-25 8:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 10:55 [PATCH v3 0/2] VMX: apic access page handling adjustments Jan Beulich
2021-02-22 10:56 ` [PATCH v3 1/2][4.15] VMX: delay p2m insertion of APIC access page Jan Beulich
2021-02-22 11:25 ` Ian Jackson
2021-02-22 14:05 ` Jan Beulich
2021-02-22 17:17 ` Ian Jackson
2021-02-22 12:15 ` Roger Pau Monné
2021-02-25 8:44 ` Jan Beulich [this message]
2021-02-26 7:06 ` Tian, Kevin
2021-02-22 10:57 ` [PATCH v3 2/2] VMX: use a single, global " Jan Beulich
2021-03-01 2:34 ` Tian, Kevin
2021-03-01 8:18 ` Jan Beulich
2021-04-12 10:40 ` [PATCH v4] " Jan Beulich
2021-04-12 15:31 ` Roger Pau Monné
2021-04-13 9:24 ` Jan Beulich
2021-04-13 10:18 ` Roger Pau Monné
2021-04-13 12:03 ` Jan Beulich
2021-04-13 13:03 ` Roger Pau Monné
2021-04-17 19:24 ` Tim Deegan
2021-04-19 11:25 ` Jan Beulich
2021-04-22 7:42 ` Tim Deegan
2021-04-22 9:38 ` Jan Beulich
2021-04-22 15:05 ` Tim Deegan
2021-04-23 10:51 ` [PATCH v4 0/3] VMX APIC access page and shadow adjustments Jan Beulich
2021-04-23 10:52 ` [PATCH v4 1/3] VMX: use a single, global APIC access page Jan Beulich
2021-04-23 14:17 ` Roger Pau Monné
2021-04-23 14:42 ` Jan Beulich
2021-04-26 17:55 ` Tim Deegan
2021-04-25 1:27 ` Tian, Kevin
2021-04-26 17:53 ` Tim Deegan
2021-04-23 10:53 ` [PATCH v4 2/3] x86/shadow: re-use variables in shadow_get_page_from_l1e() Jan Beulich
2021-04-23 10:54 ` [PATCH v4 3/3] x86/shadow: streamline shadow_get_page_from_l1e() Jan Beulich
2021-04-23 11:00 ` Really v5 (was: [PATCH v4 0/3] VMX APIC access page and shadow adjustments) Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94ac725c-ae3a-5380-aaa0-c8523074b581@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).